feat(#93): implement agent spawn via federation

Implements FED-010: Agent Spawn via Federation feature that enables
spawning and managing Claude agents on remote federated Mosaic Stack
instances via COMMAND message type.

Features:
- Federation agent command types (spawn, status, kill)
- FederationAgentService for handling agent operations
- Integration with orchestrator's agent spawner/lifecycle services
- API endpoints for spawning, querying status, and killing agents
- Full command routing through federation COMMAND infrastructure
- Comprehensive test coverage (12/12 tests passing)

Architecture:
- Hub → Spoke: Spawn agents on remote instances
- Command flow: FederationController → FederationAgentService →
  CommandService → Remote Orchestrator
- Response handling: Remote orchestrator returns agent status/results
- Security: Connection validation, signature verification

Files created:
- apps/api/src/federation/types/federation-agent.types.ts
- apps/api/src/federation/federation-agent.service.ts
- apps/api/src/federation/federation-agent.service.spec.ts

Files modified:
- apps/api/src/federation/command.service.ts (agent command routing)
- apps/api/src/federation/federation.controller.ts (agent endpoints)
- apps/api/src/federation/federation.module.ts (service registration)
- apps/orchestrator/src/api/agents/agents.controller.ts (status endpoint)
- apps/orchestrator/src/api/agents/agents.module.ts (lifecycle integration)

Testing:
- 12/12 tests passing for FederationAgentService
- All command service tests passing
- TypeScript compilation successful
- Linting passed

Refs #93

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Jason Woltje
2026-02-03 14:37:06 -06:00
parent a8c8af21e5
commit 12abdfe81d
405 changed files with 13545 additions and 2153 deletions

View File

@@ -1,16 +1,20 @@
# Issue ORCH-106: Docker sandbox isolation
## Objective
Implement Docker container isolation for agents using dockerode to provide security isolation, resource limits, and proper cleanup.
## Approach
Following TDD principles:
1. Write tests for DockerSandboxService
2. Implement DockerSandboxService with dockerode
3. Add configuration support (DOCKER_SOCKET, SANDBOX_ENABLED)
4. Ensure proper cleanup on agent completion
## Acceptance Criteria
- [ ] `src/spawner/docker-sandbox.service.ts` implemented
- [ ] dockerode integration for container management
- [ ] Agent runs in isolated container
@@ -21,6 +25,7 @@ Following TDD principles:
- [ ] Test coverage >= 85%
## Progress
- [x] Read issue requirements from M6-NEW-ISSUES-TEMPLATES.md
- [x] Review existing orchestrator structure
- [x] Verify dockerode is installed in package.json
@@ -44,6 +49,7 @@ Following TDD principles:
ORCH-106 implementation completed successfully on 2026-02-02.
All acceptance criteria met:
- DockerSandboxService fully implemented with comprehensive test coverage
- Security features: non-root user, resource limits, network isolation
- Configuration-driven with environment variables
@@ -55,6 +61,7 @@ Issue: https://git.mosaicstack.dev/mosaic/stack/issues/241
## Technical Notes
### Key Components
1. **DockerSandboxService**: Main service for container management
2. **Configuration**: Load from orchestrator.config.ts
3. **Resource Limits**: CPU and memory constraints
@@ -62,6 +69,7 @@ Issue: https://git.mosaicstack.dev/mosaic/stack/issues/241
5. **Cleanup**: Proper container removal on termination
### Docker Container Spec
- Base image: node:20-alpine
- Non-root user: nodejs:nodejs
- Resource limits:
@@ -72,6 +80,7 @@ Issue: https://git.mosaicstack.dev/mosaic/stack/issues/241
- Auto-remove: false (manual cleanup for audit)
### Integration with AgentSpawnerService
- Check if sandbox mode enabled via options.sandbox
- If enabled, create Docker container via DockerSandboxService
- Mount workspace volume for git operations
@@ -79,6 +88,7 @@ Issue: https://git.mosaicstack.dev/mosaic/stack/issues/241
- Cleanup container on agent completion/failure/kill
## Testing Strategy
1. Unit tests for DockerSandboxService:
- createContainer() - success and failure cases
- startContainer() - success and failure cases
@@ -91,11 +101,13 @@ Issue: https://git.mosaicstack.dev/mosaic/stack/issues/241
3. Test error handling for Docker failures
## Dependencies
- dockerode (already installed)
- @types/dockerode (already installed)
- ConfigService from @nestjs/config
## Related Files
- `/home/localadmin/src/mosaic-stack/apps/orchestrator/src/spawner/agent-spawner.service.ts`
- `/home/localadmin/src/mosaic-stack/apps/orchestrator/src/config/orchestrator.config.ts`
- `/home/localadmin/src/mosaic-stack/apps/orchestrator/src/spawner/types/agent-spawner.types.ts`