From 1c79da70a69c8c889661a8a58fb748b1cb67572e Mon Sep 17 00:00:00 2001
From: Jason Woltje <jason.woltje@uscllc.com>
Date: Thu, 5 Feb 2026 17:50:18 -0600
Subject: [PATCH] fix(#338): Handle non-OK responses in ActiveProjectsWidget

- Add error state tracking for both projects and agents API calls
- Show error UI (amber alert icon + message) when fetch fails
- Clear data on error to avoid showing stale information
- Added tests for error handling: API failures, network errors

Refs #338

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 .../widgets/ActiveProjectsWidget.tsx          |  24 ++++
 .../__tests__/ActiveProjectsWidget.test.tsx   | 106 ++++++++++++++++++
 2 files changed, 130 insertions(+)

diff --git a/apps/web/src/components/widgets/ActiveProjectsWidget.tsx b/apps/web/src/components/widgets/ActiveProjectsWidget.tsx
index cc64a5d..1db97d5 100644
--- a/apps/web/src/components/widgets/ActiveProjectsWidget.tsx
+++ b/apps/web/src/components/widgets/ActiveProjectsWidget.tsx
@@ -38,17 +38,23 @@ export function ActiveProjectsWidget({ id: _id, config: _config }: WidgetProps):
   const [agentSessions, setAgentSessions] = useState<AgentSession[]>([]);
   const [isLoadingProjects, setIsLoadingProjects] = useState(true);
   const [isLoadingAgents, setIsLoadingAgents] = useState(true);
+  const [projectsError, setProjectsError] = useState<string | null>(null);
+  const [agentsError, setAgentsError] = useState<string | null>(null);
   const [expandedSession, setExpandedSession] = useState<string | null>(null);
 
   // Fetch active projects
   useEffect(() => {
     const fetchProjects = async (): Promise<void> => {
       try {
+        setProjectsError(null);
         // Use API client to ensure CSRF token is included
         const data = await apiPost<ActiveProject[]>("/api/widgets/data/active-projects");
         setProjects(data);
       } catch (error) {
         console.error("Failed to fetch active projects:", error);
+        const errorMessage = error instanceof Error ? error.message : "Unknown error";
+        setProjectsError(errorMessage);
+        setProjects([]);
       } finally {
         setIsLoadingProjects(false);
       }
@@ -67,11 +73,15 @@ export function ActiveProjectsWidget({ id: _id, config: _config }: WidgetProps):
   useEffect(() => {
     const fetchAgentSessions = async (): Promise<void> => {
       try {
+        setAgentsError(null);
         // Use API client to ensure CSRF token is included
         const data = await apiPost<AgentSession[]>("/api/widgets/data/agent-chains");
         setAgentSessions(data);
       } catch (error) {
         console.error("Failed to fetch agent sessions:", error);
+        const errorMessage = error instanceof Error ? error.message : "Unknown error";
+        setAgentsError(errorMessage);
+        setAgentSessions([]);
       } finally {
         setIsLoadingAgents(false);
       }
@@ -137,6 +147,13 @@ export function ActiveProjectsWidget({ id: _id, config: _config }: WidgetProps):
         <div className="overflow-auto max-h-48 space-y-2">
           {isLoadingProjects ? (
             <div className="text-center text-gray-500 text-xs py-4">Loading projects...</div>
+          ) : projectsError ? (
+            <div className="text-center text-xs py-4">
+              <div className="flex items-center justify-center gap-1 text-amber-600">
+                <AlertCircle className="w-3 h-3" />
+                <span>Unable to load projects</span>
+              </div>
+            </div>
           ) : projects.length === 0 ? (
             <div className="text-center text-gray-500 text-xs py-4">No active projects</div>
           ) : (
@@ -185,6 +202,13 @@ export function ActiveProjectsWidget({ id: _id, config: _config }: WidgetProps):
         <div className="overflow-auto max-h-48 space-y-2">
           {isLoadingAgents ? (
             <div className="text-center text-gray-500 text-xs py-4">Loading agents...</div>
+          ) : agentsError ? (
+            <div className="text-center text-xs py-4">
+              <div className="flex items-center justify-center gap-1 text-amber-600">
+                <AlertCircle className="w-3 h-3" />
+                <span>Unable to load agents</span>
+              </div>
+            </div>
           ) : agentSessions.length === 0 ? (
             <div className="text-center text-gray-500 text-xs py-4">No running agents</div>
           ) : (
diff --git a/apps/web/src/components/widgets/__tests__/ActiveProjectsWidget.test.tsx b/apps/web/src/components/widgets/__tests__/ActiveProjectsWidget.test.tsx
index 094e059..fd73087 100644
--- a/apps/web/src/components/widgets/__tests__/ActiveProjectsWidget.test.tsx
+++ b/apps/web/src/components/widgets/__tests__/ActiveProjectsWidget.test.tsx
@@ -317,4 +317,110 @@ describe("ActiveProjectsWidget", (): void => {
       expect(screen.getByText("(2)")).toBeInTheDocument(); // Project count badge
     });
   });
+
+  it("should display error state when projects API fails", async (): Promise<void> => {
+    vi.mocked(global.fetch).mockImplementation((url: RequestInfo | URL) => {
+      const urlString = typeof url === "string" ? url : url instanceof URL ? url.toString() : "";
+
+      // Return CSRF token
+      if (urlString.includes("csrf")) {
+        return Promise.resolve(mockCsrfResponse());
+      }
+      if (urlString.includes("active-projects")) {
+        return Promise.resolve({
+          ok: false,
+          status: 500,
+          statusText: "Internal Server Error",
+          json: () =>
+            Promise.resolve({ code: "SERVER_ERROR", message: "Failed to fetch projects" }),
+        } as Response);
+      }
+      // Agent chains succeeds
+      return Promise.resolve({
+        ok: true,
+        json: () => Promise.resolve([]),
+      } as Response);
+    });
+
+    render(<ActiveProjectsWidget id="active-projects-1" />);
+
+    await waitFor(() => {
+      expect(screen.getByText(/unable to load projects/i)).toBeInTheDocument();
+    });
+  });
+
+  it("should display error state when agent chains API fails", async (): Promise<void> => {
+    vi.mocked(global.fetch).mockImplementation((url: RequestInfo | URL) => {
+      const urlString = typeof url === "string" ? url : url instanceof URL ? url.toString() : "";
+
+      // Return CSRF token
+      if (urlString.includes("csrf")) {
+        return Promise.resolve(mockCsrfResponse());
+      }
+      if (urlString.includes("agent-chains")) {
+        return Promise.resolve({
+          ok: false,
+          status: 500,
+          statusText: "Internal Server Error",
+          json: () => Promise.resolve({ code: "SERVER_ERROR", message: "Failed to fetch agents" }),
+        } as Response);
+      }
+      // Active projects succeeds
+      return Promise.resolve({
+        ok: true,
+        json: () => Promise.resolve([]),
+      } as Response);
+    });
+
+    render(<ActiveProjectsWidget id="active-projects-1" />);
+
+    await waitFor(() => {
+      expect(screen.getByText(/unable to load agents/i)).toBeInTheDocument();
+    });
+  });
+
+  it("should display error state when both APIs fail", async (): Promise<void> => {
+    vi.mocked(global.fetch).mockImplementation((url: RequestInfo | URL) => {
+      const urlString = typeof url === "string" ? url : url instanceof URL ? url.toString() : "";
+
+      // Return CSRF token
+      if (urlString.includes("csrf")) {
+        return Promise.resolve(mockCsrfResponse());
+      }
+      // Both endpoints fail
+      return Promise.resolve({
+        ok: false,
+        status: 500,
+        statusText: "Internal Server Error",
+        json: () => Promise.resolve({ code: "SERVER_ERROR", message: "Server error" }),
+      } as Response);
+    });
+
+    render(<ActiveProjectsWidget id="active-projects-1" />);
+
+    await waitFor(() => {
+      expect(screen.getByText(/unable to load projects/i)).toBeInTheDocument();
+      expect(screen.getByText(/unable to load agents/i)).toBeInTheDocument();
+    });
+  });
+
+  it("should handle network errors gracefully", async (): Promise<void> => {
+    vi.mocked(global.fetch).mockImplementation((url: RequestInfo | URL) => {
+      const urlString = typeof url === "string" ? url : url instanceof URL ? url.toString() : "";
+
+      // Return CSRF token
+      if (urlString.includes("csrf")) {
+        return Promise.resolve(mockCsrfResponse());
+      }
+      // Network error
+      return Promise.reject(new Error("Network error"));
+    });
+
+    render(<ActiveProjectsWidget id="active-projects-1" />);
+
+    await waitFor(() => {
+      expect(screen.getByText(/unable to load projects/i)).toBeInTheDocument();
+      expect(screen.getByText(/unable to load agents/i)).toBeInTheDocument();
+    });
+  });
 });