fix: code review cleanup
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import { Injectable, Logger, OnModuleInit, OnModuleDestroy } from '@nestjs/common';
|
||||
import Redis from 'ioredis';
|
||||
import { TaskDto, TaskStatus, EnqueueTaskDto, UpdateTaskStatusDto, TaskMetadata } from './dto/task.dto';
|
||||
import { TaskDto, TaskStatus, EnqueueTaskDto, UpdateTaskStatusDto } from './dto/task.dto';
|
||||
import { randomUUID } from 'crypto';
|
||||
|
||||
/**
|
||||
@@ -15,7 +15,7 @@ import { randomUUID } from 'crypto';
|
||||
@Injectable()
|
||||
export class ValkeyService implements OnModuleInit, OnModuleDestroy {
|
||||
private readonly logger = new Logger(ValkeyService.name);
|
||||
private client: Redis;
|
||||
private client!: Redis;
|
||||
private readonly QUEUE_KEY = 'mosaic:task:queue';
|
||||
private readonly TASK_PREFIX = 'mosaic:task:';
|
||||
private readonly TASK_TTL = 86400; // 24 hours in seconds
|
||||
@@ -55,7 +55,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
|
||||
await this.client.ping();
|
||||
this.logger.log('Valkey health check passed');
|
||||
} catch (error) {
|
||||
this.logger.error('Valkey health check failed:', error.message);
|
||||
const errorMessage = error instanceof Error ? error.message : String(error);
|
||||
this.logger.error('Valkey health check failed:', errorMessage);
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -142,7 +143,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
|
||||
try {
|
||||
return JSON.parse(taskData) as TaskDto;
|
||||
} catch (error) {
|
||||
this.logger.error(`Failed to parse task data for ${taskId}:`, error.message);
|
||||
const errorMessage = error instanceof Error ? error.message : String(error);
|
||||
this.logger.error(`Failed to parse task data for ${taskId}:`, errorMessage);
|
||||
return null;
|
||||
}
|
||||
}
|
||||
@@ -222,7 +224,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
|
||||
const result = await this.client.ping();
|
||||
return result === 'PONG';
|
||||
} catch (error) {
|
||||
this.logger.error('Valkey health check failed:', error.message);
|
||||
const errorMessage = error instanceof Error ? error.message : String(error);
|
||||
this.logger.error('Valkey health check failed:', errorMessage);
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user