mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 2 Wiki Activity

fix: code review cleanup

Browse Source
This commit is contained in:
Jason Woltje
2026-01-29 23:33:43 -06:00
parent c413e5ddd0
commit 3ddafb898a
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/api/src/valkey/valkey.service.ts
View File

@@ -1,6 +1,6 @@
import { Injectable, Logger, OnModuleInit, OnModuleDestroy } from '@nestjs/common'; import { Injectable, Logger, OnModuleInit, OnModuleDestroy } from '@nestjs/common';
import Redis from 'ioredis'; import Redis from 'ioredis';
import { TaskDto, TaskStatus, EnqueueTaskDto, UpdateTaskStatusDto, TaskMetadata } from './dto/task.dto'; import { TaskDto, TaskStatus, EnqueueTaskDto, UpdateTaskStatusDto } from './dto/task.dto';
import { randomUUID } from 'crypto'; import { randomUUID } from 'crypto';
/** /**
@@ -15,7 +15,7 @@ import { randomUUID } from 'crypto';
@Injectable() @Injectable()
export class ValkeyService implements OnModuleInit, OnModuleDestroy { export class ValkeyService implements OnModuleInit, OnModuleDestroy {
private readonly logger = new Logger(ValkeyService.name); private readonly logger = new Logger(ValkeyService.name);
private client: Redis; private client!: Redis;
private readonly QUEUE_KEY = 'mosaic:task:queue'; private readonly QUEUE_KEY = 'mosaic:task:queue';
private readonly TASK_PREFIX = 'mosaic:task:'; private readonly TASK_PREFIX = 'mosaic:task:';
private readonly TASK_TTL = 86400; // 24 hours in seconds private readonly TASK_TTL = 86400; // 24 hours in seconds
@@ -55,7 +55,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
await this.client.ping(); await this.client.ping();
this.logger.log('Valkey health check passed'); this.logger.log('Valkey health check passed');
} catch (error) { } catch (error) {
this.logger.error('Valkey health check failed:', error.message); const errorMessage = error instanceof Error ? error.message : String(error);
this.logger.error('Valkey health check failed:', errorMessage);
throw error; throw error;
} }
} }
@@ -142,7 +143,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
try { try {
return JSON.parse(taskData) as TaskDto; return JSON.parse(taskData) as TaskDto;
} catch (error) { } catch (error) {
this.logger.error(`Failed to parse task data for ${taskId}:`, error.message); const errorMessage = error instanceof Error ? error.message : String(error);
this.logger.error(`Failed to parse task data for ${taskId}:`, errorMessage);
return null; return null;
} }
} }
@@ -222,7 +224,8 @@ export class ValkeyService implements OnModuleInit, OnModuleDestroy {
const result = await this.client.ping(); const result = await this.client.ping();
return result === 'PONG'; return result === 'PONG';
} catch (error) { } catch (error) {
this.logger.error('Valkey health check failed:', error.message); const errorMessage = error instanceof Error ? error.message : String(error);
this.logger.error('Valkey health check failed:', errorMessage);
return false; return false;
} }
} }