From 5a0f090cc54d251fd4dc28fb3c07eac315a83c2f Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Thu, 5 Feb 2026 13:24:54 -0600 Subject: [PATCH] fix(#230): Correct documentation errors from code review - Fix CRITICAL: Correct 5 environment variable names to match actual config (VALKEY_HOST not ORCHESTRATOR_VALKEY_HOST, CLAUDE_API_KEY not ORCHESTRATOR_CLAUDE_API_KEY, etc.) - Fix CRITICAL: Correct quality gate profiles table to match actual gate-config service (minimal = tests only, not typecheck+lint; add agent type defaults) - Fix IMPORTANT: Add missing gateProfile optional field to spawn request docs Co-Authored-By: Claude Opus 4.5 --- apps/orchestrator/README.md | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/apps/orchestrator/README.md b/apps/orchestrator/README.md index 74d7834..3621f7d 100644 --- a/apps/orchestrator/README.md +++ b/apps/orchestrator/README.md @@ -58,6 +58,7 @@ Monitored via `apps/web/` (Agent Dashboard). { "taskId": "string (required)", "agentType": "worker | reviewer | tester", + "gateProfile": "strict | standard | minimal | custom (optional)", "context": { "repository": "https://git.example.com/repo.git", "branch": "main", @@ -134,11 +135,11 @@ orchestrator:events → Pub/sub channel for lifecycle events ## Quality Gate Profiles -| Profile | Pre-commit | Post-commit | -| -------- | ---------------------- | --------------------------------------------- | -| strict | typecheck, lint, tests | coverage (85%), build, integration, AI review | -| standard | typecheck, lint, tests | coverage (85%), build | -| minimal | typecheck, lint | build | +| Profile | Default For | Gates | +| -------- | ----------- | --------------------------------------------------------------------- | +| strict | reviewer | typecheck, lint, tests, coverage (85%), build, integration, AI review | +| standard | worker | typecheck, lint, tests, coverage (85%) | +| minimal | tester | tests only | ## Development @@ -175,14 +176,14 @@ pnpm --filter @mosaic/orchestrator lint Environment variables loaded via `@nestjs/config`. Key variables: -| Variable | Description | -| ------------------------------ | ---------------------------- | -| `ORCHESTRATOR_PORT` | HTTP port (default: 3001) | -| `ORCHESTRATOR_CLAUDE_API_KEY` | Claude API key for agents | -| `ORCHESTRATOR_VALKEY_HOST` | Valkey/Redis host | -| `ORCHESTRATOR_VALKEY_PORT` | Valkey/Redis port | -| `ORCHESTRATOR_COORDINATOR_URL` | Quality Coordinator base URL | -| `ORCHESTRATOR_DOCKER_ENABLED` | Enable Docker sandbox | +| Variable | Description | +| ------------------- | -------------------------------------- | +| `ORCHESTRATOR_PORT` | HTTP port (default: 3001) | +| `CLAUDE_API_KEY` | Claude API key for agents | +| `VALKEY_HOST` | Valkey/Redis host (default: localhost) | +| `VALKEY_PORT` | Valkey/Redis port (default: 6379) | +| `COORDINATOR_URL` | Quality Coordinator base URL | +| `SANDBOX_ENABLED` | Enable Docker sandbox (true/false) | ## Related Documentation