feat(#71): implement graph data API
Implemented three new API endpoints for knowledge graph visualization: 1. GET /api/knowledge/graph - Full knowledge graph - Returns all entries and links with optional filtering - Supports filtering by tags, status, and node count limit - Includes orphan detection (entries with no links) 2. GET /api/knowledge/graph/stats - Graph statistics - Total entries and links counts - Orphan entries detection - Average links per entry - Top 10 most connected entries - Tag distribution across entries 3. GET /api/knowledge/graph/:slug - Entry-centered subgraph - Returns graph centered on specific entry - Supports depth parameter (1-5) for traversal distance - Includes all connected nodes up to specified depth New Files: - apps/api/src/knowledge/graph.controller.ts - apps/api/src/knowledge/graph.controller.spec.ts Modified Files: - apps/api/src/knowledge/dto/graph-query.dto.ts (added GraphFilterDto) - apps/api/src/knowledge/entities/graph.entity.ts (extended with new types) - apps/api/src/knowledge/services/graph.service.ts (added new methods) - apps/api/src/knowledge/services/graph.service.spec.ts (added tests) - apps/api/src/knowledge/knowledge.module.ts (registered controller) - apps/api/src/knowledge/dto/index.ts (exported new DTOs) - docs/scratchpads/71-graph-data-api.md (implementation notes) Test Coverage: 21 tests (all passing) - 14 service tests including orphan detection, filtering, statistics - 7 controller tests for all three endpoints Follows TDD principles with tests written before implementation. All code quality gates passed (lint, typecheck, tests). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Jason Woltje
341
apps/orchestrator/src/spawner/docker-sandbox.service.spec.ts
Normal file
341
apps/orchestrator/src/spawner/docker-sandbox.service.spec.ts
Normal file
@@ -0,0 +1,341 @@
|
||||
import { ConfigService } from "@nestjs/config";
|
||||
import { describe, it, expect, beforeEach, vi } from "vitest";
|
||||
import { DockerSandboxService } from "./docker-sandbox.service";
|
||||
import Docker from "dockerode";
|
||||
|
||||
describe("DockerSandboxService", () => {
|
||||
let service: DockerSandboxService;
|
||||
let mockConfigService: ConfigService;
|
||||
let mockDocker: Docker;
|
||||
let mockContainer: Docker.Container;
|
||||
|
||||
beforeEach(() => {
|
||||
// Create mock Docker container
|
||||
mockContainer = {
|
||||
id: "container-123",
|
||||
start: vi.fn().mockResolvedValue(undefined),
|
||||
stop: vi.fn().mockResolvedValue(undefined),
|
||||
remove: vi.fn().mockResolvedValue(undefined),
|
||||
inspect: vi.fn().mockResolvedValue({
|
||||
State: { Status: "running" },
|
||||
}),
|
||||
} as unknown as Docker.Container;
|
||||
|
||||
// Create mock Docker instance
|
||||
mockDocker = {
|
||||
createContainer: vi.fn().mockResolvedValue(mockContainer),
|
||||
getContainer: vi.fn().mockReturnValue(mockContainer),
|
||||
} as unknown as Docker;
|
||||
|
||||
// Create mock ConfigService
|
||||
mockConfigService = {
|
||||
get: vi.fn((key: string, defaultValue?: unknown) => {
|
||||
const config: Record<string, unknown> = {
|
||||
"orchestrator.docker.socketPath": "/var/run/docker.sock",
|
||||
"orchestrator.sandbox.enabled": true,
|
||||
"orchestrator.sandbox.defaultImage": "node:20-alpine",
|
||||
"orchestrator.sandbox.defaultMemoryMB": 512,
|
||||
"orchestrator.sandbox.defaultCpuLimit": 1.0,
|
||||
"orchestrator.sandbox.networkMode": "bridge",
|
||||
};
|
||||
return config[key] !== undefined ? config[key] : defaultValue;
|
||||
}),
|
||||
} as unknown as ConfigService;
|
||||
|
||||
// Create service with mock Docker instance
|
||||
service = new DockerSandboxService(mockConfigService, mockDocker);
|
||||
});
|
||||
|
||||
describe("constructor", () => {
|
||||
it("should be defined", () => {
|
||||
expect(service).toBeDefined();
|
||||
});
|
||||
|
||||
it("should use provided Docker instance", () => {
|
||||
expect(service).toBeDefined();
|
||||
// Service should use the mockDocker instance we provided
|
||||
});
|
||||
});
|
||||
|
||||
describe("createContainer", () => {
|
||||
it("should create a container with default configuration", async () => {
|
||||
const agentId = "agent-123";
|
||||
const taskId = "task-456";
|
||||
const workspacePath = "/workspace/agent-123";
|
||||
|
||||
const result = await service.createContainer(
|
||||
agentId,
|
||||
taskId,
|
||||
workspacePath
|
||||
);
|
||||
|
||||
expect(result.containerId).toBe("container-123");
|
||||
expect(result.agentId).toBe(agentId);
|
||||
expect(result.taskId).toBe(taskId);
|
||||
expect(result.createdAt).toBeInstanceOf(Date);
|
||||
expect(mockDocker.createContainer).toHaveBeenCalledWith({
|
||||
Image: "node:20-alpine",
|
||||
name: expect.stringContaining(`mosaic-agent-${agentId}`),
|
||||
User: "node:node",
|
||||
HostConfig: {
|
||||
Memory: 512 * 1024 * 1024, // 512MB in bytes
|
||||
NanoCpus: 1000000000, // 1.0 CPU
|
||||
NetworkMode: "bridge",
|
||||
Binds: [`${workspacePath}:/workspace`],
|
||||
AutoRemove: false,
|
||||
ReadonlyRootfs: false,
|
||||
},
|
||||
WorkingDir: "/workspace",
|
||||
Env: [`AGENT_ID=${agentId}`, `TASK_ID=${taskId}`],
|
||||
});
|
||||
});
|
||||
|
||||
it("should create a container with custom resource limits", async () => {
|
||||
const agentId = "agent-123";
|
||||
const taskId = "task-456";
|
||||
const workspacePath = "/workspace/agent-123";
|
||||
const options = {
|
||||
memoryMB: 1024,
|
||||
cpuLimit: 2.0,
|
||||
};
|
||||
|
||||
await service.createContainer(agentId, taskId, workspacePath, options);
|
||||
|
||||
expect(mockDocker.createContainer).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
HostConfig: expect.objectContaining({
|
||||
Memory: 1024 * 1024 * 1024, // 1024MB in bytes
|
||||
NanoCpus: 2000000000, // 2.0 CPU
|
||||
}),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
it("should create a container with network isolation", async () => {
|
||||
const agentId = "agent-123";
|
||||
const taskId = "task-456";
|
||||
const workspacePath = "/workspace/agent-123";
|
||||
const options = {
|
||||
networkMode: "none" as const,
|
||||
};
|
||||
|
||||
await service.createContainer(agentId, taskId, workspacePath, options);
|
||||
|
||||
expect(mockDocker.createContainer).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
HostConfig: expect.objectContaining({
|
||||
NetworkMode: "none",
|
||||
}),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
it("should create a container with custom environment variables", async () => {
|
||||
const agentId = "agent-123";
|
||||
const taskId = "task-456";
|
||||
const workspacePath = "/workspace/agent-123";
|
||||
const options = {
|
||||
env: {
|
||||
CUSTOM_VAR: "value123",
|
||||
ANOTHER_VAR: "value456",
|
||||
},
|
||||
};
|
||||
|
||||
await service.createContainer(agentId, taskId, workspacePath, options);
|
||||
|
||||
expect(mockDocker.createContainer).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
Env: expect.arrayContaining([
|
||||
`AGENT_ID=${agentId}`,
|
||||
`TASK_ID=${taskId}`,
|
||||
"CUSTOM_VAR=value123",
|
||||
"ANOTHER_VAR=value456",
|
||||
]),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
it("should throw error if container creation fails", async () => {
|
||||
const agentId = "agent-123";
|
||||
const taskId = "task-456";
|
||||
const workspacePath = "/workspace/agent-123";
|
||||
|
||||
(mockDocker.createContainer as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Docker daemon not available")
|
||||
);
|
||||
|
||||
await expect(
|
||||
service.createContainer(agentId, taskId, workspacePath)
|
||||
).rejects.toThrow("Failed to create container for agent agent-123");
|
||||
});
|
||||
});
|
||||
|
||||
describe("startContainer", () => {
|
||||
it("should start a container by ID", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
await service.startContainer(containerId);
|
||||
|
||||
expect(mockDocker.getContainer).toHaveBeenCalledWith(containerId);
|
||||
expect(mockContainer.start).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("should throw error if container start fails", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.start as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container not found")
|
||||
);
|
||||
|
||||
await expect(service.startContainer(containerId)).rejects.toThrow(
|
||||
"Failed to start container container-123"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("stopContainer", () => {
|
||||
it("should stop a container by ID", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
await service.stopContainer(containerId);
|
||||
|
||||
expect(mockDocker.getContainer).toHaveBeenCalledWith(containerId);
|
||||
expect(mockContainer.stop).toHaveBeenCalledWith({ t: 10 });
|
||||
});
|
||||
|
||||
it("should stop a container with custom timeout", async () => {
|
||||
const containerId = "container-123";
|
||||
const timeout = 30;
|
||||
|
||||
await service.stopContainer(containerId, timeout);
|
||||
|
||||
expect(mockContainer.stop).toHaveBeenCalledWith({ t: timeout });
|
||||
});
|
||||
|
||||
it("should throw error if container stop fails", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.stop as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container already stopped")
|
||||
);
|
||||
|
||||
await expect(service.stopContainer(containerId)).rejects.toThrow(
|
||||
"Failed to stop container container-123"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("removeContainer", () => {
|
||||
it("should remove a container by ID", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
await service.removeContainer(containerId);
|
||||
|
||||
expect(mockDocker.getContainer).toHaveBeenCalledWith(containerId);
|
||||
expect(mockContainer.remove).toHaveBeenCalledWith({ force: true });
|
||||
});
|
||||
|
||||
it("should throw error if container removal fails", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.remove as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container not found")
|
||||
);
|
||||
|
||||
await expect(service.removeContainer(containerId)).rejects.toThrow(
|
||||
"Failed to remove container container-123"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("getContainerStatus", () => {
|
||||
it("should return container status", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
const status = await service.getContainerStatus(containerId);
|
||||
|
||||
expect(status).toBe("running");
|
||||
expect(mockDocker.getContainer).toHaveBeenCalledWith(containerId);
|
||||
expect(mockContainer.inspect).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("should throw error if container inspect fails", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.inspect as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container not found")
|
||||
);
|
||||
|
||||
await expect(service.getContainerStatus(containerId)).rejects.toThrow(
|
||||
"Failed to get container status for container-123"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("cleanup", () => {
|
||||
it("should stop and remove container", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
await service.cleanup(containerId);
|
||||
|
||||
expect(mockContainer.stop).toHaveBeenCalledWith({ t: 10 });
|
||||
expect(mockContainer.remove).toHaveBeenCalledWith({ force: true });
|
||||
});
|
||||
|
||||
it("should remove container even if stop fails", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.stop as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container already stopped")
|
||||
);
|
||||
|
||||
await service.cleanup(containerId);
|
||||
|
||||
expect(mockContainer.remove).toHaveBeenCalledWith({ force: true });
|
||||
});
|
||||
|
||||
it("should throw error if both stop and remove fail", async () => {
|
||||
const containerId = "container-123";
|
||||
|
||||
(mockContainer.stop as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container not found")
|
||||
);
|
||||
(mockContainer.remove as ReturnType<typeof vi.fn>).mockRejectedValue(
|
||||
new Error("Container not found")
|
||||
);
|
||||
|
||||
await expect(service.cleanup(containerId)).rejects.toThrow(
|
||||
"Failed to cleanup container container-123"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("isEnabled", () => {
|
||||
it("should return true if sandbox is enabled in config", () => {
|
||||
expect(service.isEnabled()).toBe(true);
|
||||
});
|
||||
|
||||
it("should return false if sandbox is disabled in config", () => {
|
||||
const disabledConfigService = {
|
||||
get: vi.fn((key: string, defaultValue?: unknown) => {
|
||||
const config: Record<string, unknown> = {
|
||||
"orchestrator.docker.socketPath": "/var/run/docker.sock",
|
||||
"orchestrator.sandbox.enabled": false,
|
||||
"orchestrator.sandbox.defaultImage": "node:20-alpine",
|
||||
"orchestrator.sandbox.defaultMemoryMB": 512,
|
||||
"orchestrator.sandbox.defaultCpuLimit": 1.0,
|
||||
"orchestrator.sandbox.networkMode": "bridge",
|
||||
};
|
||||
return config[key] !== undefined ? config[key] : defaultValue;
|
||||
}),
|
||||
} as unknown as ConfigService;
|
||||
|
||||
const disabledService = new DockerSandboxService(
|
||||
disabledConfigService,
|
||||
mockDocker
|
||||
);
|
||||
|
||||
expect(disabledService.isEnabled()).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user