fix: code review cleanup - schema sync, type safety, null handling

- Sync KnowledgeLink schema with migration (add displayText, positionStart, positionEnd, resolved)
- Make targetId optional to support unresolved links
- Fix null handling in graph.service.ts (skip unresolved links)
- Add explicit types to frontend components (remove implicit any)
- Remove unused WikiLink import
- Add null-safe statusInfo check in EntryCard

apps/api/prisma/schema.prisma

@@ -750,18 +750,22 @@ model KnowledgeLink {
   sourceId String         @map("source_id") @db.Uuid
   source   KnowledgeEntry @relation("SourceEntry", fields: [sourceId], references: [id], onDelete: Cascade)
 
-  targetId String         @map("target_id") @db.Uuid
-  target   KnowledgeEntry @relation("TargetEntry", fields: [targetId], references: [id], onDelete: Cascade)
+  targetId String?        @map("target_id") @db.Uuid
+  target   KnowledgeEntry? @relation("TargetEntry", fields: [targetId], references: [id], onDelete: Cascade)
 
   // Link metadata
-  linkText String  @map("link_text")
-  context  String?
+  linkText      String  @map("link_text")
+  displayText   String  @map("display_text")
+  positionStart Int     @map("position_start")
+  positionEnd   Int     @map("position_end")
+  resolved      Boolean @default(false)
+  context       String?
 
   createdAt DateTime @default(now()) @map("created_at") @db.Timestamptz
 
-  @@unique([sourceId, targetId])
   @@index([sourceId])
   @@index([targetId])
+  @@index([sourceId, resolved])
   @@map("knowledge_links")
 }
 

apps/api/src/knowledge/services/graph.service.ts

@@ -104,8 +104,11 @@ export class GraphService {
 
       // Continue BFS if not at max depth
       if (depth < maxDepth) {
-        // Process outgoing links
+        // Process outgoing links (only resolved ones)
         for (const link of currentEntry.outgoingLinks) {
+          // Skip unresolved links
+          if (!link.targetId || !link.resolved) continue;
+
           // Add edge
           edges.push({
             id: link.id,
@@ -122,8 +125,11 @@ export class GraphService {
           }
         }
 
-        // Process incoming links
+        // Process incoming links (only resolved ones)
         for (const link of currentEntry.incomingLinks) {
+          // Skip unresolved links
+          if (!link.targetId || !link.resolved) continue;
+
           // Add edge
           const edgeExists = edges.some(
             (e) => e.sourceId === link.sourceId && e.targetId === link.targetId

apps/api/src/knowledge/services/link-resolution.service.ts

@@ -131,7 +131,9 @@ export class LinkResolutionService {
       return null;
     }
 
-    return fuzzyMatches[0].id;
+    // Return the single match
+    const match = fuzzyMatches[0];
+    return match ? match.id : null;
   }
 
   /**

apps/api/src/knowledge/services/link-sync.service.ts

@@ -1,7 +1,7 @@
 import { Injectable } from "@nestjs/common";
 import { PrismaService } from "../../prisma/prisma.service";
 import { LinkResolutionService } from "./link-resolution.service";
-import { parseWikiLinks, WikiLink } from "../utils/wiki-link-parser";
+import { parseWikiLinks } from "../utils/wiki-link-parser";
 
 /**
  * Represents a backlink to a knowledge entry