From 69bdfa5df16b15e5f17f7ed0c0e4aaebe31c4833 Mon Sep 17 00:00:00 2001
From: Jason Woltje <jason.woltje@uscllc.com>
Date: Thu, 29 Jan 2026 23:36:01 -0600
Subject: [PATCH] fix: code review cleanup

- Fixed TypeScript exactOptionalPropertyTypes errors in chat components
- Removed console.error statements (errors are handled via state)
- Fixed type compatibility issues with undefined vs null values
- All chat-related files now pass strict TypeScript checks
---
 apps/web/src/components/chat/Chat.tsx                |  6 +++---
 apps/web/src/components/chat/ConversationSidebar.tsx |  8 ++++----
 apps/web/src/hooks/useChat.ts                        | 10 +++++-----
 apps/web/src/lib/api/ideas.ts                        |  7 +++++--
 4 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/apps/web/src/components/chat/Chat.tsx b/apps/web/src/components/chat/Chat.tsx
index 3ccc5f1..64abf8e 100644
--- a/apps/web/src/components/chat/Chat.tsx
+++ b/apps/web/src/components/chat/Chat.tsx
@@ -66,9 +66,9 @@ export const Chat = forwardRef<ChatRef, ChatProps>(function Chat({
     clearError,
   } = useChat({
     model: "llama3.2",
-    projectId: initialProjectId,
-    onError: (err) => {
-      console.error("Chat error:", err);
+    ...(initialProjectId !== undefined && { projectId: initialProjectId }),
+    onError: (_err) => {
+      // Error is handled by the useChat hook's state
     },
   });
 
diff --git a/apps/web/src/components/chat/ConversationSidebar.tsx b/apps/web/src/components/chat/ConversationSidebar.tsx
index fe1db0d..3133b19 100644
--- a/apps/web/src/components/chat/ConversationSidebar.tsx
+++ b/apps/web/src/components/chat/ConversationSidebar.tsx
@@ -54,9 +54,9 @@ export const ConversationSidebar = forwardRef<ConversationSidebarRef, Conversati
 
     return {
       id: idea.id,
-      title: idea.title,
-      projectId: idea.projectId,
-      updatedAt: idea.updatedAt,
+      title: idea.title ?? null,
+      projectId: idea.projectId ?? null,
+      updatedAt: idea.updatedAt ?? null,
       messageCount,
     };
   }, []);
@@ -84,7 +84,7 @@ export const ConversationSidebar = forwardRef<ConversationSidebarRef, Conversati
     } catch (err) {
       const errorMsg = err instanceof Error ? err.message : "Failed to load conversations";
       setError(errorMsg);
-      console.error("Error fetching conversations:", err);
+      // Error is set to state and will be displayed to the user
     } finally {
       setIsLoading(false);
     }
diff --git a/apps/web/src/hooks/useChat.ts b/apps/web/src/hooks/useChat.ts
index af62974..4bf40d4 100644
--- a/apps/web/src/hooks/useChat.ts
+++ b/apps/web/src/hooks/useChat.ts
@@ -173,9 +173,9 @@ export function useChat(options: UseChatOptions = {}): UseChatReturn {
         const request = {
           model,
           messages: apiMessages,
-          temperature,
-          maxTokens,
-          systemPrompt,
+          ...(temperature !== undefined && { temperature }),
+          ...(maxTokens !== undefined && { maxTokens }),
+          ...(systemPrompt !== undefined && { systemPrompt }),
         };
 
         // Call LLM API
@@ -188,8 +188,8 @@ export function useChat(options: UseChatOptions = {}): UseChatReturn {
           content: response.message.content,
           createdAt: new Date().toISOString(),
           model: response.model,
-          promptTokens: response.promptEvalCount,
-          completionTokens: response.evalCount,
+          promptTokens: response.promptEvalCount ?? 0,
+          completionTokens: response.evalCount ?? 0,
           totalTokens: (response.promptEvalCount ?? 0) + (response.evalCount ?? 0),
         };
 
diff --git a/apps/web/src/lib/api/ideas.ts b/apps/web/src/lib/api/ideas.ts
index 0526103..2b9f05a 100644
--- a/apps/web/src/lib/api/ideas.ts
+++ b/apps/web/src/lib/api/ideas.ts
@@ -141,7 +141,7 @@ export async function createConversation(
   return createIdea({
     title,
     content,
-    projectId,
+    ...(projectId !== undefined && { projectId }),
     category: "conversation",
     tags: ["chat"],
     metadata: { conversationType: "chat" },
@@ -156,5 +156,8 @@ export async function updateConversation(
   content: string,
   title?: string
 ): Promise<Idea> {
-  return updateIdea(id, { content, title });
+  return updateIdea(id, { 
+    content, 
+    ...(title !== undefined && { title })
+  });
 }