From a00f1e1fd71124f66515cf4e1dc20c967935fb3f Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Sun, 1 Mar 2026 23:15:16 +0000 Subject: [PATCH] fix(api): activity interceptor tests (#647) Co-authored-by: Jason Woltje Co-committed-by: Jason Woltje --- .../activity-logging.interceptor.spec.ts | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/apps/api/src/activity/interceptors/activity-logging.interceptor.spec.ts b/apps/api/src/activity/interceptors/activity-logging.interceptor.spec.ts index 6c115ee..f2fdb0b 100644 --- a/apps/api/src/activity/interceptors/activity-logging.interceptor.spec.ts +++ b/apps/api/src/activity/interceptors/activity-logging.interceptor.spec.ts @@ -384,10 +384,18 @@ describe("ActivityLoggingInterceptor", () => { const context = createMockExecutionContext("POST", {}, body, user); const next = createMockCallHandler(result); + mockActivityService.logActivity.mockResolvedValue({ + id: "activity-123", + }); + await new Promise((resolve) => { interceptor.intercept(context, next).subscribe(() => { - // Should not call logActivity when workspaceId is missing - expect(mockActivityService.logActivity).not.toHaveBeenCalled(); + // workspaceId is now optional, so logActivity should be called without it + expect(mockActivityService.logActivity).toHaveBeenCalled(); + const callArgs = mockActivityService.logActivity.mock.calls[0][0]; + expect(callArgs.userId).toBe("user-123"); + expect(callArgs.entityId).toBe("task-123"); + expect(callArgs.workspaceId).toBeUndefined(); resolve(); }); }); @@ -412,10 +420,18 @@ describe("ActivityLoggingInterceptor", () => { const context = createMockExecutionContext("POST", {}, body, user); const next = createMockCallHandler(result); + mockActivityService.logActivity.mockResolvedValue({ + id: "activity-123", + }); + await new Promise((resolve) => { interceptor.intercept(context, next).subscribe(() => { - // Should not call logActivity when workspaceId is missing - expect(mockActivityService.logActivity).not.toHaveBeenCalled(); + // workspaceId is now optional, so logActivity should be called without it + expect(mockActivityService.logActivity).toHaveBeenCalled(); + const callArgs = mockActivityService.logActivity.mock.calls[0][0]; + expect(callArgs.userId).toBe("user-123"); + expect(callArgs.entityId).toBe("task-123"); + expect(callArgs.workspaceId).toBeUndefined(); resolve(); }); });