mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 2 Wiki Activity

fix: Resolve CI typecheck failures and improve type safety
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details

Browse Source 
Fixes CI pipeline failures caused by missing Prisma Client generation and TypeScript type safety issues. Added Prisma generation step to CI pipeline, installed missing type dependencies, and resolved 40+ exactOptionalPropertyTypes violations across service layer.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Jason Woltje
2026-01-30 20:39:03 -06:00
parent 82b36e1d66
commit c221b63d14
19 changed files with 256 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
apps/api/src/projects/projects.service.ts
View File

@@ -21,10 +21,10 @@ export class ProjectsService {
async create(workspaceId: string, userId: string, createProjectDto: CreateProjectDto) {
const data: Prisma.ProjectCreateInput = {
name: createProjectDto.name,
description: createProjectDto.description,
color: createProjectDto.color,
startDate: createProjectDto.startDate,
endDate: createProjectDto.endDate,
description: createProjectDto.description ?? null,
color: createProjectDto.color ?? null,
startDate: createProjectDto.startDate ?? null,
endDate: createProjectDto.endDate ?? null,
workspace: { connect: { id: workspaceId } },
creator: { connect: { id: userId } },
status: createProjectDto.status ?? ProjectStatus.PLANNING,
@@ -62,9 +62,11 @@ export class ProjectsService {
const skip = (page - 1) * limit;
// Build where clause
const where: Prisma.ProjectWhereInput = {
workspaceId: query.workspaceId,
};
const where: Prisma.ProjectWhereInput = query.workspaceId
? {
workspaceId: query.workspaceId,
}
: {};
if (query.status) {
where.status = query.status;
@@ -175,12 +177,25 @@ export class ProjectsService {
throw new NotFoundException(`Project with ID ${id} not found`);
}
// Build update data, only including defined fields
const updateData: Prisma.ProjectUpdateInput = {};
if (updateProjectDto.name !== undefined) updateData.name = updateProjectDto.name;
if (updateProjectDto.description !== undefined)
updateData.description = updateProjectDto.description;
if (updateProjectDto.status !== undefined) updateData.status = updateProjectDto.status;
if (updateProjectDto.startDate !== undefined) updateData.startDate = updateProjectDto.startDate;
if (updateProjectDto.endDate !== undefined) updateData.endDate = updateProjectDto.endDate;
if (updateProjectDto.color !== undefined) updateData.color = updateProjectDto.color;
if (updateProjectDto.metadata !== undefined) {
updateData.metadata = updateProjectDto.metadata as unknown as Prisma.InputJsonValue;
}
const project = await this.prisma.project.update({
where: {
id,
workspaceId,
},
data: updateProjectDto,
data: updateData,
include: {
creator: {
select: { id: true, name: true, email: true },