From c6699908e4c4123f4a8e4e0fc469f3aa8ce32470 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Sat, 31 Jan 2026 12:16:57 -0600 Subject: [PATCH] chore: upgrade ESLint warnings to errors for stricter quality-rails Upgraded three TypeScript rules from "warn" to "error": - explicit-function-return-type: Functions must declare return types - prefer-nullish-coalescing: Enforce ?? over || for null checks - prefer-optional-chain: Enforce ?. over && chains This tightens pre-commit enforcement to catch more issues mechanically before code review, reducing agent iteration cycles. Co-Authored-By: Claude Sonnet 4.5 --- packages/config/eslint/base.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/config/eslint/base.js b/packages/config/eslint/base.js index ed9b32e..a7241a0 100644 --- a/packages/config/eslint/base.js +++ b/packages/config/eslint/base.js @@ -21,7 +21,7 @@ export default tseslint.config( // Type Safety - STRICT (Quality Rails) "@typescript-eslint/no-explicit-any": "error", - "@typescript-eslint/explicit-function-return-type": "warn", + "@typescript-eslint/explicit-function-return-type": "error", "@typescript-eslint/explicit-module-boundary-types": "error", "@typescript-eslint/no-unused-vars": [ "error", @@ -36,8 +36,8 @@ export default tseslint.config( // Code Quality (Quality Rails) "@typescript-eslint/no-var-requires": "error", - "@typescript-eslint/prefer-nullish-coalescing": "warn", - "@typescript-eslint/prefer-optional-chain": "warn", + "@typescript-eslint/prefer-nullish-coalescing": "error", + "@typescript-eslint/prefer-optional-chain": "error", // Security (Quality Rails) "security/detect-object-injection": "off", // Too many false positives