fix: Logs page — activity_logs, optional workspaceId, autoRefresh on (#637)
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Co-authored-by: Jason Woltje <jason@diversecanvas.com> Co-committed-by: Jason Woltje <jason@diversecanvas.com>
This commit was merged in pull request #637.
This commit is contained in:
@@ -117,12 +117,13 @@ export class ActivityService {
|
||||
/**
|
||||
* Get a single activity log by ID
|
||||
*/
|
||||
async findOne(id: string, workspaceId: string): Promise<ActivityLogResult | null> {
|
||||
async findOne(id: string, workspaceId?: string): Promise<ActivityLogResult | null> {
|
||||
const where: Prisma.ActivityLogWhereUniqueInput = { id };
|
||||
if (workspaceId) {
|
||||
where.workspaceId = workspaceId;
|
||||
}
|
||||
return await this.prisma.activityLog.findUnique({
|
||||
where: {
|
||||
id,
|
||||
workspaceId,
|
||||
},
|
||||
where,
|
||||
include: {
|
||||
user: {
|
||||
select: {
|
||||
|
||||
@@ -4,6 +4,7 @@ import { tap } from "rxjs/operators";
|
||||
import { ActivityService } from "../activity.service";
|
||||
import { ActivityAction, EntityType } from "@prisma/client";
|
||||
import type { Prisma } from "@prisma/client";
|
||||
import type { CreateActivityLogInput } from "../interfaces/activity.interface";
|
||||
import type { AuthenticatedRequest } from "../../common/types/user.types";
|
||||
|
||||
/**
|
||||
@@ -61,10 +62,13 @@ export class ActivityLoggingInterceptor implements NestInterceptor {
|
||||
// Extract entity information
|
||||
const resultObj = result as Record<string, unknown> | undefined;
|
||||
const entityId = params.id ?? (resultObj?.id as string | undefined);
|
||||
|
||||
// workspaceId is now optional - log events even when missing
|
||||
const workspaceId = user.workspaceId ?? (body.workspaceId as string | undefined);
|
||||
|
||||
if (!entityId || !workspaceId) {
|
||||
this.logger.warn("Cannot log activity: missing entityId or workspaceId");
|
||||
// Log with warning if entityId is missing, but still proceed with logging if workspaceId exists
|
||||
if (!entityId) {
|
||||
this.logger.warn("Cannot log activity: missing entityId");
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -92,9 +96,8 @@ export class ActivityLoggingInterceptor implements NestInterceptor {
|
||||
const userAgent =
|
||||
typeof userAgentHeader === "string" ? userAgentHeader : userAgentHeader?.[0];
|
||||
|
||||
// Log the activity
|
||||
await this.activityService.logActivity({
|
||||
workspaceId,
|
||||
// Log the activity — workspaceId is optional
|
||||
const activityInput: CreateActivityLogInput = {
|
||||
userId: user.id,
|
||||
action,
|
||||
entityType,
|
||||
@@ -102,7 +105,11 @@ export class ActivityLoggingInterceptor implements NestInterceptor {
|
||||
details,
|
||||
ipAddress: ip ?? undefined,
|
||||
userAgent: userAgent ?? undefined,
|
||||
});
|
||||
};
|
||||
if (workspaceId) {
|
||||
activityInput.workspaceId = workspaceId;
|
||||
}
|
||||
await this.activityService.logActivity(activityInput);
|
||||
} catch (error) {
|
||||
// Don't fail the request if activity logging fails
|
||||
this.logger.error(
|
||||
|
||||
@@ -2,9 +2,10 @@ import type { ActivityAction, EntityType, Prisma } from "@prisma/client";
|
||||
|
||||
/**
|
||||
* Interface for creating a new activity log entry
|
||||
* workspaceId is optional - allows logging events without workspace context
|
||||
*/
|
||||
export interface CreateActivityLogInput {
|
||||
workspaceId: string;
|
||||
workspaceId?: string | null;
|
||||
userId: string;
|
||||
action: ActivityAction;
|
||||
entityType: EntityType;
|
||||
|
||||
Reference in New Issue
Block a user