Compare commits
1 Commits
fix/orches
...
fix/fleet-
| Author | SHA1 | Date | |
|---|---|---|---|
| e85df938a5 |
@@ -58,7 +58,6 @@ import { ContainerReaperModule } from "./container-reaper/container-reaper.modul
|
|||||||
import { FleetSettingsModule } from "./fleet-settings/fleet-settings.module";
|
import { FleetSettingsModule } from "./fleet-settings/fleet-settings.module";
|
||||||
import { OnboardingModule } from "./onboarding/onboarding.module";
|
import { OnboardingModule } from "./onboarding/onboarding.module";
|
||||||
import { ChatProxyModule } from "./chat-proxy/chat-proxy.module";
|
import { ChatProxyModule } from "./chat-proxy/chat-proxy.module";
|
||||||
import { OrchestratorModule } from "./orchestrator/orchestrator.module";
|
|
||||||
|
|
||||||
@Module({
|
@Module({
|
||||||
imports: [
|
imports: [
|
||||||
@@ -138,7 +137,6 @@ import { OrchestratorModule } from "./orchestrator/orchestrator.module";
|
|||||||
FleetSettingsModule,
|
FleetSettingsModule,
|
||||||
OnboardingModule,
|
OnboardingModule,
|
||||||
ChatProxyModule,
|
ChatProxyModule,
|
||||||
OrchestratorModule,
|
|
||||||
],
|
],
|
||||||
controllers: [AppController, CsrfController],
|
controllers: [AppController, CsrfController],
|
||||||
providers: [
|
providers: [
|
||||||
|
|||||||
@@ -1,194 +0,0 @@
|
|||||||
import { beforeEach, describe, expect, it, vi, afterEach } from "vitest";
|
|
||||||
import type { Response } from "express";
|
|
||||||
import { AgentStatus } from "@prisma/client";
|
|
||||||
import { OrchestratorController } from "./orchestrator.controller";
|
|
||||||
import { PrismaService } from "../prisma/prisma.service";
|
|
||||||
import { AuthGuard } from "../auth/guards/auth.guard";
|
|
||||||
|
|
||||||
describe("OrchestratorController", () => {
|
|
||||||
const mockPrismaService = {
|
|
||||||
agent: {
|
|
||||||
findMany: vi.fn(),
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
let controller: OrchestratorController;
|
|
||||||
|
|
||||||
beforeEach(() => {
|
|
||||||
vi.clearAllMocks();
|
|
||||||
controller = new OrchestratorController(mockPrismaService as unknown as PrismaService);
|
|
||||||
});
|
|
||||||
|
|
||||||
afterEach(() => {
|
|
||||||
vi.useRealTimers();
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("getAgents", () => {
|
|
||||||
it("returns active agents with API widget shape", async () => {
|
|
||||||
mockPrismaService.agent.findMany.mockResolvedValue([
|
|
||||||
{
|
|
||||||
id: "agent-1",
|
|
||||||
name: "Planner",
|
|
||||||
status: AgentStatus.WORKING,
|
|
||||||
role: "planner",
|
|
||||||
createdAt: new Date("2026-02-28T10:00:00.000Z"),
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
|
|
||||||
const result = await controller.getAgents();
|
|
||||||
|
|
||||||
expect(result).toEqual([
|
|
||||||
{
|
|
||||||
id: "agent-1",
|
|
||||||
name: "Planner",
|
|
||||||
status: AgentStatus.WORKING,
|
|
||||||
type: "planner",
|
|
||||||
createdAt: new Date("2026-02-28T10:00:00.000Z"),
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
|
|
||||||
expect(mockPrismaService.agent.findMany).toHaveBeenCalledWith({
|
|
||||||
where: {
|
|
||||||
status: {
|
|
||||||
not: AgentStatus.TERMINATED,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
orderBy: {
|
|
||||||
createdAt: "desc",
|
|
||||||
},
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
name: true,
|
|
||||||
status: true,
|
|
||||||
role: true,
|
|
||||||
createdAt: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
it("falls back to type=agent when role is missing", async () => {
|
|
||||||
mockPrismaService.agent.findMany.mockResolvedValue([
|
|
||||||
{
|
|
||||||
id: "agent-2",
|
|
||||||
name: null,
|
|
||||||
status: AgentStatus.IDLE,
|
|
||||||
role: null,
|
|
||||||
createdAt: new Date("2026-02-28T11:00:00.000Z"),
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
|
|
||||||
const result = await controller.getAgents();
|
|
||||||
|
|
||||||
expect(result[0]).toMatchObject({
|
|
||||||
id: "agent-2",
|
|
||||||
type: "agent",
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("streamEvents", () => {
|
|
||||||
it("sets SSE headers and writes initial data payload", async () => {
|
|
||||||
const onHandlers: Record<string, (() => void) | undefined> = {};
|
|
||||||
const mockRes = {
|
|
||||||
setHeader: vi.fn(),
|
|
||||||
write: vi.fn(),
|
|
||||||
end: vi.fn(),
|
|
||||||
on: vi.fn((event: string, handler: () => void) => {
|
|
||||||
onHandlers[event] = handler;
|
|
||||||
return mockRes;
|
|
||||||
}),
|
|
||||||
} as unknown as Response;
|
|
||||||
|
|
||||||
mockPrismaService.agent.findMany.mockResolvedValue([
|
|
||||||
{
|
|
||||||
id: "agent-1",
|
|
||||||
name: "Worker",
|
|
||||||
status: AgentStatus.WORKING,
|
|
||||||
role: "worker",
|
|
||||||
createdAt: new Date("2026-02-28T12:00:00.000Z"),
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
|
|
||||||
await controller.streamEvents(mockRes);
|
|
||||||
|
|
||||||
expect(mockRes.setHeader).toHaveBeenCalledWith("Content-Type", "text/event-stream");
|
|
||||||
expect(mockRes.setHeader).toHaveBeenCalledWith("Cache-Control", "no-cache");
|
|
||||||
expect(mockRes.setHeader).toHaveBeenCalledWith("Connection", "keep-alive");
|
|
||||||
expect(mockRes.setHeader).toHaveBeenCalledWith("X-Accel-Buffering", "no");
|
|
||||||
|
|
||||||
expect(mockRes.write).toHaveBeenCalledWith(
|
|
||||||
expect.stringContaining('"type":"agents:updated"')
|
|
||||||
);
|
|
||||||
expect(typeof onHandlers.close).toBe("function");
|
|
||||||
});
|
|
||||||
|
|
||||||
it("polls every 5 seconds and only emits when payload changes", async () => {
|
|
||||||
vi.useFakeTimers();
|
|
||||||
|
|
||||||
const onHandlers: Record<string, (() => void) | undefined> = {};
|
|
||||||
const mockRes = {
|
|
||||||
setHeader: vi.fn(),
|
|
||||||
write: vi.fn(),
|
|
||||||
end: vi.fn(),
|
|
||||||
on: vi.fn((event: string, handler: () => void) => {
|
|
||||||
onHandlers[event] = handler;
|
|
||||||
return mockRes;
|
|
||||||
}),
|
|
||||||
} as unknown as Response;
|
|
||||||
|
|
||||||
const firstPayload = [
|
|
||||||
{
|
|
||||||
id: "agent-1",
|
|
||||||
name: "Worker",
|
|
||||||
status: AgentStatus.WORKING,
|
|
||||||
role: "worker",
|
|
||||||
createdAt: new Date("2026-02-28T12:00:00.000Z"),
|
|
||||||
},
|
|
||||||
];
|
|
||||||
const secondPayload = [
|
|
||||||
{
|
|
||||||
id: "agent-1",
|
|
||||||
name: "Worker",
|
|
||||||
status: AgentStatus.WAITING,
|
|
||||||
role: "worker",
|
|
||||||
createdAt: new Date("2026-02-28T12:00:00.000Z"),
|
|
||||||
},
|
|
||||||
];
|
|
||||||
|
|
||||||
mockPrismaService.agent.findMany
|
|
||||||
.mockResolvedValueOnce(firstPayload)
|
|
||||||
.mockResolvedValueOnce(firstPayload)
|
|
||||||
.mockResolvedValueOnce(secondPayload);
|
|
||||||
|
|
||||||
await controller.streamEvents(mockRes);
|
|
||||||
|
|
||||||
// 1 initial data event
|
|
||||||
const getDataEventCalls = () =>
|
|
||||||
mockRes.write.mock.calls.filter(
|
|
||||||
(call) => typeof call[0] === "string" && call[0].startsWith("data: ")
|
|
||||||
);
|
|
||||||
|
|
||||||
expect(getDataEventCalls()).toHaveLength(1);
|
|
||||||
|
|
||||||
// No change after first poll => no new data event
|
|
||||||
await vi.advanceTimersByTimeAsync(5000);
|
|
||||||
expect(getDataEventCalls()).toHaveLength(1);
|
|
||||||
|
|
||||||
// Status changed on second poll => emits new data event
|
|
||||||
await vi.advanceTimersByTimeAsync(5000);
|
|
||||||
expect(getDataEventCalls()).toHaveLength(2);
|
|
||||||
|
|
||||||
onHandlers.close?.();
|
|
||||||
expect(mockRes.end).toHaveBeenCalledTimes(1);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("security", () => {
|
|
||||||
it("uses AuthGuard at the controller level", () => {
|
|
||||||
const guards = Reflect.getMetadata("__guards__", OrchestratorController) as unknown[];
|
|
||||||
const guardClasses = guards.map((guard) => guard);
|
|
||||||
|
|
||||||
expect(guardClasses).toContain(AuthGuard);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -1,115 +0,0 @@
|
|||||||
import { Controller, Get, Res, UseGuards } from "@nestjs/common";
|
|
||||||
import { AgentStatus } from "@prisma/client";
|
|
||||||
import type { Response } from "express";
|
|
||||||
import { AuthGuard } from "../auth/guards/auth.guard";
|
|
||||||
import { PrismaService } from "../prisma/prisma.service";
|
|
||||||
|
|
||||||
const AGENT_POLL_INTERVAL_MS = 5_000;
|
|
||||||
const SSE_HEARTBEAT_MS = 15_000;
|
|
||||||
|
|
||||||
interface OrchestratorAgentDto {
|
|
||||||
id: string;
|
|
||||||
name: string | null;
|
|
||||||
status: AgentStatus;
|
|
||||||
type: string;
|
|
||||||
createdAt: Date;
|
|
||||||
}
|
|
||||||
|
|
||||||
@Controller("orchestrator")
|
|
||||||
@UseGuards(AuthGuard)
|
|
||||||
export class OrchestratorController {
|
|
||||||
constructor(private readonly prisma: PrismaService) {}
|
|
||||||
|
|
||||||
@Get("agents")
|
|
||||||
async getAgents(): Promise<OrchestratorAgentDto[]> {
|
|
||||||
return this.fetchActiveAgents();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Get("events")
|
|
||||||
async streamEvents(@Res() res: Response): Promise<void> {
|
|
||||||
res.setHeader("Content-Type", "text/event-stream");
|
|
||||||
res.setHeader("Cache-Control", "no-cache");
|
|
||||||
res.setHeader("Connection", "keep-alive");
|
|
||||||
res.setHeader("X-Accel-Buffering", "no");
|
|
||||||
|
|
||||||
if (typeof res.flushHeaders === "function") {
|
|
||||||
res.flushHeaders();
|
|
||||||
}
|
|
||||||
|
|
||||||
let isClosed = false;
|
|
||||||
let previousSnapshot = "";
|
|
||||||
|
|
||||||
const emitSnapshotIfChanged = async (): Promise<void> => {
|
|
||||||
if (isClosed) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
try {
|
|
||||||
const agents = await this.fetchActiveAgents();
|
|
||||||
const snapshot = JSON.stringify(agents);
|
|
||||||
|
|
||||||
if (snapshot !== previousSnapshot) {
|
|
||||||
previousSnapshot = snapshot;
|
|
||||||
res.write(
|
|
||||||
`data: ${JSON.stringify({
|
|
||||||
type: "agents:updated",
|
|
||||||
agents,
|
|
||||||
timestamp: new Date().toISOString(),
|
|
||||||
})}\n\n`
|
|
||||||
);
|
|
||||||
}
|
|
||||||
} catch (error: unknown) {
|
|
||||||
const message = error instanceof Error ? error.message : String(error);
|
|
||||||
res.write(`event: error\n`);
|
|
||||||
res.write(`data: ${JSON.stringify({ error: message })}\n\n`);
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
await emitSnapshotIfChanged();
|
|
||||||
|
|
||||||
const pollInterval = setInterval(() => {
|
|
||||||
void emitSnapshotIfChanged();
|
|
||||||
}, AGENT_POLL_INTERVAL_MS);
|
|
||||||
|
|
||||||
const heartbeatInterval = setInterval(() => {
|
|
||||||
if (!isClosed) {
|
|
||||||
res.write(": keepalive\n\n");
|
|
||||||
}
|
|
||||||
}, SSE_HEARTBEAT_MS);
|
|
||||||
|
|
||||||
res.on("close", () => {
|
|
||||||
isClosed = true;
|
|
||||||
clearInterval(pollInterval);
|
|
||||||
clearInterval(heartbeatInterval);
|
|
||||||
res.end();
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
private async fetchActiveAgents(): Promise<OrchestratorAgentDto[]> {
|
|
||||||
const agents = await this.prisma.agent.findMany({
|
|
||||||
where: {
|
|
||||||
status: {
|
|
||||||
not: AgentStatus.TERMINATED,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
orderBy: {
|
|
||||||
createdAt: "desc",
|
|
||||||
},
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
name: true,
|
|
||||||
status: true,
|
|
||||||
role: true,
|
|
||||||
createdAt: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
return agents.map((agent) => ({
|
|
||||||
id: agent.id,
|
|
||||||
name: agent.name,
|
|
||||||
status: agent.status,
|
|
||||||
type: agent.role ?? "agent",
|
|
||||||
createdAt: agent.createdAt,
|
|
||||||
}));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1,10 +0,0 @@
|
|||||||
import { Module } from "@nestjs/common";
|
|
||||||
import { AuthModule } from "../auth/auth.module";
|
|
||||||
import { PrismaModule } from "../prisma/prisma.module";
|
|
||||||
import { OrchestratorController } from "./orchestrator.controller";
|
|
||||||
|
|
||||||
@Module({
|
|
||||||
imports: [AuthModule, PrismaModule],
|
|
||||||
controllers: [OrchestratorController],
|
|
||||||
})
|
|
||||||
export class OrchestratorModule {}
|
|
||||||
@@ -1,31 +0,0 @@
|
|||||||
import { describe, expect, it } from "vitest";
|
|
||||||
import { WidgetsController } from "./widgets.controller";
|
|
||||||
|
|
||||||
const THROTTLER_SKIP_DEFAULT_KEY = "THROTTLER:SKIPdefault";
|
|
||||||
|
|
||||||
describe("WidgetsController throttler metadata", () => {
|
|
||||||
it("marks widget data polling endpoints to skip throttling", () => {
|
|
||||||
const pollingHandlers = [
|
|
||||||
WidgetsController.prototype.getStatCardData,
|
|
||||||
WidgetsController.prototype.getChartData,
|
|
||||||
WidgetsController.prototype.getListData,
|
|
||||||
WidgetsController.prototype.getCalendarPreviewData,
|
|
||||||
WidgetsController.prototype.getActiveProjectsData,
|
|
||||||
WidgetsController.prototype.getAgentChainsData,
|
|
||||||
];
|
|
||||||
|
|
||||||
for (const handler of pollingHandlers) {
|
|
||||||
expect(Reflect.getMetadata(THROTTLER_SKIP_DEFAULT_KEY, handler)).toBe(true);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it("does not skip throttling for non-polling widget routes", () => {
|
|
||||||
expect(
|
|
||||||
Reflect.getMetadata(THROTTLER_SKIP_DEFAULT_KEY, WidgetsController.prototype.findAll)
|
|
||||||
).toBe(undefined);
|
|
||||||
|
|
||||||
expect(
|
|
||||||
Reflect.getMetadata(THROTTLER_SKIP_DEFAULT_KEY, WidgetsController.prototype.findByName)
|
|
||||||
).toBe(undefined);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -1,5 +1,4 @@
|
|||||||
import { Controller, Get, Post, Body, Param, UseGuards, Request } from "@nestjs/common";
|
import { Controller, Get, Post, Body, Param, UseGuards, Request } from "@nestjs/common";
|
||||||
import { SkipThrottle as SkipThrottler } from "@nestjs/throttler";
|
|
||||||
import { WidgetsService } from "./widgets.service";
|
import { WidgetsService } from "./widgets.service";
|
||||||
import { WidgetDataService } from "./widget-data.service";
|
import { WidgetDataService } from "./widget-data.service";
|
||||||
import { AuthGuard } from "../auth/guards/auth.guard";
|
import { AuthGuard } from "../auth/guards/auth.guard";
|
||||||
@@ -44,7 +43,6 @@ export class WidgetsController {
|
|||||||
* Get stat card widget data
|
* Get stat card widget data
|
||||||
*/
|
*/
|
||||||
@Post("data/stat-card")
|
@Post("data/stat-card")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getStatCardData(@Request() req: RequestWithWorkspace, @Body() query: StatCardQueryDto) {
|
async getStatCardData(@Request() req: RequestWithWorkspace, @Body() query: StatCardQueryDto) {
|
||||||
return this.widgetDataService.getStatCardData(req.workspace.id, query);
|
return this.widgetDataService.getStatCardData(req.workspace.id, query);
|
||||||
@@ -55,7 +53,6 @@ export class WidgetsController {
|
|||||||
* Get chart widget data
|
* Get chart widget data
|
||||||
*/
|
*/
|
||||||
@Post("data/chart")
|
@Post("data/chart")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getChartData(@Request() req: RequestWithWorkspace, @Body() query: ChartQueryDto) {
|
async getChartData(@Request() req: RequestWithWorkspace, @Body() query: ChartQueryDto) {
|
||||||
return this.widgetDataService.getChartData(req.workspace.id, query);
|
return this.widgetDataService.getChartData(req.workspace.id, query);
|
||||||
@@ -66,7 +63,6 @@ export class WidgetsController {
|
|||||||
* Get list widget data
|
* Get list widget data
|
||||||
*/
|
*/
|
||||||
@Post("data/list")
|
@Post("data/list")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getListData(@Request() req: RequestWithWorkspace, @Body() query: ListQueryDto) {
|
async getListData(@Request() req: RequestWithWorkspace, @Body() query: ListQueryDto) {
|
||||||
return this.widgetDataService.getListData(req.workspace.id, query);
|
return this.widgetDataService.getListData(req.workspace.id, query);
|
||||||
@@ -77,7 +73,6 @@ export class WidgetsController {
|
|||||||
* Get calendar preview widget data
|
* Get calendar preview widget data
|
||||||
*/
|
*/
|
||||||
@Post("data/calendar-preview")
|
@Post("data/calendar-preview")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getCalendarPreviewData(
|
async getCalendarPreviewData(
|
||||||
@Request() req: RequestWithWorkspace,
|
@Request() req: RequestWithWorkspace,
|
||||||
@@ -91,7 +86,6 @@ export class WidgetsController {
|
|||||||
* Get active projects widget data
|
* Get active projects widget data
|
||||||
*/
|
*/
|
||||||
@Post("data/active-projects")
|
@Post("data/active-projects")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getActiveProjectsData(@Request() req: RequestWithWorkspace) {
|
async getActiveProjectsData(@Request() req: RequestWithWorkspace) {
|
||||||
return this.widgetDataService.getActiveProjectsData(req.workspace.id);
|
return this.widgetDataService.getActiveProjectsData(req.workspace.id);
|
||||||
@@ -102,7 +96,6 @@ export class WidgetsController {
|
|||||||
* Get agent chains widget data (active agent sessions)
|
* Get agent chains widget data (active agent sessions)
|
||||||
*/
|
*/
|
||||||
@Post("data/agent-chains")
|
@Post("data/agent-chains")
|
||||||
@SkipThrottler()
|
|
||||||
@UseGuards(WorkspaceGuard)
|
@UseGuards(WorkspaceGuard)
|
||||||
async getAgentChainsData(@Request() req: RequestWithWorkspace) {
|
async getAgentChainsData(@Request() req: RequestWithWorkspace) {
|
||||||
return this.widgetDataService.getAgentChainsData(req.workspace.id);
|
return this.widgetDataService.getAgentChainsData(req.workspace.id);
|
||||||
|
|||||||
@@ -85,6 +85,14 @@ const INITIAL_FORM: ProviderFormState = {
|
|||||||
isActive: true,
|
isActive: true,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
function mapProviderTypeToApi(type: string): "ollama" | "openai" | "claude" {
|
||||||
|
if (type === "ollama" || type === "claude") {
|
||||||
|
return type;
|
||||||
|
}
|
||||||
|
|
||||||
|
return "openai";
|
||||||
|
}
|
||||||
|
|
||||||
function getErrorMessage(error: unknown, fallback: string): string {
|
function getErrorMessage(error: unknown, fallback: string): string {
|
||||||
if (error instanceof Error && error.message.trim().length > 0) {
|
if (error instanceof Error && error.message.trim().length > 0) {
|
||||||
return error.message;
|
return error.message;
|
||||||
@@ -93,18 +101,6 @@ function getErrorMessage(error: unknown, fallback: string): string {
|
|||||||
return fallback;
|
return fallback;
|
||||||
}
|
}
|
||||||
|
|
||||||
function buildProviderName(displayName: string, type: string): string {
|
|
||||||
const slug = displayName
|
|
||||||
.trim()
|
|
||||||
.toLowerCase()
|
|
||||||
.replace(/[^a-z0-9]+/g, "-")
|
|
||||||
.replace(/^-+/, "")
|
|
||||||
.replace(/-+$/, "");
|
|
||||||
|
|
||||||
const candidate = `${type}-${slug.length > 0 ? slug : "provider"}`;
|
|
||||||
return candidate.slice(0, 100);
|
|
||||||
}
|
|
||||||
|
|
||||||
function normalizeProviderModels(models: unknown): FleetProviderModel[] {
|
function normalizeProviderModels(models: unknown): FleetProviderModel[] {
|
||||||
if (!Array.isArray(models)) {
|
if (!Array.isArray(models)) {
|
||||||
return [];
|
return [];
|
||||||
@@ -153,11 +149,11 @@ function modelsToEditorText(models: unknown): string {
|
|||||||
.join("\n");
|
.join("\n");
|
||||||
}
|
}
|
||||||
|
|
||||||
function parseModelsText(value: string): FleetProviderModel[] {
|
function parseModelsText(value: string): string[] {
|
||||||
const seen = new Set<string>();
|
const seen = new Set<string>();
|
||||||
|
|
||||||
return value
|
return value
|
||||||
.split(/\n|,/g)
|
.split(/\r?\n/g)
|
||||||
.map((segment) => segment.trim())
|
.map((segment) => segment.trim())
|
||||||
.filter((segment) => segment.length > 0)
|
.filter((segment) => segment.length > 0)
|
||||||
.filter((segment) => {
|
.filter((segment) => {
|
||||||
@@ -166,8 +162,7 @@ function parseModelsText(value: string): FleetProviderModel[] {
|
|||||||
}
|
}
|
||||||
seen.add(segment);
|
seen.add(segment);
|
||||||
return true;
|
return true;
|
||||||
})
|
});
|
||||||
.map((id) => ({ id, name: id }));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function maskApiKey(value: string): string {
|
function maskApiKey(value: string): string {
|
||||||
@@ -279,6 +274,7 @@ export default function ProvidersSettingsPage(): ReactElement {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const models = parseModelsText(form.modelsText);
|
const models = parseModelsText(form.modelsText);
|
||||||
|
const providerModels = models.map((id) => ({ id, name: id }));
|
||||||
const baseUrl = form.baseUrl.trim();
|
const baseUrl = form.baseUrl.trim();
|
||||||
const apiKey = form.apiKey.trim();
|
const apiKey = form.apiKey.trim();
|
||||||
|
|
||||||
@@ -289,7 +285,7 @@ export default function ProvidersSettingsPage(): ReactElement {
|
|||||||
const updatePayload: UpdateFleetProviderRequest = {
|
const updatePayload: UpdateFleetProviderRequest = {
|
||||||
displayName,
|
displayName,
|
||||||
isActive: form.isActive,
|
isActive: form.isActive,
|
||||||
models,
|
models: providerModels,
|
||||||
};
|
};
|
||||||
|
|
||||||
if (baseUrl.length > 0) {
|
if (baseUrl.length > 0) {
|
||||||
@@ -303,21 +299,27 @@ export default function ProvidersSettingsPage(): ReactElement {
|
|||||||
await updateFleetProvider(editingProvider.id, updatePayload);
|
await updateFleetProvider(editingProvider.id, updatePayload);
|
||||||
setSuccessMessage(`Updated provider "${displayName}".`);
|
setSuccessMessage(`Updated provider "${displayName}".`);
|
||||||
} else {
|
} else {
|
||||||
const createPayload: CreateFleetProviderRequest = {
|
const config: CreateFleetProviderRequest["config"] = {};
|
||||||
name: buildProviderName(displayName, form.type),
|
|
||||||
displayName,
|
|
||||||
type: form.type,
|
|
||||||
models,
|
|
||||||
};
|
|
||||||
|
|
||||||
if (baseUrl.length > 0) {
|
if (baseUrl.length > 0) {
|
||||||
createPayload.baseUrl = baseUrl;
|
config.endpoint = baseUrl;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (apiKey.length > 0) {
|
if (apiKey.length > 0) {
|
||||||
createPayload.apiKey = apiKey;
|
config.apiKey = apiKey;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (models.length > 0) {
|
||||||
|
config.models = models;
|
||||||
|
}
|
||||||
|
|
||||||
|
const createPayload: CreateFleetProviderRequest = {
|
||||||
|
displayName,
|
||||||
|
providerType: mapProviderTypeToApi(form.type),
|
||||||
|
config,
|
||||||
|
isEnabled: form.isActive,
|
||||||
|
};
|
||||||
|
|
||||||
await createFleetProvider(createPayload);
|
await createFleetProvider(createPayload);
|
||||||
setSuccessMessage(`Added provider "${displayName}".`);
|
setSuccessMessage(`Added provider "${displayName}".`);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -34,17 +34,25 @@ describe("createFleetProvider", (): void => {
|
|||||||
vi.mocked(client.apiPost).mockResolvedValueOnce({ id: "provider-1" } as never);
|
vi.mocked(client.apiPost).mockResolvedValueOnce({ id: "provider-1" } as never);
|
||||||
|
|
||||||
await createFleetProvider({
|
await createFleetProvider({
|
||||||
name: "openai-main",
|
providerType: "openai",
|
||||||
displayName: "OpenAI Main",
|
displayName: "OpenAI Main",
|
||||||
type: "openai",
|
config: {
|
||||||
apiKey: "sk-test",
|
endpoint: "https://api.openai.com/v1",
|
||||||
|
apiKey: "sk-test",
|
||||||
|
models: ["gpt-4.1-mini", "gpt-4o-mini"],
|
||||||
|
},
|
||||||
|
isEnabled: true,
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(client.apiPost).toHaveBeenCalledWith("/api/fleet-settings/providers", {
|
expect(client.apiPost).toHaveBeenCalledWith("/api/fleet-settings/providers", {
|
||||||
name: "openai-main",
|
providerType: "openai",
|
||||||
displayName: "OpenAI Main",
|
displayName: "OpenAI Main",
|
||||||
type: "openai",
|
config: {
|
||||||
apiKey: "sk-test",
|
endpoint: "https://api.openai.com/v1",
|
||||||
|
apiKey: "sk-test",
|
||||||
|
models: ["gpt-4.1-mini", "gpt-4o-mini"],
|
||||||
|
},
|
||||||
|
isEnabled: true,
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -16,13 +16,16 @@ export interface FleetProvider {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export interface CreateFleetProviderRequest {
|
export interface CreateFleetProviderRequest {
|
||||||
name: string;
|
providerType: "ollama" | "openai" | "claude";
|
||||||
displayName: string;
|
displayName: string;
|
||||||
type: string;
|
config: {
|
||||||
baseUrl?: string;
|
endpoint?: string;
|
||||||
apiKey?: string;
|
apiKey?: string;
|
||||||
apiType?: string;
|
models?: string[];
|
||||||
models?: FleetProviderModel[];
|
timeout?: number;
|
||||||
|
};
|
||||||
|
isDefault?: boolean;
|
||||||
|
isEnabled?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface UpdateFleetProviderRequest {
|
export interface UpdateFleetProviderRequest {
|
||||||
|
|||||||
Reference in New Issue
Block a user