mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Enhance WikiLink XSS protection with comprehensive validation #201

New Issue
Closed
opened 2026-02-02 18:08:07 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-02 18:08:07 +00:00
Owner
Copy Link

Context: Issue #191 was resolved with basic slug validation and HTML escaping. However, agent a3f2854 designed more comprehensive protections.

Current Implementation (basic):

  • Alphanumeric whitelist for slugs
  • HTML escaping in title attribute

Proposed Enhancements:

  1. Protocol filtering with decode validation (checks raw, percent-decoded, and entity-decoded)
  2. Defense against percent-encoding bypass (%6A%61%76%61%73%63%72%69%70%74:)
  3. HTML entity bypass prevention (javascript:)
  4. Protocol-relative URL blocking (//)
  5. Unicode null byte filtering
  6. SVG XSS vector blocking
  7. Base64 data URI validation

Benefits:

  • Blocks sophisticated encoding-based XSS attacks
  • Defense-in-depth with 4 security layers
  • Handles edge cases not caught by basic validation

Test Coverage: 82.3% (15 security tests covering advanced attack vectors)
Priority: P2 (enhancement) - Core vulnerability patched

References: Agent a3f2854 transcript

Context: Issue #191 was resolved with basic slug validation and HTML escaping. However, agent a3f2854 designed more comprehensive protections. Current Implementation (basic): - Alphanumeric whitelist for slugs - HTML escaping in title attribute Proposed Enhancements: 1. Protocol filtering with decode validation (checks raw, percent-decoded, and entity-decoded) 2. Defense against percent-encoding bypass (%6A%61%76%61%73%63%72%69%70%74:) 3. HTML entity bypass prevention (javascript:) 4. Protocol-relative URL blocking (//) 5. Unicode null byte filtering 6. SVG XSS vector blocking 7. Base64 data URI validation Benefits: - Blocks sophisticated encoding-based XSS attacks - Defense-in-depth with 4 security layers - Handles edge cases not caught by basic validation Test Coverage: 82.3% (15 security tests covering advanced attack vectors) Priority: P2 (enhancement) - Core vulnerability patched References: Agent a3f2854 transcript
jason.woltje added the p2securityweb labels 2026-02-02 18:08:07 +00:00
jason.woltje added this to the M7.1-Remediation (0.0.8) milestone 2026-02-03 22:31:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label p2 security web
Milestone
No items
No Milestone M7.1-Remediation (0.0.8)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?