mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

ORCH-116: 50% rule enforcement #251

New Issue
Closed
opened 2026-02-02 21:55:11 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-02 21:55:11 +00:00
Owner
Copy Link

Enforce 50% rule: no more than 50% AI-generated code in PR.

Acceptance Criteria

  • Mechanical gates: typecheck, lint, tests, coverage (coordinator)
  • AI confirmation: independent AI agent reviews (coordinator)
  • Orchestrator calls both mechanical and AI gates
  • Reject if either fails
  • Return detailed failure reasons
  • Comprehensive unit tests (36 total)
  • Test coverage >= 85% (achieved 93.33%)

Implementation Summary

Added comprehensive tests for 50% rule scenarios and hasAIConfirmation() helper method. All tests passing with 93.33% branch coverage.

See docs/scratchpads/orch-116-fifty-percent.md for details.

Enforce 50% rule: no more than 50% AI-generated code in PR. ## Acceptance Criteria - [x] Mechanical gates: typecheck, lint, tests, coverage (coordinator) - [x] AI confirmation: independent AI agent reviews (coordinator) - [x] Orchestrator calls both mechanical and AI gates - [x] Reject if either fails - [x] Return detailed failure reasons - [x] Comprehensive unit tests (36 total) - [x] Test coverage >= 85% (achieved 93.33%) ## Implementation Summary Added comprehensive tests for 50% rule scenarios and hasAIConfirmation() helper method. All tests passing with 93.33% branch coverage. See docs/scratchpads/orch-116-fifty-percent.md for details.
jason.woltje added the orchestrator label 2026-02-02 21:55:11 +00:00
jason.woltje commented 2026-02-02 21:55:36 +00:00
Author
Owner
Copy Link

✅ ORCH-116 implementation complete.

What Was Done

  1. Added 14 new comprehensive test cases for 50% rule enforcement
  2. Added hasAIConfirmation() helper method
  3. Enhanced documentation explaining 50% rule

Test Results

✅ All 36 tests passing
✅ Coverage: 93.33% branch, 100% line

Files Modified

  • quality-gates.service.spec.ts (+240 lines)
  • quality-gates.service.ts (+20 lines)
  • docs/scratchpads/orch-116-fifty-percent.md (created)

Implementation follows TDD principles (RED-GREEN-REFACTOR).

✅ ORCH-116 implementation complete. ## What Was Done 1. Added 14 new comprehensive test cases for 50% rule enforcement 2. Added hasAIConfirmation() helper method 3. Enhanced documentation explaining 50% rule ## Test Results ✅ All 36 tests passing ✅ Coverage: 93.33% branch, 100% line ## Files Modified - quality-gates.service.spec.ts (+240 lines) - quality-gates.service.ts (+20 lines) - docs/scratchpads/orch-116-fifty-percent.md (created) Implementation follows TDD principles (RED-GREEN-REFACTOR).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label orchestrator
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#251
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?