mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[CRITICAL] Fix TypeScript compilation errors in orchestrator tests #260

New Issue
Closed
opened 2026-02-02 23:15:53 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-02 23:15:53 +00:00
Owner
Copy Link

Priority: CRITICAL - Blocks deployment

Problem:
TypeScript compilation fails with 14 errors in test files, preventing builds.

Files Affected:

  • apps/orchestrator/src/api/agents/agents.controller.spec.ts:23
  • apps/orchestrator/src/coordinator/quality-gates.service.spec.ts:825,840,853,862,874

Issues:

  1. AgentsController test missing third constructor argument (KillswitchService)
  2. Missing QualityGateResult type import in quality-gates tests

Acceptance Criteria:

  • pnpm --filter @mosaic/orchestrator typecheck passes with 0 errors
  • All test files compile successfully
  • AgentsController tests include KillswitchService mock
  • QualityGateResult type properly imported

Fix:

// agents.controller.spec.ts:23
controller = new AgentsController(queueService, spawnerService, killswitchService);

// quality-gates.service.spec.ts (add import)
import { QualityGateResult } from './quality-gates.service';

Code Review Confidence: 95%
Found by: pr-review-toolkit:code-reviewer

**Priority:** CRITICAL - Blocks deployment **Problem:** TypeScript compilation fails with 14 errors in test files, preventing builds. **Files Affected:** - `apps/orchestrator/src/api/agents/agents.controller.spec.ts:23` - `apps/orchestrator/src/coordinator/quality-gates.service.spec.ts:825,840,853,862,874` **Issues:** 1. AgentsController test missing third constructor argument (KillswitchService) 2. Missing QualityGateResult type import in quality-gates tests **Acceptance Criteria:** - [ ] `pnpm --filter @mosaic/orchestrator typecheck` passes with 0 errors - [ ] All test files compile successfully - [ ] AgentsController tests include KillswitchService mock - [ ] QualityGateResult type properly imported **Fix:** ```typescript // agents.controller.spec.ts:23 controller = new AgentsController(queueService, spawnerService, killswitchService); // quality-gates.service.spec.ts (add import) import { QualityGateResult } from './quality-gates.service'; ``` **Code Review Confidence:** 95% **Found by:** pr-review-toolkit:code-reviewer
jason.woltje added this to the M6-AgentOrchestration (0.0.6) milestone 2026-02-02 23:15:53 +00:00
jason.woltje added the testingorchestrator labels 2026-02-02 23:15:53 +00:00
jason.woltje commented 2026-02-03 17:37:33 +00:00
Author
Owner
Copy Link

✅ Fixed: TypeScript compilation now succeeds with 0 errors. All test files compile successfully.

✅ Fixed: TypeScript compilation now succeeds with 0 errors. All test files compile successfully.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label orchestrator testing
Milestone
No items
No Milestone M6-AgentOrchestration (0.0.6)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?