mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[CRITICAL] Replace explicit 'any' types with proper mocks in tests #261

New Issue
Closed
opened 2026-02-02 23:16:00 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-02 23:16:00 +00:00
Owner
Copy Link

Priority: CRITICAL - Quality Rails violation

CLAUDE.md Violation: Quality Rails blocks @typescript-eslint/no-explicit-any: error

Problem:
Test files use explicit any types (6+ instances), violating TypeScript strict mode and quality standards.

Files Affected:

  • apps/orchestrator/src/api/agents/agents.controller.spec.ts (Lines 9, 10, 16, 24, 165, 179)
  • apps/orchestrator/src/coordinator/coordinator-client.service.spec.ts (Lines 12, 24)

Acceptance Criteria:

  • All any types replaced with proper mock types
  • pnpm --filter @mosaic/orchestrator lint shows 0 no-explicit-any errors
  • All tests still pass

Example Fix:

// Instead of:
let queueService: any;
let spawnerService: any;

// Use:
let queueService: { addTask: ReturnType<typeof vi.fn> };
let spawnerService: { spawnAgent: ReturnType<typeof vi.fn> };

Code Review Confidence: 92%
Found by: pr-review-toolkit:code-reviewer

**Priority:** CRITICAL - Quality Rails violation **CLAUDE.md Violation:** Quality Rails blocks `@typescript-eslint/no-explicit-any: error` **Problem:** Test files use explicit `any` types (6+ instances), violating TypeScript strict mode and quality standards. **Files Affected:** - `apps/orchestrator/src/api/agents/agents.controller.spec.ts` (Lines 9, 10, 16, 24, 165, 179) - `apps/orchestrator/src/coordinator/coordinator-client.service.spec.ts` (Lines 12, 24) **Acceptance Criteria:** - [ ] All `any` types replaced with proper mock types - [ ] `pnpm --filter @mosaic/orchestrator lint` shows 0 `no-explicit-any` errors - [ ] All tests still pass **Example Fix:** ```typescript // Instead of: let queueService: any; let spawnerService: any; // Use: let queueService: { addTask: ReturnType<typeof vi.fn> }; let spawnerService: { spawnAgent: ReturnType<typeof vi.fn> }; ``` **Code Review Confidence:** 92% **Found by:** pr-review-toolkit:code-reviewer
jason.woltje added this to the M6-AgentOrchestration (0.0.6) milestone 2026-02-02 23:16:00 +00:00
jason.woltje added the testingorchestrator labels 2026-02-02 23:16:00 +00:00
jason.woltje commented 2026-02-03 17:37:35 +00:00
Author
Owner
Copy Link

✅ Fixed: Replaced all explicit 'any' types with proper type assertions. All tests now have proper type safety.

✅ Fixed: Replaced all explicit 'any' types with proper type assertions. All tests now have proper type safety.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label orchestrator testing
Milestone
No items
No Milestone M6-AgentOrchestration (0.0.6)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?