mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[CRITICAL] Fix silent cleanup failures - return structured results #262

New Issue
Closed
opened 2026-02-02 23:16:09 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-02 23:16:09 +00:00
Owner
Copy Link

Priority: CRITICAL - Silent failures

Problem:
CleanupService catches all errors and only logs them, never notifying callers of partial failures. Users see "Agent killed successfully" even when cleanup failed, leaving orphaned resources.

File: apps/orchestrator/src/killswitch/cleanup.service.ts:62-133

Hidden Errors:

  • Docker container cleanup failures (permissions, daemon crashes)
  • Git worktree removal failures (filesystem issues, locks)
  • Valkey state deletion failures (network issues)
  • Event publication failures

Impact:

  • Orphaned Docker containers consuming memory
  • Orphaned git worktrees consuming disk space
  • Inconsistent system state
  • Users unaware cleanup failed

Acceptance Criteria:

  • CleanupService returns structured CleanupResult type
  • Result indicates success/failure for each step (docker, worktree, state)
  • Callers check results and inform users of partial failures
  • Tests verify partial failure scenarios
  • Documentation updated with cleanup behavior

Recommended Approach:
Return typed result instead of void:

interface CleanupResult {
  docker: { success: boolean; error?: string };
  worktree: { success: boolean; error?: string };
  state: { success: boolean; error?: string };
  allSuccessful(): boolean;
  getFailures(): string[];
}

Code Review Confidence: 90%
Found by: pr-review-toolkit:silent-failure-hunter

**Priority:** CRITICAL - Silent failures **Problem:** CleanupService catches all errors and only logs them, never notifying callers of partial failures. Users see "Agent killed successfully" even when cleanup failed, leaving orphaned resources. **File:** `apps/orchestrator/src/killswitch/cleanup.service.ts:62-133` **Hidden Errors:** - Docker container cleanup failures (permissions, daemon crashes) - Git worktree removal failures (filesystem issues, locks) - Valkey state deletion failures (network issues) - Event publication failures **Impact:** - Orphaned Docker containers consuming memory - Orphaned git worktrees consuming disk space - Inconsistent system state - Users unaware cleanup failed **Acceptance Criteria:** - [ ] CleanupService returns structured `CleanupResult` type - [ ] Result indicates success/failure for each step (docker, worktree, state) - [ ] Callers check results and inform users of partial failures - [ ] Tests verify partial failure scenarios - [ ] Documentation updated with cleanup behavior **Recommended Approach:** Return typed result instead of void: ```typescript interface CleanupResult { docker: { success: boolean; error?: string }; worktree: { success: boolean; error?: string }; state: { success: boolean; error?: string }; allSuccessful(): boolean; getFailures(): string[]; } ``` **Code Review Confidence:** 90% **Found by:** pr-review-toolkit:silent-failure-hunter
jason.woltje added this to the M6-AgentOrchestration (0.0.6) milestone 2026-02-02 23:16:09 +00:00
jason.woltje added the orchestrator label 2026-02-02 23:16:09 +00:00
jason.woltje commented 2026-02-03 17:37:36 +00:00
Author
Owner
Copy Link

✅ Fixed: Added CleanupResult interface with structured results for each cleanup step (docker, worktree, state). File: apps/orchestrator/src/killswitch/cleanup.service.ts

✅ Fixed: Added CleanupResult interface with structured results for each cleanup step (docker, worktree, state). File: apps/orchestrator/src/killswitch/cleanup.service.ts
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label orchestrator
Milestone
No items
No Milestone M6-AgentOrchestration (0.0.6)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?