mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[MEDIUM] Update outdated TODO comments #269

New Issue
Closed
opened 2026-02-02 23:17:22 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-02 23:17:22 +00:00
Owner
Copy Link

Priority: MEDIUM - Technical debt

Problem:
4 TODO comments are outdated or misleading, creating confusion about implementation status.

Files Affected:

  1. agent-spawner.service.ts:66 - References "next iteration" but SDK already imported
  2. queue.service.ts:234-235 - Says "will be handled" but already implemented
  3. docker-sandbox.service.ts:112 - Security claim may not match all images
  4. docker-sandbox.service.ts:119 - Missing rationale for insecure config

Acceptance Criteria:

  • All TODO comments reviewed
  • Outdated TODOs removed or updated
  • Remaining TODOs reference issue numbers: TODO(#123): description
  • Security comments include rationale for decisions
  • Implementation comments use present tense (not future)

Recommended Changes:

File 1: agent-spawner.service.ts:66

// Remove or update to:
// Session creation complete. Agent execution triggered by queue worker.

File 2: queue.service.ts:234-235

// Change to:
// Task processing delegated to agent spawner via state transition to 'executing'

File 3: docker-sandbox.service.ts:112

User: 'node:node', // Non-root user (requires image with node:node user)

File 4: docker-sandbox.service.ts:119

ReadonlyRootfs: false, // Allow writes (TODO: Restrict to /workspace only - issue #XXX)

Code Review Confidence: 85%
Found by: pr-review-toolkit:comment-analyzer

**Priority:** MEDIUM - Technical debt **Problem:** 4 TODO comments are outdated or misleading, creating confusion about implementation status. **Files Affected:** 1. `agent-spawner.service.ts:66` - References "next iteration" but SDK already imported 2. `queue.service.ts:234-235` - Says "will be handled" but already implemented 3. `docker-sandbox.service.ts:112` - Security claim may not match all images 4. `docker-sandbox.service.ts:119` - Missing rationale for insecure config **Acceptance Criteria:** - [ ] All TODO comments reviewed - [ ] Outdated TODOs removed or updated - [ ] Remaining TODOs reference issue numbers: `TODO(#123): description` - [ ] Security comments include rationale for decisions - [ ] Implementation comments use present tense (not future) **Recommended Changes:** **File 1:** agent-spawner.service.ts:66 ```typescript // Remove or update to: // Session creation complete. Agent execution triggered by queue worker. ``` **File 2:** queue.service.ts:234-235 ```typescript // Change to: // Task processing delegated to agent spawner via state transition to 'executing' ``` **File 3:** docker-sandbox.service.ts:112 ```typescript User: 'node:node', // Non-root user (requires image with node:node user) ``` **File 4:** docker-sandbox.service.ts:119 ```typescript ReadonlyRootfs: false, // Allow writes (TODO: Restrict to /workspace only - issue #XXX) ``` **Code Review Confidence:** 85% **Found by:** pr-review-toolkit:comment-analyzer
jason.woltje added this to the M6-AgentOrchestration (0.0.6) milestone 2026-02-02 23:17:22 +00:00
jason.woltje added the orchestrator label 2026-02-02 23:17:22 +00:00
jason.woltje commented 2026-02-03 17:37:44 +00:00
Author
Owner
Copy Link

✅ Fixed: All TODO comments removed from src/ directory. 0 remaining.

✅ Fixed: All TODO comments removed from src/ directory. 0 remaining.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label orchestrator
Milestone
No items
No Milestone M6-AgentOrchestration (0.0.6)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#269
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?