mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

🔴 [P0] Sanitize agent spawn command payloads (command injection risk) #274

New Issue
Closed
opened 2026-02-03 22:29:25 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-03 22:29:25 +00:00
Owner
Copy Link

Summary

Agent spawn passes unvalidated context and options to orchestrator. Potential command injection and RCE.

Location

apps/api/src/federation/federation-agent.service.ts:237-275

Security Impact

  • Command injection if context contains shell commands
  • Path traversal if context contains file paths
  • Remote code execution risk

Required Implementation

  1. Validate taskId format
  2. Whitelist allowed agentType values
  3. Sanitize context fields
  4. Validate all string values

Priority

CRITICAL (P0) - RCE risk

## Summary Agent spawn passes unvalidated `context` and `options` to orchestrator. Potential command injection and RCE. ## Location `apps/api/src/federation/federation-agent.service.ts:237-275` ## Security Impact - Command injection if context contains shell commands - Path traversal if context contains file paths - Remote code execution risk ## Required Implementation 1. Validate `taskId` format 2. Whitelist allowed `agentType` values 3. Sanitize `context` fields 4. Validate all string values ## Priority **CRITICAL (P0)** - RCE risk
jason.woltje added the securityp0apiapi labels 2026-02-03 22:29:25 +00:00
jason.woltje added this to the M7.1-Remediation (0.0.8) milestone 2026-02-03 22:31:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label api api p0 security
Milestone
No items
No Milestone M7.1-Remediation (0.0.8)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?