mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Phase 1: Critical Security Fixes #337

New Issue
Closed
opened 2026-02-05 21:12:25 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-05 21:12:25 +00:00
Owner
Copy Link

Findings (Critical Severity)

  • SEC-ORCH-2: No authentication on orchestrator API endpoints
  • SEC-API-4: RLS context never applied in service layer
  • SEC-WEB-2: WikiLinkRenderer stored XSS via dangerouslySetInnerHTML
  • SEC-ORCH-1: Secret scanner returns false on scan errors
  • SEC-ORCH-3: Docker sandbox disabled by default
  • SEC-ORCH-4: Unauthenticated inter-service communication
  • SEC-API-2: WorkspaceGuard swallows DB errors as access denied
  • SEC-API-3: PermissionGuard swallows DB errors as null role
  • SEC-API-1: OIDC config silently degrades to empty strings
  • SEC-ORCH-5: Redis KEYS command in production (DoS risk)
  • SEC-ORCH-6: Unsafe deserialization with type assertion
  • SEC-WEB-1: Open redirect via unsanitized OAuth error parameter
  • CQ-API-6: Hardcoded TODO values in OIDC federation
  • CQ-WEB-5: Incorrect boolean logic in ReactFlowEditor

Acceptance Criteria

  • All critical findings remediated
  • Quality gates passing (pnpm lint && pnpm typecheck && pnpm test)
  • No new regressions
## Findings (Critical Severity) - SEC-ORCH-2: No authentication on orchestrator API endpoints - SEC-API-4: RLS context never applied in service layer - SEC-WEB-2: WikiLinkRenderer stored XSS via dangerouslySetInnerHTML - SEC-ORCH-1: Secret scanner returns false on scan errors - SEC-ORCH-3: Docker sandbox disabled by default - SEC-ORCH-4: Unauthenticated inter-service communication - SEC-API-2: WorkspaceGuard swallows DB errors as access denied - SEC-API-3: PermissionGuard swallows DB errors as null role - SEC-API-1: OIDC config silently degrades to empty strings - SEC-ORCH-5: Redis KEYS command in production (DoS risk) - SEC-ORCH-6: Unsafe deserialization with type assertion - SEC-WEB-1: Open redirect via unsanitized OAuth error parameter - CQ-API-6: Hardcoded TODO values in OIDC federation - CQ-WEB-5: Incorrect boolean logic in ReactFlowEditor ## Acceptance Criteria - [ ] All critical findings remediated - [ ] Quality gates passing (pnpm lint && pnpm typecheck && pnpm test) - [ ] No new regressions
jason.woltje added the security label 2026-02-05 21:12:25 +00:00
jason.woltje added this to the M6-AgentOrchestration-Fixes milestone 2026-02-05 22:09:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label security
Milestone
No items
No Milestone M6-AgentOrchestration-Fixes
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?