mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Phase 2: High Priority Security + Infrastructure #338

New Issue
Closed
opened 2026-02-05 21:12:42 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-05 21:12:42 +00:00
Owner
Copy Link

Findings (High Severity)

Security - API:

  • SEC-API-5: OpenAI embedding service initialized with dummy API key
  • SEC-API-6: Embedding generation failures silently swallowed
  • SEC-API-7: CSRF token not cryptographically tied to session
  • SEC-API-8: Rate limiter silently falls back to in-memory
  • SEC-API-9: AdminGuard uses workspace ownership as admin check
  • SEC-API-10: Auth route catch-all bypasses guards
  • SEC-API-11: Federation uses hardcoded default workspace default

Security - Web:

  • SEC-WEB-3: Missing CSRF token on multiple direct fetch() calls
  • SEC-WEB-4: Mock data shipped in production code paths
  • SEC-WEB-5: Silent auth session check failure
  • SEC-WEB-6: WebSocket token without TLS verification
  • SEC-WEB-7: KanbanBoard swallows task update errors
  • SEC-WEB-8: ActiveProjectsWidget silently drops non-OK responses
  • SEC-WEB-9: QuickCaptureWidget discards user data
  • SEC-WEB-10: Inconsistent API base URL for knowledge graph
  • SEC-WEB-11: Dual auth mechanisms (Cookie + Bearer)

Security - Orchestrator/Coordinator:

  • SEC-ORCH-7: Coordinator loops silently swallow all exceptions
  • SEC-ORCH-8: Queue file corrupted data silently discarded
  • SEC-ORCH-9: Environment variable injection via Docker container
  • SEC-ORCH-10: Docker container not properly isolated
  • SEC-ORCH-11: No rate limiting on orchestrator API
  • SEC-ORCH-12: No max concurrent agents enforcement
  • SEC-ORCH-13: YOLO mode bypasses all quality gates
  • SEC-ORCH-14: Parser prompt injection via issue body
  • SEC-ORCH-15: Valkey connection has no authentication by default

Code Quality - Critical/High:

  • CQ-ORCH-3: KEYS -> SCAN in Valkey
  • CQ-ORCH-6: N+1 query in listTasks/listAgents
  • CQ-ORCH-1: Memory leak - agent sessions never cleaned up
  • CQ-API-1: Memory leak - setTimeout not cleared in WebSocket
  • CQ-API-2: Memory leak - setInterval not cleared in runner jobs
  • CQ-WEB-1: Stale closure in useWebSocket hook
  • CQ-WEB-4: Stale messages in useChat hook

Acceptance Criteria

  • All high-priority findings remediated
  • Quality gates passing
  • No new regressions
## Findings (High Severity) **Security - API:** - SEC-API-5: OpenAI embedding service initialized with dummy API key - SEC-API-6: Embedding generation failures silently swallowed - SEC-API-7: CSRF token not cryptographically tied to session - SEC-API-8: Rate limiter silently falls back to in-memory - SEC-API-9: AdminGuard uses workspace ownership as admin check - SEC-API-10: Auth route catch-all bypasses guards - SEC-API-11: Federation uses hardcoded default workspace default **Security - Web:** - SEC-WEB-3: Missing CSRF token on multiple direct fetch() calls - SEC-WEB-4: Mock data shipped in production code paths - SEC-WEB-5: Silent auth session check failure - SEC-WEB-6: WebSocket token without TLS verification - SEC-WEB-7: KanbanBoard swallows task update errors - SEC-WEB-8: ActiveProjectsWidget silently drops non-OK responses - SEC-WEB-9: QuickCaptureWidget discards user data - SEC-WEB-10: Inconsistent API base URL for knowledge graph - SEC-WEB-11: Dual auth mechanisms (Cookie + Bearer) **Security - Orchestrator/Coordinator:** - SEC-ORCH-7: Coordinator loops silently swallow all exceptions - SEC-ORCH-8: Queue file corrupted data silently discarded - SEC-ORCH-9: Environment variable injection via Docker container - SEC-ORCH-10: Docker container not properly isolated - SEC-ORCH-11: No rate limiting on orchestrator API - SEC-ORCH-12: No max concurrent agents enforcement - SEC-ORCH-13: YOLO mode bypasses all quality gates - SEC-ORCH-14: Parser prompt injection via issue body - SEC-ORCH-15: Valkey connection has no authentication by default **Code Quality - Critical/High:** - CQ-ORCH-3: KEYS -> SCAN in Valkey - CQ-ORCH-6: N+1 query in listTasks/listAgents - CQ-ORCH-1: Memory leak - agent sessions never cleaned up - CQ-API-1: Memory leak - setTimeout not cleared in WebSocket - CQ-API-2: Memory leak - setInterval not cleared in runner jobs - CQ-WEB-1: Stale closure in useWebSocket hook - CQ-WEB-4: Stale messages in useChat hook ## Acceptance Criteria - [ ] All high-priority findings remediated - [ ] Quality gates passing - [ ] No new regressions
jason.woltje added the security label 2026-02-05 21:12:42 +00:00
jason.woltje added this to the M6-AgentOrchestration-Fixes milestone 2026-02-05 22:09:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label security
Milestone
No items
No Milestone M6-AgentOrchestration-Fixes
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?