mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Phase 4: Remaining Medium Findings #347

New Issue
Closed
opened 2026-02-06 19:08:52 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-06 19:08:52 +00:00
Owner
Copy Link

Phase 4: Medium Severity Remediation

Scope

Remaining medium-severity findings from codebase review 2026-02-05 not addressed in Phases 1-3.

Findings

Code Quality (High):

  • CQ-WEB-2: Missing Dependency in FilterBar useEffect
  • CQ-WEB-3: Race Condition in LinkAutocomplete
  • CQ-ORCH-5: TOCTOU Race in State Transitions

Security (Medium):

  • SEC-API-12: CurrentUser Decorator Returns undefined
  • SEC-API-17: data: URI Scheme Allowed in Markdown
  • SEC-API-19: BrainService Search Not Length-Validated
  • SEC-API-20: Brain Search Limit Parameter Allows Negatives
  • SEC-API-21: Semantic/Hybrid Search Body Not Validated
  • SEC-ORCH-20: Orchestrator Binds to 0.0.0.0
  • SEC-ORCH-22: Docker Image Tag Not Validated

Code Quality (Medium):

  • CQ-API-5: Race Condition in Throttler Fallback
  • CQ-API-7: N+1 Query in Knowledge Tag Lookup
  • CQ-ORCH-7: Docker Force Remove Loses Data
  • CQ-ORCH-9: Duplicate Validation Logic

Acceptance Criteria

  • All listed findings remediated
  • Quality gates passing (lint + typecheck + test)
  • No regressions
## Phase 4: Medium Severity Remediation ### Scope Remaining medium-severity findings from codebase review 2026-02-05 not addressed in Phases 1-3. ### Findings **Code Quality (High):** - CQ-WEB-2: Missing Dependency in FilterBar useEffect - CQ-WEB-3: Race Condition in LinkAutocomplete - CQ-ORCH-5: TOCTOU Race in State Transitions **Security (Medium):** - SEC-API-12: CurrentUser Decorator Returns undefined - SEC-API-17: data: URI Scheme Allowed in Markdown - SEC-API-19: BrainService Search Not Length-Validated - SEC-API-20: Brain Search Limit Parameter Allows Negatives - SEC-API-21: Semantic/Hybrid Search Body Not Validated - SEC-ORCH-20: Orchestrator Binds to 0.0.0.0 - SEC-ORCH-22: Docker Image Tag Not Validated **Code Quality (Medium):** - CQ-API-5: Race Condition in Throttler Fallback - CQ-API-7: N+1 Query in Knowledge Tag Lookup - CQ-ORCH-7: Docker Force Remove Loses Data - CQ-ORCH-9: Duplicate Validation Logic ### Acceptance Criteria - [ ] All listed findings remediated - [ ] Quality gates passing (lint + typecheck + test) - [ ] No regressions
jason.woltje added the security label 2026-02-06 19:08:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?