mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Phase 3: Coordinator Code Quality (Ruff, Mypy, Pip) #365

New Issue
Closed
opened 2026-02-12 18:33:53 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-02-12 18:33:53 +00:00
Owner
Copy Link

Findings

Ruff Check (20 errors, 9 auto-fixable)

  • UP035: Import Callable from collections.abc (1)
  • UP042: Use StrEnum instead of str+Enum (5)
  • E501: Line too long (5)
  • F401: Unused imports (4)
  • UP045: Use X | None instead of Optional (1)
  • I001: Import block unsorted (2)
  • F401: Unused imports in tests (2)

Mypy (1 error)

  • src/main.py:144: Incompatible type for add_exception_handler

Pip Audit (2 CVEs)

  • pip 24.0 → CVE-2025-8869, CVE-2026-1703 (fix: upgrade to pip >= 25.3)

Bandit (1 Medium)

  • B104: Hardcoded 0.0.0.0 bind address (acceptable for container, document)

Acceptance Criteria

  • All ruff check errors fixed
  • Mypy passes cleanly
  • pip upgraded in Dockerfile
  • Bandit medium finding documented/addressed
## Findings ### Ruff Check (20 errors, 9 auto-fixable) - UP035: Import Callable from collections.abc (1) - UP042: Use StrEnum instead of str+Enum (5) - E501: Line too long (5) - F401: Unused imports (4) - UP045: Use X | None instead of Optional (1) - I001: Import block unsorted (2) - F401: Unused imports in tests (2) ### Mypy (1 error) - src/main.py:144: Incompatible type for add_exception_handler ### Pip Audit (2 CVEs) - pip 24.0 → CVE-2025-8869, CVE-2026-1703 (fix: upgrade to pip >= 25.3) ### Bandit (1 Medium) - B104: Hardcoded 0.0.0.0 bind address (acceptable for container, document) ## Acceptance Criteria - [ ] All ruff check errors fixed - [ ] Mypy passes cleanly - [ ] pip upgraded in Dockerfile - [ ] Bandit medium finding documented/addressed
jason.woltje added this to the M11-CIPipeline (0.0.11) milestone 2026-02-12 18:33:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label
Milestone
No items
No Milestone M11-CIPipeline (0.0.11)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?