docs(records): Piece D build note, TOOLS.md review verbs, DEFERRED updates (#1508)

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
2026-09-27 10:07:51 -05:00
co-authored by Claude Opus 5.5
parent f539466fcb
commit 0550ab21cf
4 changed files with 66 additions and 10 deletions
+33
View File
@@ -3332,3 +3332,36 @@ queue suite passed 24 there and failed its 2 live checks, because the
export isn't the canonical root. That is a real limit of the recipe after
genesis, not a defect in row 10 (DEFERRED). In the canonical checkout the
queue suite passed 26/26 with the same files.
## 2026-09-27: Queue Piece D, reviews as issue comments (#1508, Darkwing)
f539466f lands row 12. `queue move ID in-review` posts the review request
as a Gitea comment as the acting seat, and `queue review record` reads
the verdicts back. Reviews stop being files in `docs/plans/reviews/`.
Filbert's round 1 (a2dc2302) found C1: on a comment round,
in-review→waiting-on-jason needed no approvals. The move now takes the
same approval and unresolved checks as in-review→done, and Filbert
corrected the plan table (293747cd). Round 2 (cf1d3fd0) approved it.
Filbert asked for n1 before the commit: four test lines that kill the
last surviving mutant, which counted an earlier round's approval. Filbert
checked those lines, and they didn't go back for another round.
`scripts/gitea-api.sh` now reads the raw per-seat token files, because
the files Jason ruled on aren't JSON (lead decisions 37 to 39). Rocko
round 1 (e896192f): curl ran on an empty config after a failed second
read. Round 2 (2096b0a3): an inherited exported `CFG` carried the token
into curl's environment. Darkwing fixed both, and also closed
`SHELLOPTS=allexport`. Sage's lead check passed: 12 dummy cases keep the
token in the config stream only, and removing `export -n` leaks it in
all 12.
Sage checked the manifest (b402fb38, 19 of 19 OK) after applying
build.patch 28d0790e and helper.patch 48edd46b at cdcedb27. On an index
export the suites passed: config 24, task 90, foundation 44, conductor
17, release 14, auth 15, discord 64, extension-package 18, queue 27
(live checks skipped outside the canonical root). Ledger tests passed
58/58. The canonical checkout's queue suite passed 29/29. Correction: the
first export run failed task 31 and release 3 because Docker had no
address pools left. Sage removed 12 empty leftover export networks, and
the rerun passed.