docs(records): Piece D build note, TOOLS.md review verbs, DEFERRED updates (#1508)

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
2026-09-27 10:07:51 -05:00
co-authored by Claude Opus 5.5
parent f539466fcb
commit 0550ab21cf
4 changed files with 66 additions and 10 deletions
+21 -8
View File
@@ -121,6 +121,10 @@ at every gate. Started 2026-09-12 during the control board MVP.
address pools have been fully subnetted". Sage removed its own five stale
networks. The dw-* ones are still there. Fix: the export recipe, or the
suites, removes the project network on exit. (2026-09-26)
2026-09-27: it happened again on the Piece D candidate (task 31 and
release 3 failures). Sage removed 12 leftover export networks from
other seats, each checked for zero attached containers first, and both
suites then passed. Still open.
- **Ledger T3 read: snapshot isolation has no test.** `readT3` runs every
query in one read transaction, but no test proves a write landing during
@@ -134,14 +138,18 @@ at every gate. Started 2026-09-12 during the control board MVP.
Sage asked the SetSpark lead to use a one-word role. The rule stays as
it is. (2026-09-26, #1506)
- **Queue suite fails its live checks outside the canonical checkout.**
Since genesis (3377b877), `test-queue.sh` runs `queue verify` and `render
--check` whenever HEAD holds `queue.json`. Both refuse in an index export
or review clone ("this checkout is /tmp/...; the queue's canonical root
is ..."), so the export recipe reports 24 passed, 2 failed. The canonical
checkout passes 26/26. Fix: skip the live checks, with a printed reason,
when the toplevel isn't the recorded `canonicalRoot`. Darkwing, with
row 12 or 13. (2026-09-27, #1508, lead decision 36)
- **Queue: an owner listed as a reviewer blocks the row.** `set reviewers`
and `assign` accept the row's owner as a reviewer. The owner can't record
a verdict on their own row, so the row can't leave review. That fails
closed. Fix: refuse the owner in both verbs. Filbert's n2 on Piece D r2
(cf1d3fd0). (2026-09-27, #1508)
- **Queue tests: one unexplained failure on a cold start.** Darkwing's
first run of the D candidate in a fresh clone gave 141 passed, 1 failed.
The failing test's name wasn't captured. 15 reruns passed 142/0,
sequential and parallel. Darkwing suspects a timing bound, most likely
the 300 ms deadline case in the transport test, which allows 4000 ms.
That isn't confirmed. Next time: capture the name, then fix it as its
own patch. (2026-09-27, #1508)
## Queue
@@ -158,3 +166,8 @@ Moved to `docs/plans/QUEUE.md` on 2026-09-13. This file holds only gaps.
- Combined concurrent test hangs (2026-09-14, #1509): closed on evidence from 3edb15eb. At default concurrency the union passed 406/406 three times on the R2 snapshot and 408/408 on the commit's index, where clean HEAD had hung four runs out of four. The inherited-intermittency entry from 2026-09-15 stays open until a later run shows it is the same cause.
- A nested `node --test` passes even when its tests fail (2026-09-26, #1508): closed. Queue A1 (34a72af9) clears NODE_TEST_CONTEXT on its own path. N13 fixes `test-foundation.sh` and `test-discord.sh`, each with a check that fails the suite if the clearing is lost. Darkwing wrote it (n13.patch 00868b2f) and Filbert approved it (e464be6c). Sage's grep on 2026-09-27 finds no other nested `node --test`: in scripts, only the two suites, `test-queue.sh` and `queue-commit.sh`, and in JS, only the queue test that covers the fix.
- SetSpark service accepted any string as a decision approver (2026-09-26, #1509): closed. Fixed in shared-signals cc74d92 (Rocko approved R2, lead decision 24). The operations seat (T3 12fe8cda) deployed it to VM 1022 at 00:23Z on 2026-09-27. The running `service.py` hash matches cc74d92, and `/healthz` returns 200 inside the network and through the public tunnel. The read-only README survey found one row breaking the rule (DEC-009, Proposed, version 1), one open request that isn't ready (DEC-009's), and no Accepted decision with more than 16 approvers. No rows changed. DEC-009 stays as stored (lead decisions 21 and 28). The service now refuses approvals on it, so nothing can go wrong silently. Side effect: `up -d` also recreated caddy, about 20 s of edge downtime for all hosts. That is for the shared-signals deploy procedure to fix, not Mosaic.
- Queue suite failed its live checks outside the canonical checkout
(2026-09-27, #1508): closed by Piece D, f539466f. `test-queue.sh` now
skips `verify` and `render --check` with a printed reason when the
toplevel isn't the recorded `canonicalRoot`. An index export passed
27/0, and the canonical checkout 29/0.