queue: revs 2079-2082: row 176 round 1 in-review on candidate b05cbf08 (Rocko 2079), the request failed without a token as expected (Rocko 2080), posted as jarvis, comment 29305 (Sage 2081, 2082)

This commit is contained in:
jason.woltje committed 2026-10-19 19:37:21 -05:00
1 parent 60d6e6755e
commit 0a478dfc36
2 files changed
+151 -6

No files matched your search

+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 2078 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 2082 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -212,7 +212,7 @@ Generated from `docs/plans/queue.json` revision 2078 by `queue render`. Do not e
| 173 | A Seen click that waited out a Board read posts the intent the person clicked, not a toggle of the fresh row (#1671, mos-0861 A1) | sage; reviewers darkwing | #1671 | queued | 66 done | darkwing approves on #1671 naming the candidate manifest; webui and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-19_seen-click-intent.md` § Brief: a Seen click that waited out a Board read can undo another viewer's mark | — |
| 174 | Skill reads keep a leading BOM and report fs errors inside a skill as skill-refused (#1672, row 64 N2/N3, mos-0863 D4) | sage; reviewers darkwing | #1672 | queued | 173 done | darkwing approves on #1672 naming the candidate manifest; harness, cli and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-19_skill-read-bom-errors.md` § Brief: skill reads strip a leading BOM and report some fs errors as launch-failed | — |
| 175 | Tester reads and writes for the test system: seven reads, seven writes recorded as tester (plugins, instances, routes set, name, talk without the prefix, project create, project init in the data root's project area); nine items stay human-only (#1673, Q173, mos-0870 N2, mos-0872) | dewey; reviewers filbert | #1673 | done | — | Filbert approves the candidate manifest; bus, cli, plugins, project, business and webui suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_tester-read-checks.md` § Brief: tester reads and writes for the test system | Landed as 98d29769e on 1d81c54ff (temp index from build.patch c9e545e5, manifest 2e30f2a1 25/25 on the tree; patch-id c1cf0ed66006 equals 9e74925c2..989699f7c). Sage gate on 716ddcf1e plus the patch: 15 package suites 2592 pass, 10 scripts/test-*.sh 422 pass, 0 fail. Filbert r3 approve 29279. F1 (TOOLS.md:452 'Until row 175 lands') is a doc-only follow-up. |
| 176 | Console tester listener on 127.0.0.1 (--tester-port, 7333 in the window), TESTER_CLI bus calls, only the row 175 tester writes; 7332 refuses x-mosaic-tester for every Host; tester reads credentials, routes, project.files, project.file (#1674, Q173 N3, mos-0872, mos-0874) | rocko; reviewers dewey | #1674 | in-progress | 169 done, 175 done | Dewey approves the candidate manifest; bus, cli, webui and business suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_console-tester-listener.md` § Brief: a loopback-only Console listener for the tester | Sage ruling (sage-1111) on Rocko's brief conflict: brief line 60 says tester-off and tester-required map to 403 in busStatus, but packages/webui/src/bus.mjs is a row 164 pin (Untouched). Resolution: serve.mjs imports busStatus as coreBusStatus and wraps it, mapping just those two codes to 403; bus.mjs unchanged. Test 7 asserts the 403. |
| 176 | Console tester listener on 127.0.0.1 (--tester-port, 7333 in the window), TESTER_CLI bus calls, only the row 175 tester writes; 7332 refuses x-mosaic-tester for every Host; tester reads credentials, routes, project.files, project.file (#1674, Q173 N3, mos-0872, mos-0874) | rocko; reviewers dewey | #1674 | in-review, round 1, request posted | 169 done, 175 done | Dewey approves the candidate manifest; bus, cli, webui and business suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_console-tester-listener.md` § Brief: a loopback-only Console listener for the tester | Sage ruling (sage-1111) on Rocko's brief conflict: brief line 60 says tester-off and tester-required map to 403 in busStatus, but packages/webui/src/bus.mjs is a row 164 pin (Untouched). Resolution: serve.mjs imports busStatus as coreBusStatus and wraps it, mapping just those two codes to 403; bus.mjs unchanged. Test 7 asserts the 403. |
| 177 | Tester threads: create, list, open, send and read tester-owned threads; owner and from_role tester, replies to tester, never the human's inbox; design first, Sage approves before code (#1675, Q173) | dewey; reviewers filbert | #1675 | queued | 176 done | Filbert approves the candidate manifest; bus, webui and conversation suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_tester-threads.md` § Brief: tester threads (scoping) | — |
| 178 | Console proxy proof: --proof-header and --proof-file, a signed-in request without Traefik's secret header gets 401; partial fix after the window rows, same-uid limit recorded, uid separation is Jason's on #385; console-proof.token slot, ops-01 middleware (#1676, Vikunja #385, mos-0874, mos-0878) | sage | #1676 | queued | 169 done, 175 done, 176 done | Reviewer approves the candidate manifest; webui and cli suites and every scripts/test-*.sh green on Sage's gate; nothing live changes at landing (sage) | `docs/plans/2026-10-19_console-proxy-proof.md` § Brief: the Console checks that a signed-in request came through Traefik | — |
| 179 | docs/TOOLS.md follow-ups F1-F3 from the row 169 review | darkwing; reviewers dewey | #1677 | done | 169 done | Dewey approves the candidate manifest; no suite when no test reads docs/TOOLS.md (decision 137) (sage) | `docs/plans/2026-10-19_tools-md-169-followups.md` § Brief: docs/TOOLS.md follow-ups from the row 169 review | Landed 9e74925c2 on ce5807989 (Sage, temp index). Candidate manifest 2b161c51 approved by Dewey (29271); landed docs/TOOLS.md sha256 67acbed1 matches it. patch-id 35e385ff93cb matches Darkwing's packet. Doc-only, no suite: only stack-release.test.mjs:428 names TOOLS.md, in an expected message string (decision 137). |
+149 -4
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 2078,
"revision": 2082,
"rows": [
{
"id": 1,
@@ -18386,7 +18386,7 @@
"closes": [
1674
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -18410,7 +18410,55 @@
"reviewers": [
"dewey"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-176-inreview-r1",
"by": "rocko",
"at": "2026-10-20T00:32:59.471Z",
"issue": 1674,
"candidate": {
"kind": "manifest",
"digest": "b05cbf08c769980f4f578ca6b438d9b5c394ffa81ebe4b8b89645b891cd3c84c",
"text": "7b1263bb644b0b50bd3806dcc330f40dae9fe27d20c2e9a3c1fede29077c7115 docs/TOOLS.md\nc8a88112a71e1b7356a106ede7f9f799e0d0841eb74cd5a2dbfb2a9a09fd07b3 packages/bus/src/broker.mjs\n38ad25dc103d6771901be8475f5611c16a7d69595a404949b1703a7cec86625c packages/bus/tests/tester-writes.test.mjs\n68116389b6f5807a8d1c6b3ab8d32910d864281ec9accb7b1451603ea50589eb packages/bus/tests/tester.test.mjs\nf601f99e8e274541f35be88164680eb1278293f9213809bc618cc80cf812dcf8 packages/cli/tests/stack-release.test.mjs\nc0f5501c7fbe6d46952004e75040421f216c43f50625a2f0a00750a8c199493a packages/webui/README.md\n3362d5be9a70da123cd1ded1d9a1ab37a2d50ff1533310dae4da6ecdb2e3048c packages/webui/src/cli.mjs\n55c175cacb92c371b29e7922340dbf9b65ca96c23a979f9866130c1ae219be96 packages/webui/src/public/bus.js\n98c18559d43f0531e31326d8157e6f721186379d6e9e0733c0a331e02ac70ddd packages/webui/src/serve.mjs\n8a4fa7cf9b361e7d2edbfd97041f390c1bc1d15a4c7d24795c8a13f68f69dabc packages/webui/tests/service.test.mjs\n30f7289be29a206ff26f43429e7ed3385f199cfdc271d362ecab6e556a16c879 packages/webui/tests/tester-browser.test.mjs\n7429e83a9480556daf957134d7be37aae12408432720f9453c2981aa16895391 packages/webui/tests/tester-cli.test.mjs\nfdb70312894c022209fc3f325647f6305bd2c3892961a817db5d9b13fb60e3ef packages/webui/tests/tester-fixture.mjs\n625c3ece67fccd5abc717108ce1a626a59819d2e712b2384648e8829f3b1ad3c packages/webui/tests/tester-listener.test.mjs\n2fec94e563f2d3094abcdf3f8749c37deb5a5ef75f033f9309aef00a72284291 scripts/stack-release.sh\nead18147c71a0d71c831da96806e2bb56ca1ffe897b133ac32ee33a83ff4ab46 scripts/webui-service.sh\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-176-inreview-r1",
"by": "rocko",
"at": "2026-10-20T00:32:59.471Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
},
{
"op": "sage-176-review-1b",
"by": "sage",
"at": "2026-10-20T00:33:38.579Z",
"state": "posted",
"comment": 29305,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 29305,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-176-start"
@@ -18418,7 +18466,7 @@
"note": "Sage ruling (sage-1111) on Rocko's brief conflict: brief line 60 says tester-off and tester-required map to 403 in busStatus, but packages/webui/src/bus.mjs is a row 164 pin (Untouched). Resolution: serve.mjs imports busStatus as coreBusStatus and wraps it, mapping just those two codes to 403; bus.mjs unchanged. Test 7 asserts the 403.",
"blockedReason": null,
"createdAt": "2026-10-19T22:32:30.622Z",
"updatedAt": "2026-10-20T00:10:43.613Z",
"updatedAt": "2026-10-20T00:33:54.447Z",
"updatedBy": "sage"
},
{
@@ -73522,6 +73570,103 @@
"receipt": "ok sage-176-busstatus rev 2078 row 176 note"
},
"viewSha": "714eced213d7693c2c8090d0e0b1ae511f20a6004dfed2e31bd2fff41ecbe21b"
},
{
"rev": 2079,
"op": "rocko-176-inreview-r1",
"verb": "move",
"args": {
"id": 176,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/queue-176/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "rocko",
"at": "2026-10-20T00:32:59.471Z",
"semantics": 2,
"result": {
"row": 176,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1674,
"candidate": {
"kind": "manifest",
"digest": "b05cbf08c769980f4f578ca6b438d9b5c394ffa81ebe4b8b89645b891cd3c84c",
"text": "7b1263bb644b0b50bd3806dcc330f40dae9fe27d20c2e9a3c1fede29077c7115 docs/TOOLS.md\nc8a88112a71e1b7356a106ede7f9f799e0d0841eb74cd5a2dbfb2a9a09fd07b3 packages/bus/src/broker.mjs\n38ad25dc103d6771901be8475f5611c16a7d69595a404949b1703a7cec86625c packages/bus/tests/tester-writes.test.mjs\n68116389b6f5807a8d1c6b3ab8d32910d864281ec9accb7b1451603ea50589eb packages/bus/tests/tester.test.mjs\nf601f99e8e274541f35be88164680eb1278293f9213809bc618cc80cf812dcf8 packages/cli/tests/stack-release.test.mjs\nc0f5501c7fbe6d46952004e75040421f216c43f50625a2f0a00750a8c199493a packages/webui/README.md\n3362d5be9a70da123cd1ded1d9a1ab37a2d50ff1533310dae4da6ecdb2e3048c packages/webui/src/cli.mjs\n55c175cacb92c371b29e7922340dbf9b65ca96c23a979f9866130c1ae219be96 packages/webui/src/public/bus.js\n98c18559d43f0531e31326d8157e6f721186379d6e9e0733c0a331e02ac70ddd packages/webui/src/serve.mjs\n8a4fa7cf9b361e7d2edbfd97041f390c1bc1d15a4c7d24795c8a13f68f69dabc packages/webui/tests/service.test.mjs\n30f7289be29a206ff26f43429e7ed3385f199cfdc271d362ecab6e556a16c879 packages/webui/tests/tester-browser.test.mjs\n7429e83a9480556daf957134d7be37aae12408432720f9453c2981aa16895391 packages/webui/tests/tester-cli.test.mjs\nfdb70312894c022209fc3f325647f6305bd2c3892961a817db5d9b13fb60e3ef packages/webui/tests/tester-fixture.mjs\n625c3ece67fccd5abc717108ce1a626a59819d2e712b2384648e8829f3b1ad3c packages/webui/tests/tester-listener.test.mjs\n2fec94e563f2d3094abcdf3f8749c37deb5a5ef75f033f9309aef00a72284291 scripts/stack-release.sh\nead18147c71a0d71c831da96806e2bb56ca1ffe897b133ac32ee33a83ff4ab46 scripts/webui-service.sh\n"
},
"receipt": "ok rocko-176-inreview-r1 rev 2079 row 176 in-progress→in-review round 1 on #1674; request rocko-176-inreview-r1 requesting"
},
"viewSha": "5eea7cff11bec2590bb04f842c892d5e5ff1a813c4e3e7819eb11aa3a0fbd4d6"
},
{
"rev": 2080,
"op": "rocko-176-inreview-r1.outcome",
"verb": "review-outcome",
"args": {
"id": 176,
"attempt": "rocko-176-inreview-r1",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-20T00:33:14.257Z",
"semantics": 2,
"result": {
"row": 176,
"round": 1,
"attempt": "rocko-176-inreview-r1",
"state": "failed",
"receipt": "ok rocko-176-inreview-r1.outcome rev 2080 row 176 round 1 request rocko-176-inreview-r1 failed"
},
"viewSha": "10a30e9d4519e4a8da206e5441b49af0cf0e8a64d9b0e7b02c00cc8088ef2c45"
},
{
"rev": 2081,
"op": "sage-176-review-1b",
"verb": "review-request",
"args": {
"id": 176
},
"by": "sage",
"at": "2026-10-20T00:33:38.579Z",
"semantics": 2,
"result": {
"row": 176,
"round": 1,
"attempt": "sage-176-review-1b",
"state": "requesting",
"receipt": "ok sage-176-review-1b rev 2081 row 176 round 1 request sage-176-review-1b requesting"
},
"viewSha": "a7f12e3dd4541c274d61f18350e4cbecd0a9fcb8cd9307b62a415425e923fc00"
},
{
"rev": 2082,
"op": "sage-176-review-1b.outcome",
"verb": "review-outcome",
"args": {
"id": 176,
"attempt": "sage-176-review-1b",
"outcome": "posted",
"status": 201,
"comment": 29305,
"detail": "created"
},
"by": "sage",
"at": "2026-10-20T00:33:54.447Z",
"semantics": 2,
"result": {
"row": 176,
"round": 1,
"attempt": "sage-176-review-1b",
"state": "posted",
"receipt": "ok sage-176-review-1b.outcome rev 2082 row 176 round 1 request sage-176-review-1b posted comment 29305"
},
"viewSha": "244dae8eef5df63fb71c9fcc4fb3e546604c391494210a282f38a367468f223a"
}
]
}