docs(guides): slice 1 identities round 2; lead decision 58

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-04 22:10:32 -05:00
parent 4d51c1304d
commit 104cf4f3f0
4 changed files with 93 additions and 42 deletions
@@ -952,3 +952,19 @@ which stay with him. Each item names who decided it and what happened.
    - The broker, not a trigger, links `action.*` and `review.*` events
      to a task, because the kind alone doesn't say when one is about a
      task.
+58. **Row SR round 1 rulings (2026-10-04).** Source: Darkwing's review,
+    #1517 comment 26709, record `agents/darkwing/work/slice1-sr-review-r1-2026-10-04.md`.
+    Every change requested is taken into the guide.
+    - Bot names carry the business id on both services, because usernames
+      are global to each instance: Gitea `<business>-<role>-bot`, Vikunja
+      `bot-<business>-<role>`. PRD draft 0.4's REQ-CRED-1 wording changes
+      to match. That is a naming correction inside a draft, not a new
+      requirement.
+    - Reviewer-bot's Gitea approvals are advisory. It joins no approvals
+      allowlist, merges stay Jason's, and the verdict that gates a row
+      lives in the queue and the bus.
+    - The guide says plainly that reviewer-bot's token can open a pull
+      request through an AGit push. That's acceptable only because the
+      broker holds the token and gives the reviewer no push action.
+    - Slice 1 needs no Vikunja labels. The business file example comes
+      from row S1, and the template file waits for it.