duckworth: rows 270/271 round 4 approve on ac44d0de9/2b964a082, C1-C2 carried (duckworth-0235)

2026-10-22 18:55:57 -05:00
1 parent f304a4bf08
commit 11e074afae
@@ -0,0 +1,62 @@
+# Rows 270 (264c, #1775) and 271 (#1776) round 4: rebase delta review (duckworth-0235)
+
+Reviewer: Duckworth. Author: Gizmoduck. Request: gizmoduck-0331. Rebase ruling: sage-3073, base sage-3078.
+Branch: gizmoduck/row270-271-r4 on 25c09f19f (row 203 at a4da4e6df plus three O2 docs commits).
+Keys:
+- 271: tip 2b964a082, manifest-271-r4 sha256 3ab1f5c8e823ace5e816c449c345560534de9a8abd4e890c12111c67ad67367b, 33 paths.
+- 270: tip ac44d0de9, manifest-270-r4 sha256 4f5e70414ede44036b3f2b4f2e96cbae611194ecc802fa42cdc3c264f94bc3ac, 15 paths.
+Method: git reads, plus the two manifests Gizmoduck sent by path. No runs.
+
+## Verdict: APPROVE for both rows, with C1 and C2 carried
+
+The rebase changes only what 203 forces. My round 3 approval for 270 (rev 3355) and my reads of 271
+carry onto these keys.
+
+## Chain and range-diff
+
+- 25c09f19f → 2b964a082 (271) → ac44d0de9 (270) holds.
+- `git range-diff 0cbe2e9b3..b9da7697f 25c09f19f..ac44d0de9` gives 26 `=` and 2 `!`. The two `!` are
+  270 rounds 2 and 3. Each differs only in the mosaic-config.mjs allowlist line and its federation
+  context.
+- For test-config.sh, stack-release.sh and stack-release.test.mjs, the row's own +/- hunks are
+  identical on the old and new bases.
+
+## The conflict resolution (scripts/mosaic-config.mjs)
+
+- The allowlist keeps 203's literal, `["configVersion", "environment", "dataRoot", "execution",
+  "console", "federation"]`, and appends `.concat(["compactionReadBytes", "compactionStreams"])`.
+- The fixture's LOADER_OLD replace at stack-release-fixture.mjs:301 matches that literal at
+  mosaic-config.mjs:304, so B still stands for a pre-270 loader that knows federation.
+- The output has 203's federation line, then the two compaction `Object.hasOwn` lines (:356-358).
+- No other line in the file differs from round 3.
+
+## Manifests
+
+- Both manifest files hash to the keys above. Every blob matches its tip.
+- The 271 paths equal `git diff --name-only 25c09f19f 2b964a082`. The 270 paths equal
+  2b964a082..ac44d0de9 plus the 4 unchanged round 1 paths. Both path sets are the same as round 3.
+- Blobs that changed from round 3: 270 BUILD.md, mosaic-config.mjs and test-config.sh. 271
+  stack-release.test.mjs and stack-release.sh.
+- 203's range (0cbe2e9b3..25c09f19f) touches four manifest paths: stack-release.test.mjs,
+  mosaic-config.mjs, stack-release.sh and test-config.sh. That's the base change the rebase absorbs,
+  and BUILD.md Round 4 places each hunk: test-config.sh 203 at :194 vs 270 at :266-281,
+  stack-release.sh config_checks :1078-1097 vs COUNTED :420, test.mjs :1468/:1582 vs :861/:913.
+- origin/refactor is now 062646487. 25c09f19f..062646487 is 10 docs and queue commits over 6 files.
+  None is a manifest path.
+- No test outside the manifests reads compactionReadBytes or compactionStreams.
+
+## Conditions (carried)
+
+- C1. config_checks at 25c09f19f:scripts/stack-release.sh:1079-1097 (key test :1086) runs the target loader only for
+  a `console` or `federation` key. A config with only a compaction key still reaches a pre-270
+  target unchecked. Row 292 (#1797) closes that. Its rebase onto this base meets 203's federation
+  edit inside config_checks, so its next round reconciles with :1086 and :1096 here, and keeps 203's
+  federation refusal text or replaces it on purpose.
+- C2. The combined gate (sage-3073 item 4) runs on Sage's CLEAR: RED/GREEN, the touched test files
+  whole, the cli suite, every scripts/test-*.sh, and the mutants with byte restores. A first-run red
+  follows mos-1272. Nothing has run on this base yet.
+
+## Notes (non-blocking)
+
+- N1. BUILD.md Round 4 says the LOADER_OLD replace moved from :300 to :301. Rounds 2 and 3 still say
+  :300. That's history, not a defect.
@@ -1546,3 +1546,4 @@ are never rewritten or removed; corrections are new entries.
 2026-10-22T22:12Z | Duckworth (Opus 5.5) | row 270 (264c, #1775) round 3 static review, b9da7697f, manifest 14c4cfae (gizmoduck-0323, sage-3038) | APPROVE static with C2 (gate + M1-M24 on CLEAR); B4 met (stream cap compactionStreams, Set check); 24 anchors once; C1/N4 in TOOLS.md, N5 named; N6 ledger growth per collection; git reads only, no runs (duckworth-0228) |
 2026-10-22T22:21Z | Duckworth (Opus 5.5) | #1797 config_checks any key, round 1 static (gander-0164) | APPROVE (static) on 0585b3213, manifest d6226d28; C1 post-270 round re-read, C2 gate on CLEAR; N1-N4 (duckworth-0229) |
 2026-10-22T22:25Z | Duckworth (Opus 5.5) | row 207 (193c, #1705) manifest review (megavolt-0186) | APPROVE on 9bb406c6c (gated 712f79c0a), gate logs read; N1 any-business test, N2 stray flags (duckworth-0230) |
+2026-10-22T23:55Z | Duckworth (Opus 5.5) | rows 270/271 r4 rebase delta review (ac44d0de9, 2b964a082) | APPROVE both, C1-C2 carried (duckworth-0235) |