row 210 (#1707): rebase onto row 199's tip 07141966e (megavolt-0027), BUILD.md base and rerun counts (17 files, 134/0), manifest for the two cli files (Gizmoduck, round 1)

2026-10-20 16:17:56 -05:00
parent c7958740a9
commit 12ffe0b568
2 changed files with 13 additions and 10 deletions
@@ -5,9 +5,12 @@ Gizmoduck, 2026-10-20. Reviewer Duckworth, gate owner Sage.
 - Brief: `docs/plans/2026-10-20_host-credentials.md` at 9db578ff5 (on `refactor`, not under this base).
 - Design: `agents/gizmoduck/work/queue-210/DESIGN.md` r3, e021dfa26 on `gizmoduck/row210`, approved by
  Duckworth (duckworth-0043, C1 met in duckworth-0044) and Sage (sage-1468, sage-1472).
- Base: row 199's candidate addee664a on `megavolt/row199`, as sage-1472 said. 968fdebbe carries the r3
-  design onto it. Branch `gizmoduck/row210-on-199`. It lands after 199, and the rebase onto 199's landing
-  goes to a new branch name.
+- Base: row 199's candidate 07141966e on `megavolt/row199` (megavolt-0027), as sage-1472 and sage-1493
+  said. 50d4102f8 carries the r3 design onto it. Branch `gizmoduck/row210-on-199-r2`. It lands after 199,
+  and the rebase onto 199's landing goes to a new branch name.
+- Rebase: round 1 was built on addee664a (8ec923585 on `gizmoduck/row210-on-199`). 199's tip moved to
+  07141966e, which touches `packages/cli/src/credentials.mjs` and its test, both also changed here. The
+  rebase applied with no conflict, and every touched test file was rerun singly on the new base.
 - Candidate: the commit that adds this file. `candidate-manifest.sha256` lists the code and test files.
 - Scope (sage-1468): the `host.run` broker op, the grant check, the executor and the receipts, over
  `broker.sock`. No `packages/harness` change. The `host_run` tool is Sage's follow-up row.
@@ -86,7 +89,7 @@ the files restored at the end, and exits 1 on any survivor or missed anchor.

 ## Checks

-Single files, no slot. 17 files, 133 pass, 0 fail (awk sum over the singles log):
+Single files on 07141966e, no slot. 17 files, 134 pass, 0 fail (awk sum over the singles log):

 | File | Pass |
 |------|------|
@@ -95,7 +98,7 @@ Single files, no slot. 17 files, 133 pass, 0 fail (awk sum over the singles log)
 | bus hard-waits, credentials, credential-store, credential-verbs, credential-status | 13, 5, 11, 2, 4 |
 | bus business, web, approval-binding, decisions, single-use | 1, 19, 6, 7, 12 |
 | bus publish, transport, instances-verb | 12, 5, 2 |
-| cli credentials | 4 |
+| cli credentials (199's new rotate test included) | 5 |

 - After each host-run run, no sshd, ssh or ssh-agent of mine is left and no `h-` dir is under the run roots.
 - Hash pins: the only 64-hex pin in a test is thread-migration.test.mjs:46 (a DDL hash), which none of these
@@ -103,10 +106,10 @@ Single files, no slot. 17 files, 133 pass, 0 fail (awk sum over the singles log)
 - `node tools/unslop-hook/unslop-check.js` is clean on this file.
 - Not run: the bus, business and cli suites, `scripts/test-*.sh` and the mutant batch. All need Sage's slot.

-## Follow-up for 199
+## Follow-up for 199, closed

-CLI `ISSUED` lacks `rotation-due`, so `credentials rotate` on a key in that state refuses. It applies to
-gitea keys as much as to host keys. It's 199's, not changed here.
+CLI `ISSUED` lacked `rotation-due`, so `credentials rotate` on a key in that state refused. Megavolt fixed it
+inside 199 at 07141966e (megavolt-0027), which is this round's base.

 ## Boundaries kept

@@ -16,5 +16,5 @@ ff927da3cf22fbacc9ace77b2e8b803bffc2953fb58cf7ab4e5f6f6493732996  packages/bus/s
 2f0f081d12042ee7ebfaa38770903ec8de297f3393f90dfd236fcf0a4a004d07  packages/bus/tests/hard-waits.test.mjs
 3ed86692fda522744f601eac1095bb3762bdd88b843e1991f72df94748b28a5e  packages/bus/tests/host-run.test.mjs
 be4e1eb88b689e8e4f859de75218af151feae8dce2c1409b726cb9c3dcd5ffe9  packages/bus/tests/spec-fixtures.mjs
-61559fb7b331edd06c585792cbd1e57719b460d0c43c319a9640d78adf514a5f  packages/cli/src/credentials.mjs
-c8053215f9dc3e56f3f79266052a439d4e92ec1b3263cfdc9fa55cdb52a52633  packages/cli/tests/credentials.test.mjs
+19755f7bb002d8455990c5dc7c458e64aeb95252ec7231a2ed2fd9c638fcb511  packages/cli/src/credentials.mjs
+152a3e57f7241db45bf8262fbf86ee029cf3b98f0d75503990abd46ac151a4b2  packages/cli/tests/credentials.test.mjs