mosaicstack/stack
25
0
Fork 1
Code Issues 360 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: rev 580, row 60 round 2 approve by dewey, comment 27558 (#1549) (dewey)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-11 19:19:06 -05:00
co-authored by Claude Opus 5.5
parent 179129c5f4
commit 1392fb23c8
2 changed files with 127 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 579 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 582 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -115,7 +115,7 @@ Generated from `docs/plans/queue.json` revision 579 by `queue render`. Do not ed
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-progress | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. |
| 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | in-review, round 1, request posted | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | in-progress | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | in-review, round 1, request failed | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
| 80 | Bus: list messages stranded by a holder change (row 59 review Note B) | darkwing; reviewers filbert | #1574 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | 59 done | filbert approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_bus-stranded-delivery.md` § Show messages stranded by a holder change | — |
| 81 | Console shows the reply to a web send | dewey; reviewers darkwing | #1575 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94); also after row 59 (Darkwing), which edits broker.mjs reads (lead decision 97) | 76 done | darkwing approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-reply-view.md` § Show replies to a message without receiving them | — |
docs/plans/queue.json
+125 -7
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 579,
"revision": 582,
"rows": [
{
"id": 1,
@@ -4671,7 +4671,16 @@
}
],
"duplicateRisk": false,
"receipts": []
"receipts": [
{
"reviewer": "dewey",
"op": "dewey-r60-verdict-2",
"at": "2026-10-12T00:18:08.425Z",
"verdict": "approve",
"comment": 27558,
"candidate": "13541657c830ed59281f101fc3566924454fd96d1be01df844100544b10cbf93"
}
]
}
]
},
@@ -4682,8 +4691,8 @@
"note": "Re-round after row 58 (aaf87213): digest check, the serve.mjs merge with row 74's preview checks, and Filbert's Q2, the missing decisions README row, folded in (Sage, on Darkwing's 27531 recommendation). Dewey's README N1 too.",
"blockedReason": null,
"createdAt": "2026-10-10T16:36:18.951Z",
"updatedAt": "2026-10-12T00:12:51.204Z",
"updatedBy": "filbert"
"updatedAt": "2026-10-12T00:18:08.425Z",
"updatedBy": "dewey"
},
{
"id": 61,
@@ -5959,7 +5968,7 @@
"closes": [
1573
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -5979,7 +5988,41 @@
"reviewers": [
"dewey"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-79-review-1",
"by": "rocko",
"at": "2026-10-12T00:18:10.819Z",
"issue": 1573,
"candidate": {
"kind": "manifest",
"digest": "16b12387dce8d21f5cc5311b9fc44e9692867b983c4f561f779610cc61e2b349",
"text": "8c9b45ad7bad35832a6a7f101fb1b21b07f8f95dbbc33216eab4bfc98fc5fc8c agents/rocko/work/queue-79/mutants.sh\n4e16bb3470adbfdd47ab7bcf1222baea01f8880895e8399b0cd398cfbeb8cab2 packages/business/README.md\nc704e4bdf2d941198de041475c49973add743ea66fa60081fd36758b498dc2c3 packages/harness/tests/tools.test.mjs\n3feefaa95a6864b2fda00cd2ca235e03989b3be0af1d3415f5f597c83d2a632f packages/tasks/live/run.mjs\nd2382d780c5532562af1a35a51e199a83ed911b18ca90dcbbc7540a7b14dc70a packages/tasks/README.md\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-79-review-1",
"by": "rocko",
"at": "2026-10-12T00:18:10.819Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-79-start"
@@ -5987,7 +6030,7 @@
"note": "Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate.",
"blockedReason": null,
"createdAt": "2026-10-11T23:20:20.328Z",
"updatedAt": "2026-10-12T00:09:56.930Z",
"updatedAt": "2026-10-12T00:18:12.937Z",
"updatedBy": "rocko"
},
{
@@ -22132,6 +22175,81 @@
"receipt": "ok filbert-60-review-r2-20261012.outcome rev 579 row 60 round 2 request filbert-60-review-r2-20261012 posted comment 27553"
},
"viewSha": "0ef5b6048b959e39baf8ecfbcb42a0d3ce46c069418951d1e8b15a3efd7c0d9c"
},
{
"rev": 580,
"op": "dewey-r60-verdict-2",
"verb": "review-record",
"args": {
"id": 60,
"verdict": "approve",
"comment": 27558,
"candidate": "13541657c830ed59281f101fc3566924454fd96d1be01df844100544b10cbf93"
},
"by": "dewey",
"at": "2026-10-12T00:18:08.425Z",
"semantics": 2,
"result": {
"row": 60,
"round": 2,
"verdict": "approve",
"receipt": "ok dewey-r60-verdict-2 rev 580 row 60 round 2 approve by dewey (comment 27558)"
},
"viewSha": "b2a47127e8f75b3a565d61f4901163e6229d62d7d57764d02513c099437573f2"
},
{
"rev": 581,
"op": "rocko-79-review-1",
"verb": "move",
"args": {
"id": 79,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/queue-79/candidate-manifest.sha256",
"evidence": null,
"issue": 1573
},
"by": "rocko",
"at": "2026-10-12T00:18:10.819Z",
"semantics": 2,
"result": {
"row": 79,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1573,
"candidate": {
"kind": "manifest",
"digest": "16b12387dce8d21f5cc5311b9fc44e9692867b983c4f561f779610cc61e2b349",
"text": "8c9b45ad7bad35832a6a7f101fb1b21b07f8f95dbbc33216eab4bfc98fc5fc8c agents/rocko/work/queue-79/mutants.sh\n4e16bb3470adbfdd47ab7bcf1222baea01f8880895e8399b0cd398cfbeb8cab2 packages/business/README.md\nc704e4bdf2d941198de041475c49973add743ea66fa60081fd36758b498dc2c3 packages/harness/tests/tools.test.mjs\n3feefaa95a6864b2fda00cd2ca235e03989b3be0af1d3415f5f597c83d2a632f packages/tasks/live/run.mjs\nd2382d780c5532562af1a35a51e199a83ed911b18ca90dcbbc7540a7b14dc70a packages/tasks/README.md\n"
},
"receipt": "ok rocko-79-review-1 rev 581 row 79 in-progress→in-review round 1 on #1573; request rocko-79-review-1 requesting"
},
"viewSha": "7ffa49073f4f1dc2ad1679e55712ec71573226d61f4e63cd3aab06485c69c6ef"
},
{
"rev": 582,
"op": "rocko-79-review-1.outcome",
"verb": "review-outcome",
"args": {
"id": 79,
"attempt": "rocko-79-review-1",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-12T00:18:12.937Z",
"semantics": 2,
"result": {
"row": 79,
"round": 1,
"attempt": "rocko-79-review-1",
"state": "failed",
"receipt": "ok rocko-79-review-1.outcome rev 582 row 79 round 1 request rocko-79-review-1 failed"
},
"viewSha": "b62f8c58459ea7c358cc72ef2506cc3a679251296167e0cffdd209d3351bc4bf"
}
]
}