mosaicstack/stack
25
0
Fork 1
Code Issues 365 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

logs: Rocko row 94 round 2 rebase and gate (#1588)

Browse Source
This commit is contained in:
jason.woltje
2026-10-12 19:07:13 -05:00
parent 4f85812d38
commit 18674ab0f3
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
BUILD-LOG.md
+8
View File
@@ -4482,3 +4482,11 @@ Before (c047d028): `task_create` took any string shaped like a requirement id, a
After (e918a915): Dewey's round 2 candidate, manifest 95611274, 21 paths under `packages/tasks/`, `packages/bus/`, `packages/harness/` and `packages/seat/`, plus `roles/pm.md`. The approved PRD's 24 ids live in `packages/tasks/requirements.json`. `task.create` refuses an id outside them with `unknown-requirement`, and sessions that hold `task.create` get a `list_requirements` tool. Round 2 rebased on row 63 and added `packages/tasks/src/requirements.mjs` to the sandbox's `RUNNER_FILES` (decision 127). Filbert approved round 2 in comment 28068 after a full rerun. Sage's gate on c047d028 plus the patch ran 23:50:16Z to 23:54:26Z with Docker disabled: tasks 89, bus 111, harness 66, webui 101, cli 123, seat 33, business 60, control-board 124, queue 150, conversation 182, discord 178, ledger 78, runs 43, mosaic 69, all fail 0, and every `scripts/test-*.sh` exited 0. No commit since base b8539480 touched the 21 paths, and `queue review verify-commit` matched. Row 90 went to done at rev 863 (e2fe22fc), and #1584 is closed with comment 28078. Filbert's three round 1 follow-ups are Vikunja #245. After landing, the Console and bus were active, NRestarts 0, healthz 200, and nothing restarted. Row 94 goes to round 2 rebased on this commit, because both rows change `packages/bus/README.md` and `packages/bus/src/broker.mjs` (Mos: whichever is approved first lands first). Darkwing's launcher `recover()` finding is decision 128 and Vikunja #244. After (e918a915): Dewey's round 2 candidate, manifest 95611274, 21 paths under `packages/tasks/`, `packages/bus/`, `packages/harness/` and `packages/seat/`, plus `roles/pm.md`. The approved PRD's 24 ids live in `packages/tasks/requirements.json`. `task.create` refuses an id outside them with `unknown-requirement`, and sessions that hold `task.create` get a `list_requirements` tool. Round 2 rebased on row 63 and added `packages/tasks/src/requirements.mjs` to the sandbox's `RUNNER_FILES` (decision 127). Filbert approved round 2 in comment 28068 after a full rerun. Sage's gate on c047d028 plus the patch ran 23:50:16Z to 23:54:26Z with Docker disabled: tasks 89, bus 111, harness 66, webui 101, cli 123, seat 33, business 60, control-board 124, queue 150, conversation 182, discord 178, ledger 78, runs 43, mosaic 69, all fail 0, and every `scripts/test-*.sh` exited 0. No commit since base b8539480 touched the 21 paths, and `queue review verify-commit` matched. Row 90 went to done at rev 863 (e2fe22fc), and #1584 is closed with comment 28078. Filbert's three round 1 follow-ups are Vikunja #245. After landing, the Console and bus were active, NRestarts 0, healthz 200, and nothing restarted. Row 94 goes to round 2 rebased on this commit, because both rows change `packages/bus/README.md` and `packages/bus/src/broker.mjs` (Mos: whichever is approved first lands first). Darkwing's launcher `recover()` finding is decision 128 and Vikunja #244.
Two corrections for the record. First, I proposed gating rows 94 and 90 stacked and landing both. That can't work: each manifest pins its own version of the two shared files, so the second landing would fail `verify-commit`. Row 94 takes a round 2 instead. Second, my decision-109 notice told Mos that nothing went live until the bus restart. The running bus (started 18:53:34Z, before rows 89 and 92) starts each role session as a fresh `runner.mjs` from the checkout, so a session started before the restart would get row 90's harness against the old broker. I corrected it before landing. Mos confirmed only the PM session was running and none would start (coder and reviewer launches have been off since Q125), and said to land. From now on, decision-109 notices will say when the harness changes ahead of a bus restart. Two corrections for the record. First, I proposed gating rows 94 and 90 stacked and landing both. That can't work: each manifest pins its own version of the two shared files, so the second landing would fail `verify-commit`. Row 94 takes a round 2 instead. Second, my decision-109 notice told Mos that nothing went live until the bus restart. The running bus (started 18:53:34Z, before rows 89 and 92) starts each role session as a fresh `runner.mjs` from the checkout, so a session started before the restart would get row 90's harness against the old broker. I corrected it before landing. Mos confirmed only the PM session was running and none would start (coder and reviewer launches have been off since Q125), and said to land. From now on, decision-109 notices will say when the harness changes ahead of a bus restart.
### 2026-10-12 — Rocko, row 94 round 2 started after row 90 (#1588)
Before: round 1 manifest bd9e0cea had green suites but Dewey's comment 28075 found seven survivors in eight independent mutant sites. Sage authorized round 2 after e918a915 landed and granted the free test slot. The r1 patch applies to a detached worktree of e918a915; row 90's requirement imports/use and README lines remain intact. Scope: Dewey's five asks, test additions plus moving messages above the replies comment. The full gate will run with DOCKER_HOST=unix:///nonexistent.sock under decision 127. Packet: agents/rocko/work/queue-94/r2/. Queue reopened in-progress at rev 864. No candidate commit, push or live service operation.
### 2026-10-13 00:06:47 UTC — Rocko, row 94 round 2 ready for Dewey (#1588)
After: r1 rebased onto e918a915 with all 12 broker and two README row-90 lines preserved verbatim. Dewey 28075 asks 1–4 now have tests for delivered-but-unread flag, text-inbox read exclusion/delivered inclusion, Tasks/Board count updates and Board refusal clearing, and messages-only 403 refusing Queue/Business/Settings before any local read. Ask 5 moves messages above the replies comment. Optional plain-talk SIGINT coverage kills the eighth reviewer site. Product behavior otherwise stays r1. Packet agents/rocko/work/queue-94/r2 has the uncommitted 16-file patch and manifest 53b01ea9f65d8ec5812111701425e7c5c60bc31f36af2b42b541ae22a82cc1ad. Full detached gate with DOCKER_HOST=unix:///nonexistent.sock: bus 115, CLI 129, webui 104, no failures/skips/cancellations; all nine shell suites exit 0 (00:02:35Z–00:04:58Z); original 27 and all eight Dewey sites killed, 35/35 with no timeout. Hashes match after mutation restoration; patch applies to canonical checkout. Round 2 opened at rev 866; expected tokenless request failed at rev 867, for Sage/jarvis retry. Slot clear passed straight to Darkwing for row 91 r2; no test process remains in the detached worktree. Dewey review, Sage's independent gate and Mos's decision-123 go remain before landing. No canonical source edit, candidate commit, push, merge or live service action.
docs/SESSIONS.md
+2
View File
@@ -827,3 +827,5 @@ are never rewritten or removed; corrections are new entries.
2026-10-12T23:57:54Z | sage | row 90 landing (#1584), decision 128 | landed e918a915, rev 863, #1584 closed 28078; gate green on 14 node and 9 scripts suites; decision 128, launcher recover() gap is Vikunja #244; row 90 follow-ups Vikunja #245; row 94 to round 2 on e918a915; corrected my stacked-gate plan and the live-harness wording in my Mos notice 2026-10-12T23:57:54Z | sage | row 90 landing (#1584), decision 128 | landed e918a915, rev 863, #1584 closed 28078; gate green on 14 node and 9 scripts suites; decision 128, launcher recover() gap is Vikunja #244; row 90 follow-ups Vikunja #245; row 94 to round 2 on e918a915; corrected my stacked-gate plan and the live-harness wording in my Mos notice
2026-10-12T23:59:03Z | darkwing | row 97 (#1591) round 1 review | changes, comment 28083, rev 865 (15373266, swept rocko's rev 864): webui 101/0; added mutant (13 under an arrow refactor) survives because the stub files timers by callback name and no test checks a board poll is ever recorded; asked for one positive control; mutant 14 equivalent 2026-10-12T23:59:03Z | darkwing | row 97 (#1591) round 1 review | changes, comment 28083, rev 865 (15373266, swept rocko's rev 864): webui 101/0; added mutant (13 under an arrow refactor) survives because the stub files timers by callback name and no test checks a board poll is ever recorded; asked for one positive control; mutant 14 equivalent
2026-10-13T00:03:49Z | filbert | row 91 (#1585) round 1 static review preserved pending r2 | manifest 8/8 on c974cafa; decision 128 finds no second early-release path in normal launcher lifecycle; decision 127 separates read-only runner requirements import from host-only checkout; nested-submodule filter probe prepared and syntax checked, not run; Sage requires r2 on 6b0215aa and Darkwing slot-clear before tests/verdict, then direct Researcher slot handoff; no push 2026-10-13T00:03:49Z | filbert | row 91 (#1585) round 1 static review preserved pending r2 | manifest 8/8 on c974cafa; decision 128 finds no second early-release path in normal launcher lifecycle; decision 127 separates read-only runner requirements import from host-only checkout; nested-submodule filter probe prepared and syntax checked, not run; Sage requires r2 on 6b0215aa and Darkwing slot-clear before tests/verdict, then direct Researcher slot handoff; no push
2026-10-13 00:06:47 UTC | Rocko (Codex gpt-6.1-sol, d99326cc) | row 94 #1588 round 2 rebased on e918a915, Dewey 28075 asks 1–5 plus plain-talk SIGINT test | manifest 53b01ea9, detached full gate DOCKER_HOST=unix:///nonexistent.sock bus 115/CLI 129/webui 104 and nine shell suites green; 35/35 mutants killed; in-review rev 866, tokenless request failed rev 867; slot clear sent to Darkwing for row 91 r2; no candidate commit/push/live service action.