mosaicstack/stack
25
0
Fork 1
Code Issues 360 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 621-623, row 76 round 2 in review, request comment 27672 (#1570) (dewey)

Browse Source
This commit is contained in:
jason.woltje
2026-10-11 21:40:13 -05:00
parent 86821889ed
commit 18f22406dd
2 changed files with 116 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 620 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 623 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -112,7 +112,7 @@ Generated from `docs/plans/queue.json` revision 620 by `queue render`. Do not ed
| 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | done | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | done | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-review, round 1, request posted | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-review, round 2, request posted | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. |
| 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | done | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | done | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
docs/plans/queue.json
+114 -3
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 620,
"revision": 623,
"rows": [
{
"id": 1,
@@ -5972,6 +5972,37 @@
"candidate": "ca8703145aed98142c1fdf0553ab846a9b9a808cd58c35f7cbb4fa35d7f279a2"
}
]
},
{
"n": 2,
"op": "dewey-76-review-r2-20261012",
"by": "dewey",
"at": "2026-10-12T02:39:36.374Z",
"issue": 1570,
"candidate": {
"kind": "manifest",
"digest": "04ecf1b57c594a35d34d53277b2df915a571f4fa9f7cc29146dbedfa612f77d4",
"text": "911feb19e9b16fa4f163d77ee10c33270049ea60d16cabcd4197cd8a8847eaf7 packages/webui/README.md\na0661abb7de79ce2854884c99f7d8db114d8028d99048e7387a9b2f8534cd422 packages/webui/src/bus.mjs\nc8f9845c66793b0516d5f356f6be9f8ae2d46c40fdd044945aac2a606d024bee packages/webui/src/cli.mjs\na259dd523625a83237ebc98d0361ff6de1732729a661f9e0f37492f99e3b3f60 packages/webui/src/serve.mjs\n8f627ccde5775281aa7676b8495d55bcb65a5f32f6a2bb53f1a313afb28ccd8f packages/webui/src/public/app.js\n78d75b88a89a2bbd83a264e8b8a5da739edb0b19dd7a8cfbbc0f18fd4895fceb packages/webui/src/public/bus.js\n8401bd8f650dadf07fadf4f1304d8f509f706441763d870e48fd14215c9a7a22 packages/webui/tests/send.test.mjs\n97304808bab8eb27fde756081863ff56e932f7021fc151165db72ac2a7a83c81 packages/webui/tests/send-browser.test.mjs\n17cb39097414bd685d68305dd5e402fd645020695f3dee86cd6bb567dd410eff packages/webui/tests/shell.test.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "dewey-76-review-r2-20261012",
"by": "dewey",
"at": "2026-10-12T02:39:36.374Z",
"state": "posted",
"comment": 27672,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27672,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
@@ -5982,8 +6013,8 @@
"note": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh.",
"blockedReason": null,
"createdAt": "2026-10-11T22:17:42.739Z",
"updatedAt": "2026-10-12T01:46:47.488Z",
"updatedBy": "filbert"
"updatedAt": "2026-10-12T02:39:39.016Z",
"updatedBy": "dewey"
},
{
"id": 77,
@@ -23490,6 +23521,86 @@
"receipt": "ok sage-82-done rev 620 row 82 in-review→done round 2"
},
"viewSha": "3164f2a71416e879d2979731429200098de36f090bf3993133f15f7d9cf7e7c0"
},
{
"rev": 621,
"op": "dewey-76-reopen-r2",
"verb": "move",
"args": {
"id": 76,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-12T02:39:34.642Z",
"semantics": 2,
"result": {
"row": 76,
"from": "in-review",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok dewey-76-reopen-r2 rev 621 row 76 in-review→in-progress"
},
"viewSha": "7095204c134d172402500ed7e410191da96e9ee6d1c41e1ec26a9693be9185e2"
},
{
"rev": 622,
"op": "dewey-76-review-r2-20261012",
"verb": "move",
"args": {
"id": 76,
"to": "in-review",
"reason": null,
"candidate": "agents/dewey/work/queue-76/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-12T02:39:36.374Z",
"semantics": 2,
"result": {
"row": 76,
"from": "in-progress",
"to": "in-review",
"round": 2,
"issue": 1570,
"candidate": {
"kind": "manifest",
"digest": "04ecf1b57c594a35d34d53277b2df915a571f4fa9f7cc29146dbedfa612f77d4",
"text": "911feb19e9b16fa4f163d77ee10c33270049ea60d16cabcd4197cd8a8847eaf7 packages/webui/README.md\na0661abb7de79ce2854884c99f7d8db114d8028d99048e7387a9b2f8534cd422 packages/webui/src/bus.mjs\nc8f9845c66793b0516d5f356f6be9f8ae2d46c40fdd044945aac2a606d024bee packages/webui/src/cli.mjs\na259dd523625a83237ebc98d0361ff6de1732729a661f9e0f37492f99e3b3f60 packages/webui/src/serve.mjs\n8f627ccde5775281aa7676b8495d55bcb65a5f32f6a2bb53f1a313afb28ccd8f packages/webui/src/public/app.js\n78d75b88a89a2bbd83a264e8b8a5da739edb0b19dd7a8cfbbc0f18fd4895fceb packages/webui/src/public/bus.js\n8401bd8f650dadf07fadf4f1304d8f509f706441763d870e48fd14215c9a7a22 packages/webui/tests/send.test.mjs\n97304808bab8eb27fde756081863ff56e932f7021fc151165db72ac2a7a83c81 packages/webui/tests/send-browser.test.mjs\n17cb39097414bd685d68305dd5e402fd645020695f3dee86cd6bb567dd410eff packages/webui/tests/shell.test.mjs\n"
},
"receipt": "ok dewey-76-review-r2-20261012 rev 622 row 76 in-progress→in-review round 2 on #1570; request dewey-76-review-r2-20261012 requesting"
},
"viewSha": "697ab69b402582a3c8803688383095afd7037356695f257a0bf2c565fa863292"
},
{
"rev": 623,
"op": "dewey-76-review-r2-20261012.outcome",
"verb": "review-outcome",
"args": {
"id": 76,
"attempt": "dewey-76-review-r2-20261012",
"outcome": "posted",
"status": 201,
"comment": 27672,
"detail": "created"
},
"by": "dewey",
"at": "2026-10-12T02:39:39.016Z",
"semantics": 2,
"result": {
"row": 76,
"round": 2,
"attempt": "dewey-76-review-r2-20261012",
"state": "posted",
"receipt": "ok dewey-76-review-r2-20261012.outcome rev 623 row 76 round 2 request dewey-76-review-r2-20261012 posted comment 27672"
},
"viewSha": "faf4c7aa6eb8e0b4887c31d7fa8dbbb76e5885903b1861c929065d7ae12c368e"
}
]
}