From 19dcc5531d5b01a2fa01447584bd158a43d0db1e Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Fri, 9 Oct 2026 09:11:22 -0500 Subject: [PATCH] queue: rev 216, row 45 in review round 2 on #1527 (request posted by sage, comment 26882); includes revs 212-214 (rocko: in-progress, in-review round 2, candidate 5b067a9d) and rev 215 (request) --- docs/plans/QUEUE.md | 4 +- docs/plans/queue.json | 174 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 173 insertions(+), 5 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index 34e5e691..b1b9ff33 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 211 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 216 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -81,7 +81,7 @@ Generated from `docs/plans/queue.json` revision 211 by `queue render`. Do not ed | 42 | Slice 1 S7: acceptance, five pieces in a row | sage | #1524 | queued | 40 done, 41 done | Jason, from the five trails: only gated decisions reached him, every step left a trail (jason) | `docs/plans/2026-10-04_slice-1.md` § Slice 1 S7: acceptance, five pieces in a row | — | | 43 | S2b: gated approvals are single-use (authorize records consumption) | rocko; reviewers darkwing | #1525 | done | 37 done | darkwing approves on #1525; Sage's integration gate (sage) | `docs/plans/2026-10-05_s2b-single-use-approvals.md` § S2b: gated approvals are single-use (authorize records consumption) | 2026-10-05: S2 is in the tree at 38828a2c. Rocko's README edit (ae643fba, decision 62 human-proof note) is an uncommitted change on packages/bus/README.md and belongs in this row's candidate. | | 44 | S2c: a within-role message cites a decision without consuming it | rocko; reviewers darkwing | #1526 | done | 43 done | darkwing approves on #1526; Sage's integration gate (sage) | `docs/plans/2026-10-05_s2c-message-decision-citation.md` § S2c: a within-role message cites a decision without consuming it | — | -| 45 | S4 follow-up: notifier retry limit, journal types and the round 2 test gaps | rocko; reviewers darkwing, filbert | #1527 | in-review, round 1, request posted | — | filbert and darkwing approve on #1527; every node package suite and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-09_s4-follow-up-and-cohort.md` § S4 follow-up: notifier retry limit, journal types and the round 2 test gaps | lead decision 72; follows row 39 (2f5303c1) | +| 45 | S4 follow-up: notifier retry limit, journal types and the round 2 test gaps | rocko; reviewers darkwing, filbert | #1527 | in-review, round 2, request posted | — | filbert and darkwing approve on #1527; every node package suite and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-09_s4-follow-up-and-cohort.md` § S4 follow-up: notifier retry limit, journal types and the round 2 test gaps | lead decision 72; follows row 39 (2f5303c1) | | 46 | Conversation cohort: K1, K3 and K10 fail on the scope fixtures | darkwing; reviewers dewey | #1528 | done | — | dewey approves on #1528; conversation 152/152 and K1, K3, K10 green 3 times in isolation on Sage's rerun (sage) | `docs/plans/2026-10-09_s4-follow-up-and-cohort.md` § Conversation cohort: K1, K3 and K10 fail on the scope fixtures | lead decision 72; row 40 gates on this suite | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index bf88577b..183ef0e6 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 211, + "revision": 216, "rows": [ { "id": 1, @@ -2581,6 +2581,51 @@ "candidate": "b329fdcbdf8cb62659f239359570dfa9771559e3112b743df55429244769ed14" } ] + }, + { + "n": 2, + "op": "rocko-r45-review-r2", + "by": "rocko", + "at": "2026-10-09T14:09:47.495Z", + "issue": 1527, + "candidate": { + "kind": "manifest", + "digest": "5b067a9dad645c31d99e1ea02575cd2fc1ba547ce011ea81c56b17ae29da0d0e", + "text": "33835702af268d8337c68a9d62ab7340174ec6ec990a86422c099a922feba61d packages/cli/README.md\n24461cccd45d08cf4b5b77d2b44bd1792002bcaca028844b1f0f013052d097d6 packages/cli/src/host.mjs\ncb27929bd2d17704ff7db42a0b001d97cb626ec79fa833add4bdaff2e304a4c3 packages/cli/src/notifier.mjs\nb998202b4872c4929b1aeb601ed26da4bdaef8549ae0676ce650a23fa4f0f38c packages/cli/tests/host.test.mjs\n38d499cf3f2a0b78fb08d473946ea6517cc8a6b35681bd077695ddb507fb3cc6 packages/cli/tests/notifier.test.mjs\nf015ef5ed6ae2fa6ec40b2b0d5148baf23436917f71a7fa5521249864fdde0c4 packages/cli/tests/trackers-boot.test.mjs\n219924be715db3cbfc6030c4eafd57b27189d6d971b6da26f719b2f86599d37a packages/discord/tests/journal.test.mjs\nbc7abfb98e0ffa8c0d1111069c05ac19d9cc9be3b0ed4d457c4f135f97d08bb1 scripts/bus-service.sh\n" + }, + "request": "comment", + "attempts": [ + { + "op": "rocko-r45-review-r2", + "by": "rocko", + "at": "2026-10-09T14:09:47.495Z", + "state": "failed", + "comment": null, + "transport": { + "outcome": "failed", + "status": null, + "comment": null, + "detail": "pre-send: the credential or account check failed" + }, + "resolutions": [] + }, + { + "op": "sage-r45-review-2", + "by": "sage", + "at": "2026-10-09T14:10:55.466Z", + "state": "posted", + "comment": 26882, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 26882, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] } ] }, @@ -2591,8 +2636,8 @@ "note": "lead decision 72; follows row 39 (2f5303c1)", "blockedReason": null, "createdAt": "2026-10-09T12:55:14.364Z", - "updatedAt": "2026-10-09T13:32:09.204Z", - "updatedBy": "filbert" + "updatedAt": "2026-10-09T14:10:56.498Z", + "updatedBy": "sage" }, { "id": 46, @@ -9095,6 +9140,129 @@ "receipt": "ok filbert-r45-review-r1 rev 211 row 45 round 1 changes by filbert (comment 26880)" }, "viewSha": "799cf1ae3253a01190081d95b5718ae2a554ed527e917b4f225e88b29bd548ea" + }, + { + "rev": 212, + "op": "rocko-r45-round2-start", + "verb": "move", + "args": { + "id": 45, + "to": "in-progress", + "reason": null, + "candidate": null, + "evidence": null, + "issue": null + }, + "by": "rocko", + "at": "2026-10-09T14:09:44.669Z", + "semantics": 2, + "result": { + "row": 45, + "from": "in-review", + "to": "in-progress", + "round": null, + "issue": null, + "candidate": null, + "receipt": "ok rocko-r45-round2-start rev 212 row 45 in-review→in-progress" + }, + "viewSha": "a3a2c16119d3a1a616832a5e399b0a2d07f3dbf786cecdcaac0859b19f93a4fd" + }, + { + "rev": 213, + "op": "rocko-r45-review-r2", + "verb": "move", + "args": { + "id": 45, + "to": "in-review", + "reason": null, + "candidate": "agents/rocko/work/s4-follow-up/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "rocko", + "at": "2026-10-09T14:09:47.495Z", + "semantics": 2, + "result": { + "row": 45, + "from": "in-progress", + "to": "in-review", + "round": 2, + "issue": 1527, + "candidate": { + "kind": "manifest", + "digest": "5b067a9dad645c31d99e1ea02575cd2fc1ba547ce011ea81c56b17ae29da0d0e", + "text": "33835702af268d8337c68a9d62ab7340174ec6ec990a86422c099a922feba61d packages/cli/README.md\n24461cccd45d08cf4b5b77d2b44bd1792002bcaca028844b1f0f013052d097d6 packages/cli/src/host.mjs\ncb27929bd2d17704ff7db42a0b001d97cb626ec79fa833add4bdaff2e304a4c3 packages/cli/src/notifier.mjs\nb998202b4872c4929b1aeb601ed26da4bdaef8549ae0676ce650a23fa4f0f38c packages/cli/tests/host.test.mjs\n38d499cf3f2a0b78fb08d473946ea6517cc8a6b35681bd077695ddb507fb3cc6 packages/cli/tests/notifier.test.mjs\nf015ef5ed6ae2fa6ec40b2b0d5148baf23436917f71a7fa5521249864fdde0c4 packages/cli/tests/trackers-boot.test.mjs\n219924be715db3cbfc6030c4eafd57b27189d6d971b6da26f719b2f86599d37a packages/discord/tests/journal.test.mjs\nbc7abfb98e0ffa8c0d1111069c05ac19d9cc9be3b0ed4d457c4f135f97d08bb1 scripts/bus-service.sh\n" + }, + "receipt": "ok rocko-r45-review-r2 rev 213 row 45 in-progress→in-review round 2 on #1527; request rocko-r45-review-r2 requesting" + }, + "viewSha": "63797efef2d85023441f4f30d96aee5d5c0b2b38dc9847432fd29adb4134dc8a" + }, + { + "rev": 214, + "op": "rocko-r45-review-r2.outcome", + "verb": "review-outcome", + "args": { + "id": 45, + "attempt": "rocko-r45-review-r2", + "outcome": "failed", + "status": null, + "comment": null, + "detail": "pre-send: the credential or account check failed" + }, + "by": "rocko", + "at": "2026-10-09T14:09:47.744Z", + "semantics": 2, + "result": { + "row": 45, + "round": 2, + "attempt": "rocko-r45-review-r2", + "state": "failed", + "receipt": "ok rocko-r45-review-r2.outcome rev 214 row 45 round 2 request rocko-r45-review-r2 failed" + }, + "viewSha": "605c779cecb3059ca6281a72bb39e2aabac6fd0ad75be1a1cc7b6e5630ac23ec" + }, + { + "rev": 215, + "op": "sage-r45-review-2", + "verb": "review-request", + "args": { + "id": 45 + }, + "by": "sage", + "at": "2026-10-09T14:10:55.466Z", + "semantics": 2, + "result": { + "row": 45, + "round": 2, + "attempt": "sage-r45-review-2", + "state": "requesting", + "receipt": "ok sage-r45-review-2 rev 215 row 45 round 2 request sage-r45-review-2 requesting" + }, + "viewSha": "d33384a2e0cc484eb766634e9c7672d2543dc09e001f3c5f1c8f48b7c7ad20b0" + }, + { + "rev": 216, + "op": "sage-r45-review-2.outcome", + "verb": "review-outcome", + "args": { + "id": 45, + "attempt": "sage-r45-review-2", + "outcome": "posted", + "status": 201, + "comment": 26882, + "detail": "created" + }, + "by": "sage", + "at": "2026-10-09T14:10:56.498Z", + "semantics": 2, + "result": { + "row": 45, + "round": 2, + "attempt": "sage-r45-review-2", + "state": "posted", + "receipt": "ok sage-r45-review-2.outcome rev 216 row 45 round 2 request sage-r45-review-2 posted comment 26882" + }, + "viewSha": "feae68912a5969960ea361986019c6583a475b8b22f242d3dea53eeae2923775" } ] }