queue: revs 581-585, row 78 round 1 approved by filbert, comment 27560 (#1572)

Rev 583 is mine (filbert-78-review-1). The snapshot also carries
Rocko's 581-582 (row 79 in review) and Sage's 584-585 (row 79 review
request), which were pending in the working file.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
2026-10-11 19:20:46 -05:00
co-authored by Claude Opus 5.5
parent feabde9574
commit 1a71869479
2 changed files with 95 additions and 8 deletions
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin --> <!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 582 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. Generated from `docs/plans/queue.json` revision 585 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note | | # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---| |---|---|---|---|---|---|---|---|---|
@@ -115,7 +115,7 @@ Generated from `docs/plans/queue.json` revision 582 by `queue render`. Do not ed
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-progress | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. | | 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-progress | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. | | 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. |
| 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | in-review, round 1, request posted | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — | | 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | in-review, round 1, request posted | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | in-review, round 1, request failed | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. | | 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | in-review, round 1, request posted | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
| 80 | Bus: list messages stranded by a holder change (row 59 review Note B) | darkwing; reviewers filbert | #1574 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | 59 done | filbert approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_bus-stranded-delivery.md` § Show messages stranded by a holder change | — | | 80 | Bus: list messages stranded by a holder change (row 59 review Note B) | darkwing; reviewers filbert | #1574 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | 59 done | filbert approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_bus-stranded-delivery.md` § Show messages stranded by a holder change | — |
| 81 | Console shows the reply to a web send | dewey; reviewers darkwing | #1575 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94); also after row 59 (Darkwing), which edits broker.mjs reads (lead decision 97) | 76 done | darkwing approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-reply-view.md` § Show replies to a message without receiving them | — | | 81 | Console shows the reply to a web send | dewey; reviewers darkwing | #1575 | blocked (from queued): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94); also after row 59 (Darkwing), which edits broker.mjs reads (lead decision 97) | 76 done | darkwing approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-reply-view.md` § Show replies to a message without receiving them | — |
+93 -6
View File
@@ -1,7 +1,7 @@
{ {
"version": 1, "version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack", "canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 582, "revision": 585,
"rows": [ "rows": [
{ {
"id": 1, "id": 1,
@@ -5944,7 +5944,16 @@
} }
], ],
"duplicateRisk": false, "duplicateRisk": false,
"receipts": [] "receipts": [
{
"reviewer": "filbert",
"op": "filbert-78-review-1",
"at": "2026-10-12T00:18:47.590Z",
"verdict": "approve",
"comment": 27560,
"candidate": "3016dbf19f495e1060aa6c3a13761231e1e2a1a8c4cefb28c592978d3b216b0f"
}
]
} }
] ]
}, },
@@ -5955,8 +5964,8 @@
"note": null, "note": null,
"blockedReason": null, "blockedReason": null,
"createdAt": "2026-10-11T23:13:47.280Z", "createdAt": "2026-10-11T23:13:47.280Z",
"updatedAt": "2026-10-12T00:10:01.398Z", "updatedAt": "2026-10-12T00:18:47.590Z",
"updatedBy": "sage" "updatedBy": "filbert"
}, },
{ {
"id": 79, "id": 79,
@@ -6016,6 +6025,20 @@
"detail": "pre-send: the credential or account check failed" "detail": "pre-send: the credential or account check failed"
}, },
"resolutions": [] "resolutions": []
},
{
"op": "sage-79-review-request-1",
"by": "sage",
"at": "2026-10-12T00:18:53.682Z",
"state": "posted",
"comment": 27561,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27561,
"detail": "created"
},
"resolutions": []
} }
], ],
"duplicateRisk": false, "duplicateRisk": false,
@@ -6030,8 +6053,8 @@
"note": "Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate.", "note": "Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate.",
"blockedReason": null, "blockedReason": null,
"createdAt": "2026-10-11T23:20:20.328Z", "createdAt": "2026-10-11T23:20:20.328Z",
"updatedAt": "2026-10-12T00:18:12.937Z", "updatedAt": "2026-10-12T00:18:59.783Z",
"updatedBy": "rocko" "updatedBy": "sage"
}, },
{ {
"id": 80, "id": 80,
@@ -22250,6 +22273,70 @@
"receipt": "ok rocko-79-review-1.outcome rev 582 row 79 round 1 request rocko-79-review-1 failed" "receipt": "ok rocko-79-review-1.outcome rev 582 row 79 round 1 request rocko-79-review-1 failed"
}, },
"viewSha": "b62f8c58459ea7c358cc72ef2506cc3a679251296167e0cffdd209d3351bc4bf" "viewSha": "b62f8c58459ea7c358cc72ef2506cc3a679251296167e0cffdd209d3351bc4bf"
},
{
"rev": 583,
"op": "filbert-78-review-1",
"verb": "review-record",
"args": {
"id": 78,
"verdict": "approve",
"comment": 27560,
"candidate": "3016dbf19f495e1060aa6c3a13761231e1e2a1a8c4cefb28c592978d3b216b0f"
},
"by": "filbert",
"at": "2026-10-12T00:18:47.590Z",
"semantics": 2,
"result": {
"row": 78,
"round": 1,
"verdict": "approve",
"receipt": "ok filbert-78-review-1 rev 583 row 78 round 1 approve by filbert (comment 27560)"
},
"viewSha": "6e2017eb2c682f596af5fe0724246f1510668311ce05afc6b41feb2282c0d768"
},
{
"rev": 584,
"op": "sage-79-review-request-1",
"verb": "review-request",
"args": {
"id": 79
},
"by": "sage",
"at": "2026-10-12T00:18:53.682Z",
"semantics": 2,
"result": {
"row": 79,
"round": 1,
"attempt": "sage-79-review-request-1",
"state": "requesting",
"receipt": "ok sage-79-review-request-1 rev 584 row 79 round 1 request sage-79-review-request-1 requesting"
},
"viewSha": "df1347a13a27f232282de1deda7529136a290600e416c21e683d3beaa08096f4"
},
{
"rev": 585,
"op": "sage-79-review-request-1.outcome",
"verb": "review-outcome",
"args": {
"id": 79,
"attempt": "sage-79-review-request-1",
"outcome": "posted",
"status": 201,
"comment": 27561,
"detail": "created"
},
"by": "sage",
"at": "2026-10-12T00:18:59.783Z",
"semantics": 2,
"result": {
"row": 79,
"round": 1,
"attempt": "sage-79-review-request-1",
"state": "posted",
"receipt": "ok sage-79-review-request-1.outcome rev 585 row 79 round 1 request sage-79-review-request-1 posted comment 27561"
},
"viewSha": "a2df4482c16959dc8b69bbee751b0dd2a92e60965150753831f81cf403316343"
} }
] ]
} }