format: apply repo prettier (3.8.1) to the folded skills tree
963 markdown files reformatted with the repository's pinned prettier so pnpm format:check covers the folded tree like every other repo file. The formatter's embedded-language pass also normalized code fences (TS semicolons, closed HTML tags in examples, lowercased CSS hex colors, one renumbered list that skipped an index). Alphanumeric token deltas vs the fold commit were audited file-by-file; all are formatter-equivalent markup normalizations plus the four sanitized skills.
This commit is contained in:
@@ -20,15 +20,18 @@ Copy and use this template for your code reviews.
|
||||
## Required Changes
|
||||
|
||||
🔴 **[blocking]** [Issue description]
|
||||
|
||||
> [Code location or example]
|
||||
> [Suggested fix or explanation]
|
||||
|
||||
🔴 **[blocking]** [Issue description]
|
||||
|
||||
> [Details]
|
||||
|
||||
## Important Suggestions
|
||||
|
||||
🟡 **[important]** [Issue description]
|
||||
|
||||
> [Why this matters]
|
||||
> [Suggested approach]
|
||||
|
||||
@@ -68,6 +71,7 @@ Copy and use this template for your code reviews.
|
||||
## Quick Copy Templates
|
||||
|
||||
### Blocking Issue
|
||||
|
||||
```
|
||||
🔴 **[blocking]** [Title]
|
||||
|
||||
@@ -82,6 +86,7 @@ Copy and use this template for your code reviews.
|
||||
```
|
||||
|
||||
### Important Suggestion
|
||||
|
||||
```
|
||||
🟡 **[important]** [Title]
|
||||
|
||||
@@ -93,6 +98,7 @@ Copy and use this template for your code reviews.
|
||||
```
|
||||
|
||||
### Minor Suggestion
|
||||
|
||||
```
|
||||
🟢 **[nit]** [Suggestion]
|
||||
|
||||
@@ -100,6 +106,7 @@ Not blocking, but consider [improvement].
|
||||
```
|
||||
|
||||
### Praise
|
||||
|
||||
```
|
||||
🎉 **[praise]** Great work on [specific thing]!
|
||||
|
||||
@@ -107,6 +114,7 @@ Not blocking, but consider [improvement].
|
||||
```
|
||||
|
||||
### Question
|
||||
|
||||
```
|
||||
❓ **[question]** [Your question]
|
||||
|
||||
|
||||
+22
-22
@@ -70,38 +70,38 @@ Quick reference checklist for code reviews.
|
||||
|
||||
## Severity Labels
|
||||
|
||||
| Label | Meaning | Action |
|
||||
|-------|---------|--------|
|
||||
| 🔴 `[blocking]` | Must fix | Block merge |
|
||||
| 🟡 `[important]` | Should fix | Discuss if disagree |
|
||||
| 🟢 `[nit]` | Nice to have | Non-blocking |
|
||||
| 💡 `[suggestion]` | Alternative | Consider |
|
||||
| ❓ `[question]` | Need clarity | Respond |
|
||||
| 🎉 `[praise]` | Good work | Celebrate! |
|
||||
| Label | Meaning | Action |
|
||||
| ----------------- | ------------ | ------------------- |
|
||||
| 🔴 `[blocking]` | Must fix | Block merge |
|
||||
| 🟡 `[important]` | Should fix | Discuss if disagree |
|
||||
| 🟢 `[nit]` | Nice to have | Non-blocking |
|
||||
| 💡 `[suggestion]` | Alternative | Consider |
|
||||
| ❓ `[question]` | Need clarity | Respond |
|
||||
| 🎉 `[praise]` | Good work | Celebrate! |
|
||||
|
||||
---
|
||||
|
||||
## Decision Matrix
|
||||
|
||||
| Situation | Decision |
|
||||
|-----------|----------|
|
||||
| Critical security issue | 🔴 Block, fix immediately |
|
||||
| Breaking change without migration | 🔴 Block |
|
||||
| Missing error handling | 🟡 Should fix |
|
||||
| No tests for new code | 🟡 Should fix |
|
||||
| Style preference | 🟢 Non-blocking |
|
||||
| Minor naming improvement | 🟢 Non-blocking |
|
||||
| Clever but working code | 💡 Suggest simpler |
|
||||
| Situation | Decision |
|
||||
| --------------------------------- | ------------------------- |
|
||||
| Critical security issue | 🔴 Block, fix immediately |
|
||||
| Breaking change without migration | 🔴 Block |
|
||||
| Missing error handling | 🟡 Should fix |
|
||||
| No tests for new code | 🟡 Should fix |
|
||||
| Style preference | 🟢 Non-blocking |
|
||||
| Minor naming improvement | 🟢 Non-blocking |
|
||||
| Clever but working code | 💡 Suggest simpler |
|
||||
|
||||
---
|
||||
|
||||
## Time Budget
|
||||
|
||||
| PR Size | Target Time |
|
||||
|---------|-------------|
|
||||
| < 100 lines | 10-15 min |
|
||||
| 100-400 lines | 20-40 min |
|
||||
| > 400 lines | Ask to split |
|
||||
| PR Size | Target Time |
|
||||
| ------------- | ------------ |
|
||||
| < 100 lines | 10-15 min |
|
||||
| 100-400 lines | 20-40 min |
|
||||
| > 400 lines | Ask to split |
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user