fix(framework/tools): lane-brief.sh — classify PR-body-linked issues as work-underway (#546)
Some checks failed
ci/woodpecker/push/ci Pipeline failed
ci/woodpecker/pr/ci Pipeline failed

Remediation of coder3 independent-validation blocker on PR #547.

lane-brief.sh inspected only the open-PR index/title/head fields, never the PR
BODY or Gitea issue linkage. A body-only "Closes #546" was therefore invisible,
so issue #546 (open, with PR #547 'Closes #546' in its body) was placed under
DISPATCH CANDIDATES with work-underway count 0 — re-dispatchable in-flight work,
unacceptable for a dispatch-truth tool.

Fix:
- Fetch open PRs as JSON including `body`; resolve PR->issue links via Gitea's
  closing-keyword set (close/closes/closed, fix/fixes/fixed, resolve/resolves/
  resolved), case-insensitive, word-boundary anchored, `#` directly following the
  keyword. Any issue so linked from an OPEN PR is classified WORK UNDERWAY.
- Preserve the prior title/head bare-ref heuristic and per-repo behavior; require
  `#` immediately after the keyword so cross-repo `owner/repo#N` forms don't leak.
- Bare `#N` prose mentions in a body are intentionally NOT links (e.g. "#538 line
  of work") to avoid marking live, dispatchable issues as in-flight.

Tests (committed, RED-on-revert non-vacuity):
- test-lane-brief-pr-linkage.sh: open-PR-with-'Closes #546'-in-body excludes #546
  from candidates (and a reverted copy with the body-scan removed regresses #546
  to a candidate — RED proof); bare #777 and substring 'hotfix #999' stay
  candidates (word-boundary + closing-keyword-only guards).
- test-ci-wait-exit-matrix.sh: ci-wait.sh exit matrix 0 (all-success) / 1
  (terminal-not-success: failure + error/killed) / 2 (usage) / 3 (timeout).

shellcheck -x + bash -n clean on all four files; no secret values. ci-wait.sh
unchanged (coder3 PASS preserved). Closed-issue exclusion unchanged.

Refs #546, PR #547

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Hermes Agent
2026-06-18 16:49:13 -05:00
parent 46d828f166
commit 1d87b76e1f
3 changed files with 222 additions and 4 deletions

View File

@@ -0,0 +1,76 @@
#!/usr/bin/env bash
# Regression harness for ci-wait.sh terminal-state aggregation and exit codes.
#
# ci-wait.sh wraps pipeline-status.sh and blocks until every requested pipeline
# reaches a terminal Woodpecker state, then maps the aggregate to an exit code.
# That contract is what callers arm a Monitor/timed-fallback around, so it must be
# exact. This harness drives ci-wait.sh against a stub pipeline-status.sh whose
# per-pipeline status is fixture-controlled, and asserts the full exit matrix:
#
# 0 = every pipeline terminal AND all 'success'
# 1 = every pipeline terminal, at least one non-success
# 2 = usage/precondition error (missing -n)
# 3 = timeout before all pipelines terminal
#
# Non-vacuity: each case pins a DISTINCT exit code to a distinct fixture, so a
# regression in success-aggregation (case 0 vs 1), terminal detection (case 3),
# or arg validation (case 2) flips exactly one assertion RED.
set -euo pipefail
CIW_SRC="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/ci-wait.sh"
WORK_DIR="${MOSAIC_TEST_WORK_DIR:-$PWD/.mosaic-test-work/ci-wait-exit-matrix}"
TOOL_DIR="$WORK_DIR/tool"
rm -rf "$WORK_DIR"
mkdir -p "$TOOL_DIR"
# ci-wait.sh resolves pipeline-status.sh as a sibling ($SCRIPT_DIR/pipeline-status.sh),
# so we run a COPY of ci-wait.sh next to a stub sibling we control.
cp "$CIW_SRC" "$TOOL_DIR/ci-wait.sh"
chmod +x "$TOOL_DIR/ci-wait.sh"
# Stub pipeline-status.sh: emits {"status":"<s>"} where <s> comes from env
# CIW_STATUS_<num> (default "running" = non-terminal, drives the timeout path).
cat > "$TOOL_DIR/pipeline-status.sh" <<'SH'
#!/usr/bin/env bash
set -euo pipefail
num=""
while getopts "r:n:a:f:" opt; do case "$opt" in n) num="$OPTARG" ;; *) : ;; esac; done
var="CIW_STATUS_${num}"
printf '{"status":"%s"}\n' "${!var:-running}"
SH
chmod +x "$TOOL_DIR/pipeline-status.sh"
CIW="$TOOL_DIR/ci-wait.sh"
run_expect() { # $1 = expected exit $2 = label ; rest = args
local want="$1" label="$2"; shift 2
local rc=0
"$CIW" "$@" >/dev/null 2>&1 || rc=$?
if [[ "$rc" -ne "$want" ]]; then
echo "FAIL [$label]: expected exit $want, got $rc" >&2; exit 1
fi
echo "PASS [$label]: exit $rc"
}
# 0 — both pipelines terminal + success
CIW_STATUS_100=success CIW_STATUS_101=success \
run_expect 0 "all-success" -r mosaic/stack -n 100 -n 101 -a mosaic -i 1 -t 30
# 1 — both terminal, one failure
CIW_STATUS_100=success CIW_STATUS_101=failure \
run_expect 1 "terminal-not-success" -r mosaic/stack -n 100 -n 101 -a mosaic -i 1 -t 30
# 1 — other terminal non-success states still map to 1 (error/killed)
CIW_STATUS_100=error CIW_STATUS_101=killed \
run_expect 1 "terminal-error-killed" -r mosaic/stack -n 100 -n 101 -a mosaic -i 1 -t 30
# 3 — a pipeline never reaches terminal state before timeout
CIW_STATUS_100=success CIW_STATUS_101=running \
run_expect 3 "timeout-pending" -r mosaic/stack -n 100 -n 101 -a mosaic -i 1 -t 0
# 2 — usage error: no -n
run_expect 2 "usage-missing-n" -r mosaic/stack -a mosaic
echo "ALL PASS: test-ci-wait-exit-matrix.sh"