queue: revs 792-793, row 77 round 3 review request as jarvis, comment 27973 (#1571)

2026-10-12 17:07:46 -05:00
parent e13edda828
commit 1fb438228d
2 changed files with 62 additions and 5 deletions
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.

 <!-- mosaic-queue:begin -->

-Generated from `docs/plans/queue.json` revision 791 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
+Generated from `docs/plans/queue.json` revision 793 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.

 | # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
 |---|---|---|---|---|---|---|---|---|
@@ -113,7 +113,7 @@ Generated from `docs/plans/queue.json` revision 791 by `queue render`. Do not ed
 | 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | done | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
 | 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
 | 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | done | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
-| 77 | Console pinned copy, update step and service hardening (row 75 N1-N5, Vikunja 146 147) | rocko; reviewers darkwing, filbert | #1571 | in-review, round 3, request failed | 75 done | darkwing and filbert approve on 1571 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing (decision 109) (sage) | `docs/plans/2026-10-12_console-pinned-copy.md` § Console pinned copy, update step and service hardening | filbert approved round 2 (27898); row 95 also edits packages/webui/README.md, so whichever of 77/95 lands second rebases it |
+| 77 | Console pinned copy, update step and service hardening (row 75 N1-N5, Vikunja 146 147) | rocko; reviewers darkwing, filbert | #1571 | in-review, round 3, request posted | 75 done | darkwing and filbert approve on 1571 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing (decision 109) (sage) | `docs/plans/2026-10-12_console-pinned-copy.md` § Console pinned copy, update step and service hardening | filbert approved round 2 (27898); row 95 also edits packages/webui/README.md, so whichever of 77/95 lands second rebases it |
 | 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | done | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
 | 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | done | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
 | 80 | Bus: list messages stranded by a holder change (row 59 review Note B) | researcher; reviewers filbert | #1574 | briefed | 59 done | filbert approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_bus-stranded-delivery.md` § Show messages stranded by a holder change | Decision 122: Researcher builds this on Haiku 5.5 high effort after row 86 lands; Filbert reviews on Codex gpt-6.1-sol |
@@ -1,7 +1,7 @@
 {
  "version": 1,
  "canonicalRoot": "/mnt/storage/src/mosaic-stack",
-  "revision": 791,
+  "revision": 793,
  "rows": [
    {
      "id": 1,
@@ -6316,6 +6316,20 @@
                  "detail": "pre-send: the credential or account check failed"
                },
                "resolutions": []
+              },
+              {
+                "op": "sage-77-review-3-request",
+                "by": "sage",
+                "at": "2026-10-12T22:07:05.555Z",
+                "state": "posted",
+                "comment": 27973,
+                "transport": {
+                  "outcome": "posted",
+                  "status": 201,
+                  "comment": 27973,
+                  "detail": "created"
+                },
+                "resolutions": []
              }
            ],
            "duplicateRisk": false,
@@ -6330,8 +6344,8 @@
      "note": "filbert approved round 2 (27898); row 95 also edits packages/webui/README.md, so whichever of 77/95 lands second rebases it",
      "blockedReason": null,
      "createdAt": "2026-10-11T22:46:07.285Z",
-      "updatedAt": "2026-10-12T22:06:25.979Z",
-      "updatedBy": "rocko"
+      "updatedAt": "2026-10-12T22:07:09.136Z",
+      "updatedBy": "sage"
    },
    {
      "id": 78,
@@ -29039,6 +29053,49 @@
        "receipt": "ok rocko-77-review-3.outcome rev 791 row 77 round 3 request rocko-77-review-3 failed"
      },
      "viewSha": "51107a333e1b5c1ed5119d7120eb07f51566c799152df3abc30ad3fe82590bf5"
+    },
+    {
+      "rev": 792,
+      "op": "sage-77-review-3-request",
+      "verb": "review-request",
+      "args": {
+        "id": 77
+      },
+      "by": "sage",
+      "at": "2026-10-12T22:07:05.555Z",
+      "semantics": 2,
+      "result": {
+        "row": 77,
+        "round": 3,
+        "attempt": "sage-77-review-3-request",
+        "state": "requesting",
+        "receipt": "ok sage-77-review-3-request rev 792 row 77 round 3 request sage-77-review-3-request requesting"
+      },
+      "viewSha": "f21f105e123465a7274826e974032401f185f7f28d0a9e08b5a9e8ba75af3086"
+    },
+    {
+      "rev": 793,
+      "op": "sage-77-review-3-request.outcome",
+      "verb": "review-outcome",
+      "args": {
+        "id": 77,
+        "attempt": "sage-77-review-3-request",
+        "outcome": "posted",
+        "status": 201,
+        "comment": 27973,
+        "detail": "created"
+      },
+      "by": "sage",
+      "at": "2026-10-12T22:07:09.136Z",
+      "semantics": 2,
+      "result": {
+        "row": 77,
+        "round": 3,
+        "attempt": "sage-77-review-3-request",
+        "state": "posted",
+        "receipt": "ok sage-77-review-3-request.outcome rev 793 row 77 round 3 request sage-77-review-3-request posted comment 27973"
+      },
+      "viewSha": "3c5e390b8f7ec572d3997e5f52223162d27bdaaf13021a3c672b1564eee9f3aa"
    }
  ]
 }