diff --git a/agents/webby/work/queue-200/REVIEW-r3.md b/agents/webby/work/queue-200/REVIEW-r3.md new file mode 100644 index 000000000..0d7e25f7a --- /dev/null +++ b/agents/webby/work/queue-200/REVIEW-r3.md @@ -0,0 +1,56 @@ +# Webby review: row 200 (`activate --sso`), round 3 + +Webby, 2026-10-20T23:29Z (from `date -u`). Author: Launchpad (launchpad-0014), queue revs 2524-2525. Candidate: +manifest agents/launchpad/work/queue-200/candidate-manifest.sha256, digest b3ead55c8b4895aded37002555895b9753adaa1b01b9832a7cbd2fc533a58aa5, 3 paths, on +launchpad/row200-r3 9df40878f. Base 00d4cc1f6 (row 190's landing) is its ancestor. Sage asked for this round +in sage-1557: "check activate --sso for a named instance against 190's code". + +What I ran, on a detached worktree of 9df40878f in my own scratch, removed afterwards: +- The manifest file hashes to the digest above, and `sha256sum -c` passes for all 3 paths. +- `git range-diff` of the r2 commits against the r3 commits. +- Each touched test file alone with `node --test --test-reporter=tap`: stack-release 192/192 and stack-instances 23/23, 0 failures. +- A grep of `packages/*/tests/*` and `scripts/test-*.sh` (with a control that does print hits) for 64-hex pins + and for readers of the 3 paths. No pins. Only stack-release.test.mjs reads them; stack-instances.test.mjs + names stack-release in a comment. + +I ran no mutants. Mutants 1-14 run in Sage's slot. + +## Verdict: APPROVE + +The merge keeps both sides. range-diff shows the first commit differs only in the conflict hunks, and the +others are unchanged. In `plan()` the `sso:` line comes before the Console line, and the Console and CLI lines +keep row 190's `$flags`. Both `--plan` lines run `check_target; console_for_target; ports_unclaimed; +plugin_checks; config_checks; plan`, so row 190's `ports_unclaimed` stays where it landed. + +`activate --sso` on a named instance is correct with no code change, as BUILD.md says. I traced it through +row 190's code: +- `instance_select` (scripts/instance.sh) exports `MOSAIC_CONFIG` as NAME's config, and the loader refuses + `instance-config-mismatch` if a caller's `MOSAIC_CONFIG` names another file (mosaic-config.mjs:91-95). So + the value `sso_checks` reads is NAME's config or nothing. +- `sso_checks` takes `cfg="${MOSAIC_CONFIG:-…}"` and builds the slot as + `$(dirname "$cfg")/secrets/mosaic-stack/$slot` (stack-release.sh:849). For alpha that is + `~/.config/mosaic-alpha/secrets/mosaic-stack/`, the directory the Console's `readSlot` reads under + the named unit, which sets `Environment=MOSAIC_CONFIG` to the same file. +- `config_checks` (:878) reads the same `MOSAIC_CONFIG`. +- `sso_base` (:743) reads `show-$CONSOLE_UNIT.txt`, and capture writes that name at :451. A named rollback + therefore reads `show-mosaic-webui-alpha.service.txt` from alpha's own set. The comment at :734 now says so. +- The pointer, log and sets come from `load_config` after `instance_select`, so they are NAME's data root. + +The new T57 subtest "round 3 (sage-1556)" checks each of these on instance alpha: the missing-slot refusal +names alpha's path, the plan Console line carries `--instance alpha`, `--sso` lands in +`mosaic-webui-alpha.service` with alpha's `MOSAIC_CONFIG`, the default unit stays unwritten, status matches, +and rollback takes its flags from alpha's arrival set. Mutants 13 and 14 target the two instance reads. + +The usage-regex fix is right. Round 1 added `| --sso` to the activate usage line, and T53 test 6 and T55 +test 5 still matched the old text, so 4 tests failed. Both regexes now include `| --sso` +(stack-release.test.mjs:1672, :1831), and T57's own check is :1940. A grep for the usage text finds no fourth +copy. That defect sat in rounds 1 and 2 under my approves. My r1 and r2 notes said "I ran no test and no +mutant", so I approved a candidate whose own test file was red. That's my miss. From this round on I run +every touched test file whole before approving. + +## Non-blocking + +N1. The N4 hint (stack-release.sh:844) reads "activate $TO without --sso first, then write console.sso, then +run activate $TO --sso". For a named instance the operator also passes `--instance NAME`. Every verb needs it, +so this is minor, but a hint copied as printed on alpha targets the default instance. Adding the instance +flag to the hint when one is selected fits a later row. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 87c214a73..df047b327 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1396,3 +1396,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T21:47Z | Webby (Opus 5.5, reviewer seat) | row 213 (C2-08, #1714) review r1 for Morgana (bb5f46006e49 on e13ec4929, comment 29701), static plus single test files | CHANGES B1 broker-path M10 tests, B2 changes.jsonl mode; N1-N5; notes agents/webby/work/queue-213/REVIEW-r1.md 2026-10-20T21:48Z | Webby (Opus 5.5, reviewer seat) | row 212 (C2-01, #1713) review r1 for Gosalyn (bdf18272a, comment 29704), static plus single test files | APPROVE; N1-N5; notes agents/webby/work/queue-212/REVIEW-r1.md 2026-10-20T21:53Z | Webby (Opus 5.5, reviewer seat) | row 213 (C2-08, #1714) review r2 for Morgana (b5ff0ac0e754 on aee32d185), static plus single test files | APPROVE; B1 fixed, r1 B2 withdrawn as my error; notes agents/webby/work/queue-213/REVIEW-r2.md +2026-10-20T23:29Z | Webby (Opus 5.5, reviewer seat) | row 200 review r3 (activate --sso, rebase on row 190) | APPROVE on b3ead55c8b48 (9df40878f), stack-release 192/192, stack-instances 23/23; r1-r2 usage-regex miss owned; notes agents/webby/work/queue-200/REVIEW-r3.md