row 163 r2: tests for Filbert's F1-F3 (R14 end checks, R15 signal trap, env ref, data-root-scratch, launches dir); read-only Registry never writes (N1)

2026-10-20 10:10:27 -05:00
1 parent 4be3f6aece
commit 2a5f3a3a0d
@@ -1736,6 +1736,9 @@ function rHost(){
 const db=new (process.getBuiltinModule('node:sqlite').DatabaseSync)(path.join(data,'bus','bus.sqlite'));
 db.prepare("INSERT OR REPLACE INTO meta(key,value) VALUES('fixture_host_start',?)").run(at);db.close();
 fs.writeFileSync(state,JSON.stringify({host:{business:b,pid:process.pid,live:true,startedAt:at,notifier:'off'},boot:{ok:true,business:b,at}}));
+ if(fault('host-launches-dir'))fs.mkdirSync(path.join(data,'launches'));
+ // host-touches lists files a careless host would write: the live config, business file or backup.
+ if(fault('host-touches'))for(const f of fs.readFileSync(path.join(home,'faults','host-touches'),'utf8').split('\n').filter(Boolean))fs.appendFileSync(f,'x');
 if(!off||fault('host-launches')){
  fs.appendFileSync(path.join(home,'starts.log'),`pm-${b}\n`);
  fs.mkdirSync(path.join(data,'bus-host'),{recursive:true});
@@ -1832,6 +1835,7 @@ const untouched=(e)=>JSON.stringify([...[e.store,e.cfg,e.biz,e.pointer].map((f)=
 async function rehearse(e,id,...args){
 const ch=spawn('bash',[e.sr??SR,'rehearse',id,'acme',...args,'--copies',RCOPIES,'--bin',e.bin],{env:e.env,stdio:['ignore','pipe','pipe']});
 let out='',err='';ch.stdout.on('data',(d)=>{out+=d});ch.stderr.on('data',(d)=>{err+=d});
+ e.during?.(ch);
 const timer=setTimeout(()=>ch.kill('SIGKILL'),120000);
 const [code]=await once(ch,'close');clearTimeout(timer);
 const m=/\nrehearsal directory: (.*)\n$/.exec(out);
@@ -1913,8 +1917,8 @@ test('R3 a failing migration gives REHEARSAL_FAIL migrate and starts nothing',as
 assert.equal(untouched(e),before);
 });

-test('R4 a host that does not start, does not answer status, reports another pid, launches anyway or keeps its lock each fails by name',async(t)=>{
- for(const [f,name,why] of [[`host-fails-${B}`,'host-up','exited'],[`status-${B}`,'bus-status','bus status failed'],['status-other-host','bus-status','the host this run started'],['host-launches','no-session','bus-host/sessions.json'],['host-keeps-lock','host-released-store','writer.lock is still there']]){
+test('R4 a host that does not start, does not answer status, reports another pid, launches anyway, makes a launches directory or keeps its lock each fails by name',async(t)=>{
+ for(const [f,name,why] of [[`host-fails-${B}`,'host-up','exited'],[`status-${B}`,'bus-status','bus status failed'],['status-other-host','bus-status','the host this run started'],['host-launches','no-session','bus-host/sessions.json'],['host-launches-dir','no-session','found launches under'],['host-keeps-lock','host-released-store','writer.lock is still there']]){
  const e=await rmk(t),before=untouched(e);rfault(e,f);
  const r=await rehearse(e,B,'--backup',e.act,'--port',await freePort(),'--timeout','3');
  assert.equal(r.code,1,f+r.out+r.err);
@@ -1964,7 +1968,7 @@ test('R8 a scratch port in use or reserved refuses, and the rehearsal takes no o
 assert.equal(untouched(e),before);
 });

-test('R9 mos-0963: a role reference left outside placeholders/ fails credential-ref-live before the host starts',async(t)=>{
+test('R9 mos-0963: a role reference left outside placeholders/, or left on an env variable, fails credential-ref-live before the host starts',async(t)=>{
 const e=await rmk(t);
 // The live pm gitea reference names a file that is there, as a live token would be.
 const tok=join(e.root,'live-gitea.token');writeFileSync(tok,'live-token-value',{mode:0o600});
@@ -1977,6 +1981,14 @@ test('R9 mos-0963: a role reference left outside placeholders/ fails credential-
 assert.deepEqual(r.names.slice(-3),['FAIL credential-ref-live','PASS backup-unchanged','PASS live-config-unchanged']);
 assert.equal(existsSync(rh(e,'host-args.log')),false);assert.equal(existsSync(rh(e,'console-args.log')),false);
 assert.equal(untouched(e),before);
+ // An env reference names no file at all; the guard says which variable it is.
+ const f=await rmk(t);
+ const fb=JSON.parse(readFileSync(f.biz,'utf8'));const {file,...rest}=fb.roles.pm.credentials.gitea;fb.roles.pm.credentials.gitea={...rest,env:'REHEARSAL_GITEA_TOKEN'};writeFileSync(f.biz,JSON.stringify(fb,null,2)+'\n',{mode:0o600});
+ ownScript(f,'for(const [name,r] of Object.entries(b.roles??{})){strip(r?.vars);swap(name,r?.credentials)}','for(const [name,r] of Object.entries(b.roles??{})){strip(r?.vars);if(name!=="pm")swap(name,r?.credentials)}');
+ const s=await rehearse(f,B,'--backup',f.act,'--port',await freePort(),'--timeout','3');
+ assert.equal(s.code,1,s.out+s.err);
+ assert.ok(s.out.includes('FAIL credential-ref-live: pm gitea is env REHEARSAL_GITEA_TOKEN\n'),s.out);
+ assert.equal(existsSync(rh(f,'host-args.log')),false);
 });

 test('R10 mos-0962: a scratch business that still sets a tracker fails tracker-configured',async(t)=>{
@@ -1991,7 +2003,7 @@ test('R10 mos-0962: a scratch business that still sets a tracker fails tracker-c
 assert.equal(existsSync(rh(e,'host-args.log')),false);
 });

-test('R11 mos-0961: a scratch config on the live data root, or a sessions.json naming a running pid, refuses by name',async(t)=>{
+test('R11 mos-0961: a scratch config on the live data root or on any root but the scratch one, or a sessions.json naming a running pid, refuses by name',async(t)=>{
 // mosaic-config already refuses the live path itself, which contains the scratch config directory;
 // the guard catches a path that reaches the live data root through a link.
 const e=await rmk(t),link=join(e.root,'live-link');symlinkSync(e.data,link);
@@ -2000,6 +2012,15 @@ test('R11 mos-0961: a scratch config on the live data root, or a sessions.json n
 assert.equal(r.code,1,r.out+r.err);
 assert.ok(r.out.includes(`FAIL data-root-live: the scratch config names dataRoot ${link}, which resolves to the live data root ${e.data}\n`),r.out);
 assert.equal(existsSync(rh(e,'host-args.log')),false);
+ // A root that is neither live nor this rehearsal's, and one that is not there.
+ for(const [dir,made,msg] of [['other-root',true,(d,R)=>`the scratch config resolves to ${d}, not ${join(R,'data')}`],['no-root',false,(d)=>`${d} does not exist`]]){
+  const g=await rmk(t),d=join(g.root,dir);if(made)mkdirSync(d);
+  ownScript(g,'c.dataRoot=data;',`c.dataRoot=${JSON.stringify(d)};`);
+  const q=await rehearse(g,B,'--backup',g.act,'--port',await freePort(),'--timeout','3');
+  assert.equal(q.code,1,dir+q.out+q.err);
+  assert.ok(q.out.includes(`FAIL data-root-scratch: ${msg(d,q.dir)}\n`),dir+q.out);
+  assert.equal(existsSync(rh(g,'host-args.log')),false);
+ }
 const f=await rmk(t);
 ownScript(f,`printf '{"notifyVersion":1,"binding":null}\\n' > "$R/data/notify/$BUSINESS/notify.json"`,`printf '{"notifyVersion":1,"binding":null}\\n' > "$R/data/notify/$BUSINESS/notify.json" && mkdir "$R/data/bus-host" && printf '{"sessionsVersion":1,"sessions":[{"pid":%s}]}\\n' "$$" > "$R/data/bus-host/sessions.json"`);
 const s=await rehearse(f,B,'--backup',f.act,'--port',await freePort(),'--timeout','3');
@@ -2037,3 +2058,29 @@ test('R13 the pre-checks: an old copy, a backup that fails its sums, a missing b
 assert.deepEqual([...rDirs(e),...rDirs(f),...rDirs(g)],[]);
 assert.equal(untouched(e),before);
 });
+
+test('R14 a host that writes the live config, the live business file or the backup fails the end check by name',async(t)=>{
+ for(const [pick,name] of [[(e)=>e.cfg,'live-config-unchanged'],[(e)=>e.biz,'live-config-unchanged'],[(e)=>join(e.backup,'bus','bus.sqlite'),'backup-unchanged']]){
+  const e=await rmk(t),f=pick(e);rfault(e,'host-touches');writeFileSync(rh(e,'faults','host-touches'),`${f}\n`);
+  const r=await rehearse(e,B,'--backup',e.act,'--port',await freePort(),'--timeout','10');
+  assert.equal(r.code,1,f+r.out+r.err);
+  assert.deepEqual(r.names.filter((n)=>n.startsWith('FAIL')),[`FAIL ${name}`],f+r.out);
+  assert.ok(r.names.includes('PASS gate')&&r.names.includes('PASS host-stopped'),f+r.out);
+  assert.ok(r.out.endsWith(`REHEARSAL_FAIL\nrehearsal directory: ${r.dir}\n`),r.out);
+ }
+});
+
+test('R15 a rehearsal stopped by TERM, INT or HUP fails signal and still stops the host and Console and runs the end checks',async(t)=>{
+ for(const sig of ['SIGTERM','SIGINT','SIGHUP']){
+  // The Console never answers /healthz, so the gate is still waiting when the signal comes.
+  const e=await rmk(t);rfault(e,`healthz-${B}`);
+  e.during=async(ch)=>{for(let i=0;i<200&&!existsSync(rh(e,'console-args.log'));i++)await new Promise((r)=>setTimeout(r,50));ch.kill(sig)};
+  const r=await rehearse(e,B,'--backup',e.act,'--port',await freePort(),'--timeout','30');
+  assert.equal(r.code,1,sig+r.out+r.err);
+  assert.deepEqual(r.names,[...PRE,'PASS migration','FAIL signal','PASS console-stopped','PASS host-stopped','PASS host-released-store','PASS backup-unchanged','PASS live-config-unchanged'],sig+r.out);
+  assert.ok(r.out.includes('FAIL signal: the rehearsal was interrupted\n'),r.out);
+  assert.ok(r.out.endsWith(`REHEARSAL_FAIL\nrehearsal directory: ${r.dir}\n`),r.out);
+  const pid=JSON.parse(readFileSync(join(r.dir,'data','fixture-host.json'),'utf8')).host.pid;
+  assert.equal(existsSync(`/proc/${pid}`),false,`${sig}: host pid ${pid} is still there`);
+ }
+});
@@ -187,7 +187,7 @@ export function endReason(code, signal) {
 // The host's view of its running sessions, kept in memory and mirrored to
 // sessions.json for `mosaic stop` and `mosaic launches list`.
 // readOnly (row 163, a --no-launch host): sessions.json stays as an earlier host left it, so a
-// later host still finds and ends those runs, and add() refuses.
+// later host still finds and ends those runs. add() refuses, and nothing writes the file.
 export class Registry {
  #dataRoot;
  #sessions = [];
@@ -195,7 +195,7 @@ export class Registry {
  constructor(dataRoot, { readOnly = false } = {}) {
    this.#dataRoot = dataRoot;
    this.#readOnly = readOnly;
-    if (!readOnly) this.#write();
+    this.#write();
  }
  get sessions() {
    return this.#sessions.map((s) => ({ ...s }));
@@ -218,6 +218,7 @@ export class Registry {
    return this.#sessions.find((s) => s.business === business && s.instance === instance && (s.thread ?? null) === thread) ?? null;
  }
  #write() {
+    if (this.#readOnly) return;
    const file = sessionsFile(this.#dataRoot);
    mkdirSync(dirname(file), { recursive: true, mode: 0o700 });
    const tmp = `${file}.${process.pid}.tmp`;
@@ -134,7 +134,7 @@ test("Registry mirrors to sessions.json; readSessions marks live entries; bad fi
 });

 // Row 163: a --no-launch host's registry leaves an earlier host's sessions.json as it was.
-test("a read-only Registry never writes sessions.json and refuses add()", (t) => {
+test("a read-only Registry never writes sessions.json, refuses add() and leaves the file on remove()", (t) => {
  const root = scratch(t);
  new Registry(root).add({ business: "acme", instance: "chief", run: "r1", runnerPid: process.pid, runnerStartTime: startTimeOf(process.pid) });
  const before = readFileSync(sessionsFile(root), "utf8");
@@ -143,6 +143,8 @@ test("a read-only Registry never writes sessions.json and refuses add()", (t) =>
  assert.deepEqual(r.sessions, []);
  assert.throws(() => r.add({ business: "acme", instance: "coder", run: "r2" }), (e) => e instanceof SeatError && /keeps no sessions/.test(e.message));
  assert.equal(readFileSync(sessionsFile(root), "utf8"), before);
+  r.remove("acme", "r1");
+  assert.equal(readFileSync(sessionsFile(root), "utf8"), before);
  const empty = scratch(t);
  new Registry(empty, { readOnly: true });
  assert.equal(existsSync(sessionsFile(empty)), false);