mosaicstack/stack
25
0
Fork 1
Code Issues 365 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: row 112 round 1 in review, Sage verdict and correction note (#1606, revs 1103-1107)

Browse Source 
Darkwing's start and in-review revs 1103-1105, Sage's round 1 record
1106 (approve, comment 28377) and note 1107 recording its replacement
by changes in comment 28378.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-14 10:52:47 -05:00
co-authored by Claude Opus 5.5
parent 837f996fc1
commit 2d5b59d08e
2 changed files with 173 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 1102 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 1107 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -148,7 +148,7 @@ Generated from `docs/plans/queue.json` revision 1102 by `queue render`. Do not e
| 109 | PM: a new run reads current launch state and task status before it plans | researcher; reviewers filbert | #1603 | done | — | Filbert approves on #1603 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and re-pin under Mos's go (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § A new PM run reads current launch state and task status before it plans | Landed badfa52b9, pushed. verify-commit ok (11 paths). Sage gate on 9774d70db plus row109.patch: every package suite and every script suite green on the first run, skipped 0 in bus, harness and seat. #1603 comment 28348, closed. Vikunja #259 stays open until the re-pin is live and a fresh PM run reads allowed. |
| 110 | Bus tester identity for PM tests, replacing the tmux path (Q134 A) | darkwing; reviewers filbert, sage | #1604 | done | 106 done, 109 done | Filbert and Sage approve on #1604 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy, re-pin and bus restart under Mos's go; tmux path retired by Mos (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § Bus tester identity for PM tests | Landed 179697a8a (round 2 manifest bdaf7f47, verify-commit ok), pushed; #1604 closed (28368). Not live: needs new copy, re-pin and bus restart under Mos's go, and bus.tester true in the business file, held under decision 104 until Q135. Gate flakes outside the row: Vikunja #262, #263. |
| 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. |
| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | briefed | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | — |
| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | in-review, round 1, request posted | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
<!-- mosaic-queue:end -->
docs/plans/queue.json
+171 -6
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 1102,
"revision": 1107,
"rows": [
{
"id": 1,
@@ -10107,7 +10107,7 @@
"closes": [
1606
],
"state": "briefed",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -10123,12 +10123,58 @@
"filbert",
"sage"
],
"review": null,
"claim": null,
"note": null,
"review": {
"rounds": [
{
"n": 1,
"op": "darkwing-112-review-1",
"by": "darkwing",
"at": "2026-10-14T15:48:19.000Z",
"issue": 1606,
"candidate": {
"kind": "manifest",
"digest": "ac34ebd094fb3bb17d1dd14b8f6e0ca53d661e176ef42463dd5f5c8ecf683d32",
"text": "ae3e68719b5a2b368ef018d40ad13a8e1e1cd3530a8ad58d3721194a81ad5eda packages/bus/README.md\n579093ec5b1acaf32e4cef94ff4b3d253471c576544a84860aa45a0844089b02 packages/bus/src/broker.mjs\nf374f7ac00f7645823957452824cf00f4088f1073780ec78a79888d04b30e3fd packages/bus/tests/broker.test.mjs\n1873d65873a2b631f188c3ebe2848623e27c06dc207daf632f33b930e150289d packages/harness/src/tools.mjs\nff9bcfbddc7a0dfbcd6faf354f60d1cbd0d2f11c87c60e124350f109d9517d9e packages/harness/tests/tools.test.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "darkwing-112-review-1",
"by": "darkwing",
"at": "2026-10-14T15:48:19.000Z",
"state": "posted",
"comment": 28376,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 28376,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": [
{
"reviewer": "sage",
"op": "sage-112-review-1",
"at": "2026-10-14T15:51:18.625Z",
"verdict": "approve",
"comment": 28377,
"candidate": "ac34ebd094fb3bb17d1dd14b8f6e0ca53d661e176ef42463dd5f5c8ecf683d32"
}
]
}
]
},
"claim": {
"seat": "darkwing",
"op": "darkwing-112-start-1"
},
"note": "Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix.",
"blockedReason": null,
"createdAt": "2026-10-14T15:36:36.626Z",
"updatedAt": "2026-10-14T15:36:44.453Z",
"updatedAt": "2026-10-14T15:52:04.940Z",
"updatedBy": "sage"
}
],
@@ -39258,6 +39304,125 @@
"receipt": "ok sage-112-briefed rev 1102 row 112 queued→briefed"
},
"viewSha": "04a0d30cb109b5535f2c3fbf0b0f62456991e21948e784490227ab66cf8fe38d"
},
{
"rev": 1103,
"op": "darkwing-112-start-1",
"verb": "move",
"args": {
"id": 112,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "darkwing",
"at": "2026-10-14T15:38:32.253Z",
"semantics": 2,
"result": {
"row": 112,
"from": "briefed",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok darkwing-112-start-1 rev 1103 row 112 briefed→in-progress"
},
"viewSha": "e914a956b873884db2a257d74fa9d66d7da24a872cc371d6d5870b0e90fd8a01"
},
{
"rev": 1104,
"op": "darkwing-112-review-1",
"verb": "move",
"args": {
"id": 112,
"to": "in-review",
"reason": null,
"candidate": "agents/darkwing/work/queue-112/r1/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "darkwing",
"at": "2026-10-14T15:48:19.000Z",
"semantics": 2,
"result": {
"row": 112,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1606,
"candidate": {
"kind": "manifest",
"digest": "ac34ebd094fb3bb17d1dd14b8f6e0ca53d661e176ef42463dd5f5c8ecf683d32",
"text": "ae3e68719b5a2b368ef018d40ad13a8e1e1cd3530a8ad58d3721194a81ad5eda packages/bus/README.md\n579093ec5b1acaf32e4cef94ff4b3d253471c576544a84860aa45a0844089b02 packages/bus/src/broker.mjs\nf374f7ac00f7645823957452824cf00f4088f1073780ec78a79888d04b30e3fd packages/bus/tests/broker.test.mjs\n1873d65873a2b631f188c3ebe2848623e27c06dc207daf632f33b930e150289d packages/harness/src/tools.mjs\nff9bcfbddc7a0dfbcd6faf354f60d1cbd0d2f11c87c60e124350f109d9517d9e packages/harness/tests/tools.test.mjs\n"
},
"receipt": "ok darkwing-112-review-1 rev 1104 row 112 in-progress→in-review round 1 on #1606; request darkwing-112-review-1 requesting"
},
"viewSha": "1891e46a51af07127526d076381af64c5e8b6781131a119d5b0190e4d0981fbb"
},
{
"rev": 1105,
"op": "darkwing-112-review-1.outcome",
"verb": "review-outcome",
"args": {
"id": 112,
"attempt": "darkwing-112-review-1",
"outcome": "posted",
"status": 201,
"comment": 28376,
"detail": "created"
},
"by": "darkwing",
"at": "2026-10-14T15:48:23.866Z",
"semantics": 2,
"result": {
"row": 112,
"round": 1,
"attempt": "darkwing-112-review-1",
"state": "posted",
"receipt": "ok darkwing-112-review-1.outcome rev 1105 row 112 round 1 request darkwing-112-review-1 posted comment 28376"
},
"viewSha": "4db23f36bdde4c12b0fd9ff0c956a71a4ead801834c62720b9eb79806b958321"
},
{
"rev": 1106,
"op": "sage-112-review-1",
"verb": "review-record",
"args": {
"id": 112,
"verdict": "approve",
"comment": 28377,
"candidate": "ac34ebd094fb3bb17d1dd14b8f6e0ca53d661e176ef42463dd5f5c8ecf683d32"
},
"by": "sage",
"at": "2026-10-14T15:51:18.625Z",
"semantics": 2,
"result": {
"row": 112,
"round": 1,
"verdict": "approve",
"receipt": "ok sage-112-review-1 rev 1106 row 112 round 1 approve by sage (comment 28377)"
},
"viewSha": "9809396403f45745c455470560882765626652bde04e2942e981a087c1fcd830"
},
{
"rev": 1107,
"op": "sage-112-note-1",
"verb": "note",
"args": {
"id": 112,
"text": "Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix."
},
"by": "sage",
"at": "2026-10-14T15:52:04.940Z",
"semantics": 2,
"result": {
"row": 112,
"field": "note",
"receipt": "ok sage-112-note-1 rev 1107 row 112 note"
},
"viewSha": "35570d4f099dea07e05b08510e336216215c9e426e132ebe8c478f7433c5ee7d"
}
]
}