guides: state the decree, drop the mechanism
ci/woodpecker/pr/ci Pipeline failed

The #1280 prohibition carried an explanation of how the tools misattribute and
why the failure is invisible from inside them. A reader who is not going to use
the tool cannot act on any of it. Same for rule 2's closing clause about what
reviews commonly miss. Both cut to the decree and the corrective action.

Rules 1 and 3-12 keep their trailing sentences: those are corrective actions or
the detail that makes the case recognizable, not justification.
This commit is contained in:
fred
2026-08-18 18:25:47 -05:00
parent efb3c3a10c
commit 2fd102e6af
@@ -19,11 +19,9 @@ An estate MAY carry a documented exception for a repository whose gates are comm
than review. Such an exception belongs in that estate's own working copy of this guide, is
scoped to the named repository, and is never precedent for a second one.
**Do not use `pr-review.sh` or `issue-comment.sh` to post a verdict** (mosaicstack#1280). Both
ignore the resolved identity and attribute the record to `mos-dt-0`, and the read-back verifies
green, so the failure is invisible from inside the tool. Post through a direct authenticated API
call as your own seat, or hand the verdict to the requesting seat. Handing it over is a
legitimate delivery path, not a fallback.
**Do not use `pr-review.sh` or `issue-comment.sh` to post a verdict** (mosaicstack#1280). Post
through a direct authenticated API call as your own seat, or hand the verdict to the requesting
seat. Handing it over is a legitimate delivery path, not a fallback.
## Evidence Discipline (applies to every finding)
@@ -34,8 +32,7 @@ you saw. Every rule here was earned by a wrong conclusion that reached a report.
wrong result. "This looks fragile" is not a finding.
2. **A green check is not a result until you have shown it could go red.** Run the control. A
`0`, an empty result, or a column of identical values with no failing counterpart is a
non-result, and reporting it as a pass is the most common way a review misses the defect it
was called for.
non-result.
3. **Measurement and explanation are separate sentences.** Report the command and its output,
then, as its own sentence, what you think it means.
4. **Never widen the case you measured.** If you checked one path, the finding covers one path.