From 3dee8c4a7380c291b5da107222cb740357ab09bb Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Wed, 21 Oct 2026 22:12:01 -0500 Subject: [PATCH] webby: row 191 da4334806 static look, no blockers, and session line --- agents/webby/work/queue-191/REVIEW-layout.md | 58 ++++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 59 insertions(+) diff --git a/agents/webby/work/queue-191/REVIEW-layout.md b/agents/webby/work/queue-191/REVIEW-layout.md index 59f92a2de..a4c31ea52 100644 --- a/agents/webby/work/queue-191/REVIEW-layout.md +++ b/agents/webby/work/queue-191/REVIEW-layout.md @@ -252,3 +252,61 @@ non-sticky, withdraws the sage-2372 long-nav visibility requirement and rules ou scroller. The scroller existed only to meet that requirement, so S1-S5 are withdrawn. R1-R6 stand as written, with ordinary nav.tree overflow:auto. Under R6, I still want the region and nav heights at 1440x420 on the debug run. + +## Static look at da4334806 (rocko 03:10:31Z): no blockers + +Read at 2026-10-22T03:12Z (from `date -u`), git only. One commit on 5cd32f4c1 touching index.html, +processing.css, three test files and BUILD.md. Nothing has run. Manifest digest 245dceb1 (88 paths), as +Rocko reported. I haven't recomputed it, so that's for the manifest round. + +**R1 markup.** The region div moves byte-for-byte to nav.tree's first child, before the Console h2. +Its id, class, role=region, aria-label, role=status and aria-live are all unchanged. The banner keeps its +place in body, before .frame. processing.js is unchanged. + +**R2 descendant rules.** `.tree .processing-controls .btn {margin:0; order:0}` and `.small {margin:0; +flex-basis:100%}` are (0,3,0) and sit outside any media query, so they beat console.css:21/:40, live.css:5/:10 and shell.css:147 (all (0,2,0)) +at every width. The base `.btn` (shared/app.css:60) has no margin, so `margin:0` changes nothing on its +own. `.processing-controls p {margin:0}` and the note/receipt `flex-basis:100%` already held, so the +`.small` reset only cancels the tree rules. console.css:21 `justify-content:center` still reaches the +buttons. That's harmless. No other `.tree` or `nav` descendant rule matches the controls. + +**R3 below 760.** `.tree > .processing-controls {flex-basis:100%}` at <=759 puts the region on its own +line ahead of the Console title. The new browser test checks Stop's top against #projects' top at 400 px. + +**R4.** The body grid, the grid-row rules, the controls' margin-left and `.frame {min-height:0}` are all +gone. With no body rule left in processing.css, shell.css:135 lifts the frame to 100vh - 86 again. +`.frame > .tree {position:fixed}`, the content column and the nav widths stay. + +**Height.** The body is block flow again: cmdbar 53, then the hidden banner at 0, then +.frame = max(914, C), then the footer 33. So the page is max(1000, 86 + C), with no bar term. #main's +content doesn't change in 191, so C is the pre-191 value that passed :380. The debug run confirms it. + +**R5 tests.** +- shell.test is additions only, at :389-399. :373-388 and every later old line are byte-identical, :380 + included. The new check puts the bar inside `.tree`'s rect, and the diagnostic logs heights. +- processing-ui :67 has the mos-1250 text, quoted old and new in BUILD.md. `
`. KS61 (into + #main) moves controlsAt past mainAt, so it fails. If the aside markup is ever renamed, inspectorAt is + -1, and `indexOf('', -1)` searches from 0. The check then fails closed, not open. +- processing-browser: the new test covers 400x1000, 1440x1000, 1440x420 and 800x420. Order is + checked at 800 and 400, inside the <=959 band where console.css:40 applies order:1, so KS62 is killed + there. Visibility and the cmdbar/viewport bounds are checked on load. +- Mutants: KS59 is a full revert of HTML and CSS, KS60 hides the controls (N2 met), KS61 moves them into + #main, KS62 drops the order reset. The total is 77. + +**sage-2378 checks.** +1. Ids, role and label are kept. +2. Nested in the nav landmark, which I accepted in webby-0106. +3. Stop is visible at 400 and 1440x1000, and above Projects at 400. +4. Every existing assertion is unchanged, other than :67 under mos-1250, and the shipped strings are + untouched. +5. The height arithmetic is above. + +**Notes, none blocking.** +- N1 (carried): :402 (the old :391) still repeats :380. +- N3: `focus()` then activeElement only proves Stop is focusable and enabled when that line runs. It + doesn't prove Tab order. Stop is `disabled` in the markup until processing.js reads the state. If the + fixture leaves it disabled, this line fails on the run, so it's a fixture question, not a test hole. + DOM order already gives cmdbar, Stop, nav links. +- N4: R6 reporting is in place (ROW191_LAYOUT lines). Sage's half-nav call at 1440x420 waits on those + numbers. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 696849296..7f1cef4f7 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1449,3 +1449,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-22T03:06Z | Webby (Opus 5.5, reviewer seat) | row 191 structure ruling for sage-2382: option (i) nested region, no sticky, conditions R1-R6 | ruled, sent webby-0106 2026-10-22T03:08Z | Webby (Opus 5.5, reviewer seat) | row 191 sticky vs sage-2372: separate links scroller under fixed controls, S1-S5 | ruled, sent webby-0107 2026-10-22T03:08Z | Webby (Opus 5.5, reviewer seat) | row 191 webby-0107 S1-S5 withdrawn under sage-2386; R1-R6 stand | reconciled, sent webby-0108 +2026-10-22T03:12Z | Webby (Opus 5.5, reviewer seat) | row 191 static look at da4334806 against R1-R6 and sage-2378 | no blockers, N1/N3/N4, sent webby-0109