docs(records): queue A1 review rulings, lead decision 23

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-09-26 18:25:52 -05:00
parent 556772ceb2
commit 40a02d2bcb
3 changed files with 22 additions and 0 deletions
@@ -410,3 +410,5 @@ are never rewritten or removed; corrections are new entries.
 2026-09-26T23:05:11Z | Sage (T3 Claude Code, thread 1ef1e4f8) | #1507 CHAT-02 Console commit | Dewey r2 d06de6a7, Filbert approve 160dd68d; ten pins verified; 186/186 serial, eight suites and chat checks green on the index. §2.3 item 6 deviation (newer, not reconcile) recorded. WebUI restart and live check next.
 2026-09-26T23:07:27Z | Sage (T3 Claude Code, thread 1ef1e4f8) | #1507 CHAT-02 live check | WebUI restarted (PID 2440752, 23:05:25Z); one board send to researcher, 2,618-char reply shown in full in the Console; screenshot committed; QUEUE row 5 state updated. CHAT-03 to Jason.
 2026-09-26T23:13:44Z | Sage (T3 Claude Code, thread 1ef1e4f8) | SetSpark approver owner, CHAT-03 charter | Jason delegated both. SetSpark fix: Sage subagent in shared-signals, Rocko reviews, Sage commits; compatibility stop on pending markers resolved as lead decision 21. CHAT-03 brief assigned to Dewey (decision 22). A1/A2 split recorded as decision 20. QUEUE row 5 updated.
+2026-09-26T23:25:08Z | Filbert (T3 Claude Code, thread 9cb9731e) | Queue A1 (#1508) code review, manifest 4319695a | changes requested: R1 matrix refusal tests (8.14), R2 review.issue null freeze, R3 evidence round; five Sage conditions met; review agents/filbert/work/queue-a1-review-2026-09-26.md 6933b885
+2026-09-26T23:25:52Z | Sage (T3 Claude Code, thread 1ef1e4f8) | #1508 queue A1 review rulings | Filbert changes requested (6933b885), five conditions met. Ruled review issue (explicit --issue when several) and set piece/gate privileged only, lead decision 23; N13 to DEFERRED and Darkwing.
@@ -263,3 +263,19 @@ which stay with him. Each item names who decided it and what happened.
    and keeps path authority clear of queue A1/A2 and the ledger. Following
    the plan page, Darkwing names the source author once the brief is
    approved. No real seat migration.
+23. **Queue A1 review rulings.** Filbert asked for changes (review
+    6933b885): all five conditions met, three small fixes R1 to R3. He left
+    two questions for Sage.
+    - The review issue: sorted issues make "the first issue" the lowest
+      number, so a row for #1508 that also lists #1495 would post reviews
+      on #1495. That is not the intent. `move in-review` refuses a row with
+      no issues. A row with one issue uses it. A row with several needs
+      `--issue <n>`, which must be one of the row's issues. Later rounds
+      keep the previous round's issue unless `--issue` names another. That
+      also fixes R2.
+    - `set piece` and `set gate` are privileged only. 8.7's field table
+      didn't list them, and the reason for the default is that piece and
+      gate change what a row is, not how far along it is.
+    Filbert's N13 (the nested `node --test` in `test-foundation.sh` and
+    `test-discord.sh`) is added to the DEFERRED entry. It goes to Darkwing
+    as a small reviewed item after the A1 delta, before A2.
@@ -165,6 +165,10 @@ at every gate. Started 2026-09-12 during the control board MVP.
  path with `env -u NODE_TEST_CONTEXT`, plus a test. Other suites that
  start `node --test` from inside a test run have not been checked, so
  they may be hiding failures. (2026-09-26, #1508)
+  Filbert's A1 review (6933b885, N13) found two: `test-foundation.sh` line
+  76 and `test-discord.sh` line 142 start a nested `node --test` without
+  clearing NODE_TEST_CONTEXT. Latent today, because neither runs under a
+  parent runner. Darkwing fixes both after the A1 delta (lead decision 23).

 ## Queue