docs(records): queue A1 review rulings, lead decision 23

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
2026-09-26 18:25:52 -05:00
co-authored by Claude Opus 5.5
parent 556772ceb2
commit 40a02d2bcb
3 changed files with 22 additions and 0 deletions
+16
View File
@@ -263,3 +263,19 @@ which stay with him. Each item names who decided it and what happened.
and keeps path authority clear of queue A1/A2 and the ledger. Following
the plan page, Darkwing names the source author once the brief is
approved. No real seat migration.
23. **Queue A1 review rulings.** Filbert asked for changes (review
6933b885): all five conditions met, three small fixes R1 to R3. He left
two questions for Sage.
- The review issue: sorted issues make "the first issue" the lowest
number, so a row for #1508 that also lists #1495 would post reviews
on #1495. That is not the intent. `move in-review` refuses a row with
no issues. A row with one issue uses it. A row with several needs
`--issue <n>`, which must be one of the row's issues. Later rounds
keep the previous round's issue unless `--issue` names another. That
also fixes R2.
- `set piece` and `set gate` are privileged only. 8.7's field table
didn't list them, and the reason for the default is that piece and
gate change what a row is, not how far along it is.
Filbert's N13 (the nested `node --test` in `test-foundation.sh` and
`test-discord.sh`) is added to the DEFERRED entry. It goes to Darkwing
as a small reviewed item after the A1 delta, before A2.
+4
View File
@@ -165,6 +165,10 @@ at every gate. Started 2026-09-12 during the control board MVP.
path with `env -u NODE_TEST_CONTEXT`, plus a test. Other suites that
start `node --test` from inside a test run have not been checked, so
they may be hiding failures. (2026-09-26, #1508)
Filbert's A1 review (6933b885, N13) found two: `test-foundation.sh` line
76 and `test-discord.sh` line 142 start a nested `node --test` without
clearing NODE_TEST_CONTEXT. Latent today, because neither runs under a
parent runner. Darkwing fixes both after the A1 delta (lead decision 23).
## Queue