diff --git a/agents/webby/work/queue-228/REVIEW-r1.md b/agents/webby/work/queue-228/REVIEW-r1.md new file mode 100644 index 000000000..7a3579b57 --- /dev/null +++ b/agents/webby/work/queue-228/REVIEW-r1.md @@ -0,0 +1,39 @@ +# Webby review: row 228 (row A, #1729), round 1, ZAI_API_KEY in the session env allowlist + +Webby, 2026-10-20T21:19Z (from `date -u`). Requested by Sage (sage-1495), request comment 29677. +Candidate: commit 4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67 on researcher/row228, base 088087ac9 (an +ancestor of origin/refactor), one commit, three files. Brief: "Brief: row A" in +docs/plans/2026-10-20_case2-rows.md on origin/refactor 32b54ac3b. I approved that brief in webby-0034. + +I ran `packages/seat/tests/session.test.mjs` alone on a `git archive` export of the candidate: 13 tests, +13 pass, 0 fail, skipped or cancelled. I took the mutant result from Researcher's +`out/mutants.log`. M1 removes `ZAI_API_KEY`, the new test reports failing, and the verdict is KILLED with +the restore sha256 matching. I didn't rerun the mutant. + +## Verdict: APPROVE + +Each item in the brief is in the candidate, and nothing beyond it: +- session.mjs:86: `"ZAI_API_KEY"` follows `OPENROUTER_API_KEY` on the provider line. Nothing else in + `ENV_ALLOW` changes, and `SESSION_CREDENTIALS` and `hasSessionCredential` don't change either. +- The new test checks membership and passthrough with `fixture-zai`, and checks that `ZAI_TOKEN` is + dropped. The existing allowlist test is unchanged. +- README :435-439 has the sentence the brief gives. At :714-716, "one line per variable" and the + every-provider-key sentence are in, and the "nothing in the repository creates or reads it" line is + left for C2-13a. + +No other test reads either changed file. A grep of `packages/*/tests` and `scripts/test-*.sh` for +`ENV_ALLOW`, `session.mjs` and `cli/README`, outside session.test.mjs itself, finds nothing, and no 64-hex +pin names them. The fixture value is made up, so no credential value appears. + +## Non-blocking + +N1. Sage asked me to judge the repeat. The new sentence ends "a shell inside any of them can read it". +The next sentence, which was already there, says "A shell the harness opens, Claude Code's `Bash` or Pi's +`bash`, can read them." The two say the same thing. Worse, "them" now follows a sentence whose subject is +"it", so its antecedent, "the same variables" two sentences back, is hard to find. This is my miss in +webby-0034: the brief dictated the sentence, and the candidate copied it exactly. It's doc-only, and no +test reads the README, so it doesn't block (decision 137). A fix for a later README touch, or at landing +if that's cheap: +- End the new sentence at "Claude Code ones included." +- Change the existing sentence to "A shell the harness opens, Claude Code's `Bash` or Pi's `bash`, can + read all of these variables." diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index a2a7849da..72d2f3f37 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1392,3 +1392,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T20:55Z | Webby (Opus 5.5, reviewer seat) | row A brief review (ZAI_API_KEY allowlist) for Sage/Gosalyn (a2d94b2c2, rows blob 81140d017441), static | approve, N1-N2; notes agents/webby/work/case2-rowA/REVIEW-brief.md 2026-10-20T21:01Z | Webby (Opus 5.5, reviewer seat) | Case 2 design r10 review (#416) for Gosalyn (4281b0064, blob 4a1860e698e0, two system units), static | changes B1 Console boot start is Jason's call, B2 PATH/NODE/FLAGS render, B3 hardening lines unlisted, N1-N5; notes agents/webby/work/case2-r10/REVIEW.md 2026-10-20T21:15:35Z | Webby (Opus 5.5, reviewer seat) | Case 2 design r11 review (#416) for Gosalyn (fb20a61b4 + eac92d956, rows blob 3a86d5f048dc), static | APPROVE, N1-N4; notes agents/webby/work/case2-r11/REVIEW.md +2026-10-20T21:19:21Z | Webby (Opus 5.5, reviewer seat) | row 228 (row A, #1729) review r1 for Researcher/Sage (4fa2ed1e3, comment 29677), static plus session.test.mjs 13/13 | APPROVE, N1 doc-only; notes agents/webby/work/queue-228/REVIEW-r1.md