queue: rev 390, row 55 round 1 changes requested (filbert)
Comment 27251 on #1544 names candidate 93fa48c1cdfe. R1: the decide question takes type-ahead and ignores stray keys. R2: cells() undercounts emoji below U+1F300. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
+1
-1
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
|
|||||||
|
|
||||||
<!-- mosaic-queue:begin -->
|
<!-- mosaic-queue:begin -->
|
||||||
|
|
||||||
Generated from `docs/plans/queue.json` revision 389 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
|
Generated from `docs/plans/queue.json` revision 390 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
|
||||||
|
|
||||||
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|
||||||
|---|---|---|---|---|---|---|---|---|
|
|---|---|---|---|---|---|---|---|---|
|
||||||
|
|||||||
+34
-4
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"version": 1,
|
"version": 1,
|
||||||
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
|
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
|
||||||
"revision": 389,
|
"revision": 390,
|
||||||
"rows": [
|
"rows": [
|
||||||
{
|
{
|
||||||
"id": 1,
|
"id": 1,
|
||||||
@@ -3958,7 +3958,16 @@
|
|||||||
}
|
}
|
||||||
],
|
],
|
||||||
"duplicateRisk": false,
|
"duplicateRisk": false,
|
||||||
"receipts": []
|
"receipts": [
|
||||||
|
{
|
||||||
|
"reviewer": "filbert",
|
||||||
|
"op": "filbert-55-review-1-verdict",
|
||||||
|
"at": "2026-10-11T18:10:52.786Z",
|
||||||
|
"verdict": "changes",
|
||||||
|
"comment": 27251,
|
||||||
|
"candidate": "93fa48c1cdfedbecca68e8bb28ad41abbcaf9679277a13e4f62e36c5b2a506de"
|
||||||
|
}
|
||||||
|
]
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
@@ -3969,8 +3978,8 @@
|
|||||||
"note": "Sage gate rerun 2026-10-11T18:02Z on 23d566d6 plus build.patch, candidate manifest 93fa48c1cdfe verified: packages/cli 97/0, packages/queue 150/0, every scripts/test-*.sh exit 0 with Docker on (test-task 98/0, live hello ran). dispatch.test.mjs ruled in scope (Darkwing 4acadaae). Waiting on dewey and filbert verdicts.",
|
"note": "Sage gate rerun 2026-10-11T18:02Z on 23d566d6 plus build.patch, candidate manifest 93fa48c1cdfe verified: packages/cli 97/0, packages/queue 150/0, every scripts/test-*.sh exit 0 with Docker on (test-task 98/0, live hello ran). dispatch.test.mjs ruled in scope (Darkwing 4acadaae). Waiting on dewey and filbert verdicts.",
|
||||||
"blockedReason": null,
|
"blockedReason": null,
|
||||||
"createdAt": "2026-10-10T16:36:15.309Z",
|
"createdAt": "2026-10-10T16:36:15.309Z",
|
||||||
"updatedAt": "2026-10-11T18:02:48.729Z",
|
"updatedAt": "2026-10-11T18:10:52.786Z",
|
||||||
"updatedBy": "sage"
|
"updatedBy": "filbert"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"id": 56,
|
"id": 56,
|
||||||
@@ -15416,6 +15425,27 @@
|
|||||||
"receipt": "ok note-55-sage-gate-20261011 rev 389 row 55 note"
|
"receipt": "ok note-55-sage-gate-20261011 rev 389 row 55 note"
|
||||||
},
|
},
|
||||||
"viewSha": "56b2a8c4697b0184e9d88c1034bbdd535b672a6c536856ebbee2688baecceedd"
|
"viewSha": "56b2a8c4697b0184e9d88c1034bbdd535b672a6c536856ebbee2688baecceedd"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"rev": 390,
|
||||||
|
"op": "filbert-55-review-1-verdict",
|
||||||
|
"verb": "review-record",
|
||||||
|
"args": {
|
||||||
|
"id": 55,
|
||||||
|
"verdict": "changes",
|
||||||
|
"comment": 27251,
|
||||||
|
"candidate": "93fa48c1cdfedbecca68e8bb28ad41abbcaf9679277a13e4f62e36c5b2a506de"
|
||||||
|
},
|
||||||
|
"by": "filbert",
|
||||||
|
"at": "2026-10-11T18:10:52.786Z",
|
||||||
|
"semantics": 2,
|
||||||
|
"result": {
|
||||||
|
"row": 55,
|
||||||
|
"round": 1,
|
||||||
|
"verdict": "changes",
|
||||||
|
"receipt": "ok filbert-55-review-1-verdict rev 390 row 55 round 1 changes by filbert (comment 27251)"
|
||||||
|
},
|
||||||
|
"viewSha": "5960ab5a7686fd3cd7435b1bf22ceb81e86b7b20708aa29af2c96fb2569f6b75"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user