diff --git a/BUILD-LOG.md b/BUILD-LOG.md index d629c039..bbfd18a9 100644 --- a/BUILD-LOG.md +++ b/BUILD-LOG.md @@ -1886,3 +1886,7 @@ Jason accepted the limited publication/planned-recovery outcome following the pl ## 2026-09-08 — #1498 skill/launcher mismatch before correction Owner authorized reviewed fix/commit/push without live restarts or deployment. Baseline 12ff5da7; offline launcher fixture exit 1 reproduced absent ms-agent-watch requirement. Replacement ms-watch and watch CLI exist; contract/ownership reconciliation and focused repair next. Other skills and private/WUI records excluded. + +## 2026-09-08 — #1498 reviewed repair published + +Independent APPROVED c4dd2ad8; repair f3dce3208877626043c521c6ef5076f9559309b0 pushed and remote verified. Nine file identities plus old-path deletion verified from committed tree; fresh archive fixture run 5/5 passed. Initial staged-path assertion failed on rename display and shell continued to commit; exact expanded-path and byte verification succeeded before push, recorded in completion receipt. No live operations. Other work preserved. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index a613f504..206a0455 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -145,3 +145,5 @@ are never rewritten or removed; corrections are new entries. - 2026-09-08 — darkwing — Jason accepted bounded #1497 publication/recovery trial after plain-language recommendation: "THAT is an executive brief. Proceed." Acceptance comment 25943 recorded, issue closed. Source 29c1defe and closeout 10448e41 remain unchanged; no WUI design or production acceptance. CURRENT returns to deferred registry review alignment only. - 2026-09-08 — darkwing — #1498 owner goal skill/launcher mismatch: isolated Pi launcher fixtures reproduced failure, stale required ms-agent-watch path absent while ms-watch replacement exists. Plan docs/plans/2026-09-08_skill-launcher-mismatch.md; no live launch or deployment. Other work preserved. + +- 2026-09-08 — darkwing for Filbert — #1498 SKILL-LAUNCHER-FILBERT-1 independently APPROVED c4dd2ad8; exact repair published f3dce320, remote verified, committed-tree fixtures 5/5 passed. Rename-display assertion issue reconciled before push via expanded path/byte verification; completion receipt preserves it. No live activation or unrelated changes. diff --git a/docs/plans/2026-09-08_skill-launcher-mismatch.md b/docs/plans/2026-09-08_skill-launcher-mismatch.md index 8f8ca0b1..2298f208 100644 --- a/docs/plans/2026-09-08_skill-launcher-mismatch.md +++ b/docs/plans/2026-09-08_skill-launcher-mismatch.md @@ -11,3 +11,7 @@ State: working. Issue #1498 created HTTP 201. No implementation or approval clai ## Verified correction Launcher now explicitly selects ms-watch; communications/proactive references match. Replacement skill documentation reconciled against the complete watch CLI: explicit repository sender, observable query side effects, real socket precedence, transport-only acknowledgement limits. Watch implementation itself unchanged. Added missing-ms-watch refusal controls for all three Pi agents and assertions for exact new skill path/absence of old path. Combined offline fixtures 5/5 passed, bash syntax and diff whitespace checks passed. No timers, real launchers or model calls. Next gate: independent frozen-candidate review before selective publication. + +## Completion + +Independently APPROVED at c4dd2ad8, repaired source committed/pushed at f3dce3208877626043c521c6ef5076f9559309b0; fresh remote matches. Exact committed identities and expanded rename path set verified. Archived committed-tree fixtures 5/5 pass. Completion receipt records the initial rename-display assertion failure honestly. No live effects; other work preserved. diff --git a/docs/plans/CURRENT.md b/docs/plans/CURRENT.md index 54712104..98e9bace 100644 --- a/docs/plans/CURRENT.md +++ b/docs/plans/CURRENT.md @@ -7,15 +7,16 @@ update this file to the next action). No ambiguity, no re-planning. ## Next action -Complete owner goal #1498: repair the skill/launcher mismatch through independent -review, selective commit and push. Plan: `docs/plans/2026-09-08_skill-launcher-mismatch.md`. -Local correction selects ms-watch, preserves missing-skill refusal and clarifies -watch transport limitations. Offline launcher fixtures 5/5 passed. Next gate is -independent frozen-candidate review. No live restart, timer arming or deployment. -Other new skills, private/WUI artifacts and held work remain untouched. +Review `docs/plans/2026-09-03_auth-provider-harness-registry.md` and reconcile +Gate 7 with later owner decisions and #53's workspace/session model. This is +registry review alignment only; no registry implementation is authorized. -Registry review alignment is deferred behind this explicit owner goal; no registry -implementation is authorized. +Owner goal #1498 completed: independently approved skill/launcher repair published +at f3dce3208877626043c521c6ef5076f9559309b0; fresh remote identity verified and +committed-tree offline fixtures 5/5 passed. Completion evidence: +`docs/plans/reviews/2026-09-08_skill-launcher-completion.md`. +No live restart, timer arming or deployment. Other new skills and private/WUI +artifacts remain untouched. This closes the bounded goal, not a new registry mandate. Jason accepted the bounded #1497 publication/recovery trial following the plain- language brief and said "Proceed." Issue #1497 is closed; acceptance receipt: diff --git a/docs/plans/reviews/2026-09-08_skill-launcher-completion.md b/docs/plans/reviews/2026-09-08_skill-launcher-completion.md new file mode 100644 index 00000000..26f79e38 --- /dev/null +++ b/docs/plans/reviews/2026-09-08_skill-launcher-completion.md @@ -0,0 +1,11 @@ +# #1498 completed + +Repair published on refactor at f3dce3208877626043c521c6ef5076f9559309b0, parent 12ff5da7df91f5343a59999af98b67518c15d6a4. Filbert independently approved manifest c4dd2ad8ec87138fc756aa3e7a3366dcec32fa8c5d1ecfa3736f746457568904: nine pinned files plus old skill deletion. Fresh origin/refactor matches the repair SHA after successful push. + +Post-commit verification expanded rename display into deletion/addition using git diff-tree --no-renames: exact approved path set and all committed SHA-256 identities match; old path absent. An initial staged-path assertion failed because Git displayed the rename as one path; the shell command still proceeded to commit because it lacked fail-fast chaining. This procedural error is preserved here, not called a passing precommit check. Before push the expanded path set, parent and every committed candidate byte were successfully verified, with no unauthorized files found. + +Offline tests passed 5/5 both in the live checkout and independently of unrelated files in a fresh archive of the committed tree. Reviewer separately reproduced the original three-agent missing-skill failure and the corrected five-test pass. No real launch, timer, model call, restart or deployment occurred. Other untracked skills and private/WUI artifacts remain untouched. + +The launcher selects ms-watch; all three Pi agents refuse missing ms-watch without state/capture side effects. Watch implementation is unchanged; replacement instructions accurately qualify legacy delivery logs, query effects and sender/socket selection. Loaded sessions retain their injected snapshots. Publication does not restart or update those sessions. + +The authorized goal was reviewed repair, commit and push, all met. Registry review remains separate queued work; no automatic implementation or live activation is authorized. diff --git a/docs/plans/reviews/2026-09-08_skill-launcher-review.json b/docs/plans/reviews/2026-09-08_skill-launcher-review.json new file mode 100644 index 00000000..dd53d572 --- /dev/null +++ b/docs/plans/reviews/2026-09-08_skill-launcher-review.json @@ -0,0 +1,20 @@ +{ + "issue": 1498, + "baseline": "12ff5da7df91f5343a59999af98b67518c15d6a4", + "snapshot": "/tmp/skill-launcher-review-5gh6v4v0", + "manifestSha256": "c4dd2ad8ec87138fc756aa3e7a3366dcec32fa8c5d1ecfa3736f746457568904", + "files": [ + "scripts/agent-host-dev.sh", + "scripts/test-darkwing-launch.mjs", + "skills/ms-watch/SKILL.md", + "skills/ms-communications/SKILL.md", + "skills/ms-proactive-agent/SKILL.md", + "docs/plans/2026-09-08_skill-launcher-mismatch.md", + "docs/plans/CURRENT.md", + "docs/SESSIONS.md", + "BUILD-LOG.md" + ], + "deletions": [ + "skills/ms-agent-watch/SKILL.md" + ] +} diff --git a/docs/plans/reviews/2026-09-08_skill-launcher-verdict.md b/docs/plans/reviews/2026-09-08_skill-launcher-verdict.md new file mode 100644 index 00000000..5095b9bd --- /dev/null +++ b/docs/plans/reviews/2026-09-08_skill-launcher-verdict.md @@ -0,0 +1,24 @@ +# SKILL-LAUNCHER-FILBERT-1 (#1498) — verdict + +Reviewer: Filbert (independent). Author: Darkwing. Conflict check: none; I had no authorship or prior review role in the mismatch repair or the ms-watch replacement. + +## Verdict: APPROVED + +Exact candidate: the nine files of snapshot `/tmp/skill-launcher-review-5gh6v4v0` at manifest SHA-256 `c4dd2ad8ec87138fc756aa3e7a3366dcec32fa8c5d1ecfa3736f746457568904`, plus the explicit deletion of `skills/ms-agent-watch/SKILL.md`, against baseline `12ff5da7df91f5343a59999af98b67518c15d6a4`. All nine hashes verified before and after review; snapshot unchanged. The metadata receipt `docs/plans/reviews/2026-09-08_skill-launcher-review.json` is a separate unit and was not treated as candidate source. + +## Independent verification + +- Delta confinement: launcher changes exactly one line (skill list `ms-agent-watch` → `ms-watch`); the test file adds only the missing-skill refusal controls and the exact-path assertions; `ms-communications` and `ms-proactive-agent` change one reference line each (rename only); `ms-watch/SKILL.md` is new to git, matching the declared pre-existing on-disk replacement; the three log/status files gain only the recorded additions. The deletion target is a tracked baseline file, so it is a real git deletion, not an untracked-file cleanup. +- Fail-closed selection: the launcher's existing per-skill presence check now guards `ms-watch`. The new fixture control (inside the per-agent loop, so all three Pi agents) removes the fixture's `skills/ms-watch/SKILL.md`, asserts `--check` fails with `missing skill: ms-watch`, and asserts neither `.pi/state` nor a fake-Pi capture is created; the captured-args assertions verify the exact `--skill …/skills/ms-watch` argument and the absence of the old path, with the ten-skill count still enforced. +- My own disposable trees (never the drifted live tree): + - Overlay tree (`git archive 12ff5da7` + nine files + declared deletion): `node --test scripts/test-rocko-launch.mjs scripts/test-darkwing-launch.mjs` — 5 tests, 5 pass, 0 fail, exit 0. + - Mismatch reproduction (baseline tree with only `skills/ms-agent-watch/SKILL.md` removed, simulating the live drift that produced the owner goal): the Pi suite fails 3 of 4 with `missing skill: ms-agent-watch` for each agent — independently confirming both the coordinator's observed baseline failure and that the mismatch was real, not cosmetic. +- Replacement-skill accuracy, read against baseline `tools/agent-watch/agent-watch.sh`: explicit sender override via `MOSAIC_AGENT_SEND` with the unreviewed `$HOME/.config/mosaic` fallback warning; socket precedence `--socket` > `MOSAIC_TMUX_SOCKET` > unique discovery with ambiguity refusal; `list`/`status` described as side-effecting (stale notices, messages), matching the CLI's notice logic; user-bus refusal with status exit codes 0/3/6 and no health inference from failed queries; sender exits 0 and 2 treated as terminal with the legacy `delivered` wording explicitly qualified as non-acknowledgement; interval floor 10 s and defaults 30 s/3600 s with `--repeat`/`--quiet-timeout` all matching the CLI. The skill claims no activation and no reliability guarantees, states that loading installs no timers, and scopes live watch operations to assignment authority. Watch runtime behavior itself was not redesigned; historical stale statements elsewhere were not rewritten. +- Docs and scope: the mismatch plan, CURRENT.md next-action block, SESSIONS line, and BUILD-LOG entry are accurate; registry review is deferred, not canceled; other untracked skills, private/WUI records, and held work are excluded structurally (the candidate touches only its nine files plus the one deletion). Added lines carry no private identifiers; the UUID/home-path hits in the full log files are baseline history already published at `29c1defe` and later commits. +- `bash -n` and `node --check` pass. No live launcher, timer/systemd command, watch call, model invocation, private read, source edit, or git write was performed by this review. + +## Conditions + +1. Commit exactly the nine reviewed files plus the declared `skills/ms-agent-watch/SKILL.md` deletion on `refactor` from this approval; any other byte change requires re-review. Push per the owner goal after commit; remote identity verified fresh afterward. +2. Register the shared-log entries and this verdict after the pin lifts, as with the #1497 closeout. +3. The goal is reviewed commit/push of this repair. No live activation, timer arming, restart, or deployment is authorized or implied; operator acceptance of the unrelated skill work is not.