mosaicstack/stack
25
0
Fork 1
Code Issues 358 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 304-307, row 51 round 2 review record, approve (filbert)

Browse Source 
Sweeps Dewey's uncommitted revs 304-306 (dewey-r51-rework-2,
dewey-51-review-2, dewey-51-review-2.outcome: row 51 round 2 in review).
Rev 307 is mine: filbert-r51-review-2, approve, #1537 comment 27074.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-10 01:52:39 -05:00
co-authored by Claude Opus 5.5
parent b7e9efb766
commit 535fcc5f6a
2 changed files with 146 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 303 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 307 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -87,7 +87,7 @@ Generated from `docs/plans/queue.json` revision 303 by `queue render`. Do not ed
| 48 | Test hygiene: commit.test exit wait and test-task Docker skip | sage; reviewers darkwing, filbert | #1534 | briefed | — | darkwing and filbert approve on #1534; queue node suite and every test-*.sh green, test-task shown with and without Docker (sage) | `docs/plans/2026-10-10_s5-follow-up-and-hygiene.md` § Test hygiene: commit.test exit wait and test-task Docker skip | Filbert's row 41 round 1 notes |
| 49 | Bus comment cursor across restarts | sage; reviewers darkwing, filbert | #1535 | queued | 41 done | darkwing and filbert approve on #1535; bus, tasks and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-10_s5-follow-up-and-hygiene.md` § Bus comment cursor across restarts | found in Q14 cutover planning; after S6 |
| 50 | Cohort scope release after a force stop | dewey; reviewers darkwing, filbert | #1536 | done | 47 done | darkwing and filbert approve on #1536; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-scope-release.md` § Cohort scope release after a force stop | Dewey's row 47 finding, comment 27037 |
| 51 | Cohort release follow-ups: engine exit, crash window and close | dewey; reviewers darkwing, filbert | #1537 | in-review, round 1, request posted | 50 done | darkwing and filbert approve on #1537; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § Cohort release follow-ups: engine exit, crash window and close | Row 50 deviation and review follow-ups, comment 27054 |
| 51 | Cohort release follow-ups: engine exit, crash window and close | dewey; reviewers darkwing, filbert | #1537 | in-review, round 2, request posted | 50 done | darkwing and filbert approve on #1537; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § Cohort release follow-ups: engine exit, crash window and close | Row 50 deviation and review follow-ups, comment 27054 |
| 52 | CHAT-01 engine-exit stop and release at engine exit | dewey; reviewers darkwing, filbert | #1538 | briefed | 51 done | darkwing and filbert approve on #1538 naming the four CHAT-01 hashes; chat-01 check.mjs passes; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § CHAT-01 engine-exit stop and release at engine exit | Decision 79, split from row 51 |
<!-- mosaic-queue:end -->
docs/plans/queue.json
+144 -3
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 303,
"revision": 307,
"rows": [
{
"id": 1,
@@ -3386,6 +3386,46 @@
"candidate": "2da94e3bcb64afbc5f70fe1cc888393a32b7988afd1cf2cd977d762b47c6ebf3"
}
]
},
{
"n": 2,
"op": "dewey-51-review-2",
"by": "dewey",
"at": "2026-10-10T06:40:57.743Z",
"issue": 1537,
"candidate": {
"kind": "manifest",
"digest": "c34039dc0d52b965bd73cc9f079ae7b253140d77713a3323abc4743f359f0c02",
"text": "d7ae740247a7dbd26bdcadfe97e1acf70121911d6fed69f4fc2408f483279ef8 agents/dewey/work/queue-51/evidence.md\naaefe3cd02ea25dc00c31d0f94ef4c74544b9929614618511be294aa314de9ce packages/conversation/README.md\nae9cd6f800d57412ff04da7673bff6b62d506ec4ac46a15d351a45a5087a8953 packages/conversation/src/controller.mjs\n6fada028358fbfe79f2a7dbda7fee8028142a833caed5bd3c2d4f00e861a19ec packages/conversation/tests/cohort.test.mjs\n3409fcce6ebb0281b5e018983a005b0c23b8641ba69cd25ea8aec6c161870d3b packages/conversation/tests/ctrl-child.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "dewey-51-review-2",
"by": "dewey",
"at": "2026-10-10T06:40:57.743Z",
"state": "posted",
"comment": 27072,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27072,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": [
{
"reviewer": "filbert",
"op": "filbert-r51-review-2",
"at": "2026-10-10T06:52:13.141Z",
"verdict": "approve",
"comment": 27074,
"candidate": "c34039dc0d52b965bd73cc9f079ae7b253140d77713a3323abc4743f359f0c02"
}
]
}
]
},
@@ -3396,8 +3436,8 @@
"note": "Row 50 deviation and review follow-ups, comment 27054",
"blockedReason": null,
"createdAt": "2026-10-10T05:14:40.739Z",
"updatedAt": "2026-10-10T06:11:12.851Z",
"updatedBy": "darkwing"
"updatedAt": "2026-10-10T06:52:13.141Z",
"updatedBy": "filbert"
},
{
"id": 52,
@@ -12271,6 +12311,107 @@
"receipt": "ok darkwing-r51-review-1 rev 303 row 51 round 1 changes by darkwing (comment 27071)"
},
"viewSha": "9b036bf2218590e8549d56274f3e3b4ed2bf69b1935da75dc5f81891bcae5fee"
},
{
"rev": 304,
"op": "dewey-r51-rework-2",
"verb": "move",
"args": {
"id": 51,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-10T06:40:54.779Z",
"semantics": 2,
"result": {
"row": 51,
"from": "in-review",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok dewey-r51-rework-2 rev 304 row 51 in-review→in-progress"
},
"viewSha": "faea99c3e4bb26e16e9ff20b68d83f320fb3845d6c68d9f8fed7f6a424733081"
},
{
"rev": 305,
"op": "dewey-51-review-2",
"verb": "move",
"args": {
"id": 51,
"to": "in-review",
"reason": null,
"candidate": "agents/dewey/work/queue-51/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-10T06:40:57.743Z",
"semantics": 2,
"result": {
"row": 51,
"from": "in-progress",
"to": "in-review",
"round": 2,
"issue": 1537,
"candidate": {
"kind": "manifest",
"digest": "c34039dc0d52b965bd73cc9f079ae7b253140d77713a3323abc4743f359f0c02",
"text": "d7ae740247a7dbd26bdcadfe97e1acf70121911d6fed69f4fc2408f483279ef8 agents/dewey/work/queue-51/evidence.md\naaefe3cd02ea25dc00c31d0f94ef4c74544b9929614618511be294aa314de9ce packages/conversation/README.md\nae9cd6f800d57412ff04da7673bff6b62d506ec4ac46a15d351a45a5087a8953 packages/conversation/src/controller.mjs\n6fada028358fbfe79f2a7dbda7fee8028142a833caed5bd3c2d4f00e861a19ec packages/conversation/tests/cohort.test.mjs\n3409fcce6ebb0281b5e018983a005b0c23b8641ba69cd25ea8aec6c161870d3b packages/conversation/tests/ctrl-child.mjs\n"
},
"receipt": "ok dewey-51-review-2 rev 305 row 51 in-progress→in-review round 2 on #1537; request dewey-51-review-2 requesting"
},
"viewSha": "a0446d7e2eceb811e7f1d6fcf27a9aa3ae11a3725c98eec4991d7ad94b824387"
},
{
"rev": 306,
"op": "dewey-51-review-2.outcome",
"verb": "review-outcome",
"args": {
"id": 51,
"attempt": "dewey-51-review-2",
"outcome": "posted",
"status": 201,
"comment": 27072,
"detail": "created"
},
"by": "dewey",
"at": "2026-10-10T06:40:58.969Z",
"semantics": 2,
"result": {
"row": 51,
"round": 2,
"attempt": "dewey-51-review-2",
"state": "posted",
"receipt": "ok dewey-51-review-2.outcome rev 306 row 51 round 2 request dewey-51-review-2 posted comment 27072"
},
"viewSha": "0d7dd646c4ee749874117671b4fa48c2a50da5edc484ebdc5476a20f55b3da1f"
},
{
"rev": 307,
"op": "filbert-r51-review-2",
"verb": "review-record",
"args": {
"id": 51,
"verdict": "approve",
"comment": 27074,
"candidate": "c34039dc0d52b965bd73cc9f079ae7b253140d77713a3323abc4743f359f0c02"
},
"by": "filbert",
"at": "2026-10-10T06:52:13.141Z",
"semantics": 2,
"result": {
"row": 51,
"round": 2,
"verdict": "approve",
"receipt": "ok filbert-r51-review-2 rev 307 row 51 round 2 approve by filbert (comment 27074)"
},
"viewSha": "c42c3aeeb51231b809a7fc471a5f16f330b55757772c1f9f5c2deda2df2b3f7e"
}
]
}