queue: row 112 round 2 approvals and done (#1606, revs 1115-1117)

2026-10-14 11:09:12 -05:00
parent cc48b124f1
commit 5b86abe47d
2 changed files with 93 additions and 11 deletions
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.

 <!-- mosaic-queue:begin -->

-Generated from `docs/plans/queue.json` revision 1114 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
+Generated from `docs/plans/queue.json` revision 1117 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.

 | # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
 |---|---|---|---|---|---|---|---|---|
@@ -148,7 +148,7 @@ Generated from `docs/plans/queue.json` revision 1114 by `queue render`. Do not e
 | 109 | PM: a new run reads current launch state and task status before it plans | researcher; reviewers filbert | #1603 | done | — | Filbert approves on #1603 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and re-pin under Mos's go (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § A new PM run reads current launch state and task status before it plans | Landed badfa52b9, pushed. verify-commit ok (11 paths). Sage gate on 9774d70db plus row109.patch: every package suite and every script suite green on the first run, skipped 0 in bus, harness and seat. #1603 comment 28348, closed. Vikunja #259 stays open until the re-pin is live and a fresh PM run reads allowed. |
 | 110 | Bus tester identity for PM tests, replacing the tmux path (Q134 A) | darkwing; reviewers filbert, sage | #1604 | done | 106 done, 109 done | Filbert and Sage approve on #1604 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy, re-pin and bus restart under Mos's go; tmux path retired by Mos (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § Bus tester identity for PM tests | Landed 179697a8a (round 2 manifest bdaf7f47, verify-commit ok), pushed; #1604 closed (28368). Not live: needs new copy, re-pin and bus restart under Mos's go, and bus.tester true in the business file, held under decision 104 until Q135. Gate flakes outside the row: Vikunja #262, #263. |
 | 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. |
-| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | in-review, round 2, request posted | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
+| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | done | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
 | 113 | The weekly ledger runs on current T3 and a week with more than 50 updated issues | darkwing; reviewers filbert | #1607 | briefed | 112 done | Filbert approves on #1607 naming the candidate manifest; Sage's full gate rerun at the landing target; after landing Sage runs 2026-10-04..10-10 with issues and T3 and exits 0 (sage) | `docs/plans/2026-10-14_ledger-reasoning-and-issue-pages.md` § The weekly ledger runs on current T3 and a week with more than 50 updated issues | — |

 <!-- mosaic-queue:end -->
@@ -1,7 +1,7 @@
 {
  "version": 1,
  "canonicalRoot": "/mnt/storage/src/mosaic-stack",
-  "revision": 1114,
+  "revision": 1117,
  "rows": [
    {
      "id": 1,
@@ -10107,7 +10107,7 @@
      "closes": [
        1606
      ],
-      "state": "in-review",
+      "state": "done",
      "previousState": null,
      "required": false,
      "requiredSince": null,
@@ -10202,19 +10202,33 @@
              }
            ],
            "duplicateRisk": false,
-            "receipts": []
+            "receipts": [
+              {
+                "reviewer": "filbert",
+                "op": "filbert-112-r2",
+                "at": "2026-10-14T16:01:34.656Z",
+                "verdict": "approve",
+                "comment": 28383,
+                "candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
+              },
+              {
+                "reviewer": "sage",
+                "op": "sage-112-review-2",
+                "at": "2026-10-14T16:01:38.939Z",
+                "verdict": "approve",
+                "comment": 28384,
+                "candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
+              }
+            ]
          }
        ]
      },
-      "claim": {
-        "seat": "darkwing",
-        "op": "darkwing-112-start-1"
-      },
+      "claim": null,
      "note": "Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix.",
      "blockedReason": null,
      "createdAt": "2026-10-14T15:36:36.626Z",
-      "updatedAt": "2026-10-14T16:00:14.974Z",
-      "updatedBy": "darkwing"
+      "updatedAt": "2026-10-14T16:08:37.716Z",
+      "updatedBy": "sage"
    },
    {
      "id": 113,
@@ -39686,6 +39700,74 @@
        "receipt": "ok darkwing-112-review-2.outcome rev 1114 row 112 round 2 request darkwing-112-review-2 posted comment 28382"
      },
      "viewSha": "8b3236ee2522961c4e65f18397e0f58ac3aa915af46e71597906009b7e6aa7ad"
+    },
+    {
+      "rev": 1115,
+      "op": "filbert-112-r2",
+      "verb": "review-record",
+      "args": {
+        "id": 112,
+        "verdict": "approve",
+        "comment": 28383,
+        "candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
+      },
+      "by": "filbert",
+      "at": "2026-10-14T16:01:34.656Z",
+      "semantics": 2,
+      "result": {
+        "row": 112,
+        "round": 2,
+        "verdict": "approve",
+        "receipt": "ok filbert-112-r2 rev 1115 row 112 round 2 approve by filbert (comment 28383)"
+      },
+      "viewSha": "f8af621d873e2db746f125092d3992eb942102eb63e102c8575c3a70c9660a3b"
+    },
+    {
+      "rev": 1116,
+      "op": "sage-112-review-2",
+      "verb": "review-record",
+      "args": {
+        "id": 112,
+        "verdict": "approve",
+        "comment": 28384,
+        "candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
+      },
+      "by": "sage",
+      "at": "2026-10-14T16:01:38.939Z",
+      "semantics": 2,
+      "result": {
+        "row": 112,
+        "round": 2,
+        "verdict": "approve",
+        "receipt": "ok sage-112-review-2 rev 1116 row 112 round 2 approve by sage (comment 28384)"
+      },
+      "viewSha": "f4d3aaae0b2c1ac8d045e85024458065ee9147cd8c4280ad4216b94eef4ca895"
+    },
+    {
+      "rev": 1117,
+      "op": "sage-112-done",
+      "verb": "move",
+      "args": {
+        "id": 112,
+        "to": "done",
+        "reason": null,
+        "candidate": null,
+        "evidence": null,
+        "issue": null
+      },
+      "by": "sage",
+      "at": "2026-10-14T16:08:37.716Z",
+      "semantics": 2,
+      "result": {
+        "row": 112,
+        "from": "in-review",
+        "to": "done",
+        "round": 2,
+        "issue": null,
+        "candidate": null,
+        "receipt": "ok sage-112-done rev 1117 row 112 in-review→done round 2"
+      },
+      "viewSha": "bc0b5b0d1796a1c813e3a8d7bb34b4318bee10f4d85dff72d47c5bf1debeb3df"
    }
  ]
 }